undo does not work on deleted items

[Travis Watkins]

Binary package hint: alacarte

When you delete an item from alacarte the undo functionality does not work so the item is lost. This is because in deleteItem the copy for undoing is saved _after_ the change has been made to "delete" the item instead of before. James Westby noticed this and provided a simple fix that moves the undo checkpoint before the file modification. This is a very simple and obviously correct fix and I cannot see any way for it to cause regressions. Note that this does not fix bug 118936, that bug is for revert not restoring deleted items and there is no clear way to fix it.

TEST CASE:
1. Highlight an item in alacarte
2. Press the delete key on your keyboard
3. Press Ctrl-Z to undo the change

[James Westby (james-w)]

Hi Travis,

Is this not fixed in Intrepid? If not it should be fixed there before
hardy-proposed.

Thanks,

James

[Steve Langasek (vorlon)]

Is this still unfixed in intrepid? If this is going to be fixed for hardy it needs to be fixed for later releases as well.

[James Westby (james-w)]

Hi,

Here's a tested patch against the Intrepid version.

Please sponsor in to Intrepid.

Thanks,

James

[Martin Pitt (pitti)]

Sponsored.

[Martin Pitt (pitti)]

Uploaded hardy patch as well, added missing bug # in changelog.

[Launchpad Janitor (janitor)]

This bug was fixed in the package alacarte - 0.11.6-0ubuntu2

---------------
alacarte (0.11.6-0ubuntu2) intrepid; urgency=low

  * Make undo work on deleted items. (LP: #225941)
    - Thanks to Travis Watkins.

 -- James Westby <email address hidden> Wed, 15 Oct 2008 19:23:57 +0100

[Martin Pitt (pitti)]

Accepted into hardy-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Steve Beattie (sbeattie)]

I am able to reproduce the problem with alacarte 0.11.5-0ubuntu1 in 8.04 and can confirm that alacarte 0.11.5-0ubuntu1.1 in hardy-proposed has a working undo function. Other functionality appears to still work properly, though it might be nice for alacarte to jump to the menu entry that it just reverted via the undo (particularly in multiple undo operations).

[Martin Pitt (pitti)]

Copied to hardy-updates.

[Bryan Forbes (bryanforbes)]

Hello Customer

A wide selection of brands is available to choose from.
The perfect place to buy watches as we offer best quality, excellent service, money back guarantee in case you are not satisfied and have many other strong points, such as fast delivery, helpful and caring customer service.

******************************************************
Today I received my two watches. Both watches were spectacular, you guys did a wonderful job and I will definitely recommend you to all my friends!
Thank you!
                     Will Rangel
******************************************************

Click here ---> http://penio.ru