smstools stop working after upgrade

[Peter Magnusson]

Binary package hint: smstools

Running Ubuntu 8.04 (Hardy).
If upgrading smstools from smstools-3.0.10-1 to smstools-3.0.10-1ubuntu0.1 the new /etc/smsd.conf file turns out wrong.
This makes the smsd daemon stop with the following in the eventlog.

2008-04-29 16:11:34,2, smsd: Eventhandler @EVENTHANDLER@ cannot be read: No such file or directory
2008-04-29 16:11:34,2, smsd: There was 1 major problem found.
2008-04-29 16:11:34,2, smsd: Smsd main program terminated.

I would guess this bug is in debian/postinst but I'm not sure
This error doesn't show if you do a clean install and don't upgrade.

Steps to reproduce:
1. Install smstools-3.0.10-1
2. Upgrade smstools-3.0-10-1 to smstools-3.0.10-1ubuntu0.1 (or perhaps later)

Expected result:
As we did't change anything in the config file they should be the same and the daemon should start without errors.

Actual result:
In the /etc/smsd.conf.bak states "# eventhandler = @EVENTHANDLER@"
but in the working /etc/smsd.conf the comment has been removed so it says " eventhandler = @EVENTHANDLER@"
When the daemon starts it doesn't find any file with that name so it terminates.

Workaround:
Restore /etc/smsd.conf.bak to /etc/smsd.conf or just edit /etc/smsd.conf and comment out the eventhandler line.

[Peter Magnusson (kmpm)]

I'm working on it....
Something with debconf

[Peter Magnusson (kmpm)]

Ok... I think I have sorted it out.
The package uses debconf to "manage" the config file but it has a bug regarding the handling of the default value for eventhandler.
I made a small change to debian/config that takes care of the problem (hopefully).
It basicly sets eventhandler to an empty string in debconf if it reads a @EVENTHANDLER@ from the /etc/smsd.conf

With this patch I have made clean installs and upgrades from both -1 and -1ubuntu0.1 without any problems.

[Peter Magnusson (kmpm)]

A new, updated, debdiff
 - target is now hardy-proposed
 - removed a debugging line in debian/config

[John Dong (jdong)]

ACK from motu-sru to upload this to proposed for testing.

[Morten Kjeldgaard (mok0)]

The current version in Debian/unstable is now 3.0.10-2, and the patch you've attached no longer applies. Please update the debdiff and let's try again!

[Morten Kjeldgaard (mok0)]

Please, address bug #221973 also when you do the merge. Thanks!

[Peter Magnusson (kmpm)]

This is a request to get in 3.0.10-2 and if the attached patch is included #221973 and #135033 will be closed.

[LaserJock (laserjock)]

Peter, do you still want this in Hardy? How is it related to bug #331973?

[LaserJock (laserjock)]

bug #221973 rather ;-)

[Peter Magnusson (kmpm)]

This isn't directly related to #221973 so the patch should perhaps go in there.
#221973 Was required in hardy because else it won't start after a reboot. When fixing that one I noticed that a upgrade to that "patched" version failed because of another bug. This bug (#224241) is now fixed in 3.0.10-2 and is required to let an upgrade from the hardy (3.0.10-1) version work.

Messy explanation but I hope someone gets my point.

[LaserJock (laserjock)]

I think we should fix both bug #221973 and bug #224241in Hardy at the same time. Can you please attach a debdiff to #221973 with both fixes. We can remove the current package in -proposed so you can use the same version.

[Peter Magnusson (kmpm)]

Which of these options should I do...

1. Ignore the debian -2 and just fix this #224241 bug together with the fix for #221973 in a patch for the current hardy 3.0.10-1
(this is what I think Jordan suggest)

2. Add a patch for just #221973 and let someone else sync with debians 3.0.10-2 to fix #224241

3. Add a debdiff patch with the complete changes from -1 to -2 so that it gets synced and include the fix for #221973 at the same time.

[LaserJock (laserjock)]

Peter, thanks for sticking with us on this! :-)

For Hardy we want to do 1.

For Intrepid we want to make sure everything in 3.1-1, which is what we currently have, is fixed. Can you find out if that version has fixed any of bug #135033, bug #221973, or bug #224241 ? If not it'd be great to get those fixes in Intrepid (preferably in one debdiff) as soon as we can.

[Peter Magnusson (kmpm)]

Here we go then.
This patch fixes #221973, #135033 and #224241.
It's made against 3.0.10-1 and nothing else and is supposed to fix the hardy issues.
I have started looking at the intrepid version and will probably be able to fix that one soon.

[Peter Magnusson (kmpm)]

This bug is fixed in 3.1-1 for intrepid. No need for a ubuntu specific patch for this one.
Bug #221973 is still valid though.

[Luca Falavigna (dktrkranz)]

I'm closing Intrepid task since you stated it's fixed with 3.1-1.
Can we do something for bug #221793? I'd like to have in -updates soon.

[Martin Pitt (pitti)]

The current SRU for creating /var/run/... on startup made it to -updates.

This bug is confusing, though. The hardy task is marked as invalid, and yet there are several proposed patches here. Can you please fix the status of this bug, check if anythign still needs to be done for hardy, and upload to -proposed?