GNOME Mastermind grid is shifted to the right with new cairo releases

[Filippo Argiolas]

Binary package hint: gnome-mastermind

With new cairo releases the gnome mastermind grid looks very ugly, shifted a pixel to the right.
Check the attached screenshot for a self-explanatory screenshot. Notice the white line at the right of main grid and the other issues.
This happened because some workaround I used with old cairo doesn't work with new releases (afaict after 1.5.8).
Nevertheless Cairo devs fixed an issue with cairo to make rendering more predictable when CAIRO _ANTIALIAS_NONE is set so I've made a few changes to take advantage of this.
So this is fixed with new gnome-mastermind release (0.3.1), check http://www.autistici.org/gnome-mastermind.
Attached also a diff from the source code.

Note this affects only hardy, gnome-mastermind still works good with gutsy.

apt-cache policy gnome-mastermind
gnome-mastermind:
  Installed: 0.3-1
  Candidate: 0.3-1

[Filippo Argiolas (fargiolas)]

Please note that Bart Martens, debian maintainer, already uploaded the new release to unstable.

[LaserJock (laserjock)]

Thanks for working on this. I'm a bit unsure if this really rises to the level of a SRU but on the other hand it looks pretty low-risk. I checked the new Debian package but it's rather messy (469K debdiff mostly of autotools cruft) for us to just take but your provided patch is certainly reasonable. I'd like to get more input from other MOTU SRU members but this seems pretty harmless to me.

[John Dong (jdong)]

Patch in http://launchpadlibrarian.net/13937471/patch.diff is good. Please prepare that patch into a SRU debdiff and I'll ACK it.

[Filippo Argiolas (fargiolas)]

Hey, I don't know if your request was for me since I'm not a debian nor ubuntu developer.
Btw, here is a debdiff I've made following a recipe in the wiki, seems fine to me, hope everything is ok.
Thanks

[Filippo Argiolas (fargiolas)]

Hey is there something wrong with my debdiff? why no more reply?
Thanks again,
Filippo

[Filippo Argiolas (fargiolas)]

Still I cannot understand why this patch is not being considered.. I think it's ok, is there any reason why it cannot be commited in Hardy? it's been 3 months since this bug is open and noone complained.

[Luca Falavigna (dktrkranz)]

Fixed in Intrepid.

[Luca Falavigna (dktrkranz)]

ACK from motu-sru, this is a little fix but should be safe enough to go in -proposed.

[Luca Falavigna (dktrkranz)]

I moved patch to debian/patches and adjusted debdiff a little to conform to SRU policy and sponsored version 0.3-1ubuntu0.1 to hardy-proposed.

[Martin Pitt (pitti)]

Accepted into hardy-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Filippo Argiolas (fargiolas)]

For what it's worth (I wrote the patch), I confirm the package in hardy-proposed fixes the issue here.

[Cesare Tirabassi (norsetto)]

Patch confirmed to work, with no ill observed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-mastermind - 0.3-1ubuntu0.1

---------------
gnome-mastermind (0.3-1ubuntu0.1) hardy-proposed; urgency=low

  * SRU fix for LP: #222580 - "GNOME Mastermind grid is shifted to the right
    with new cairo releases".
  * debian/patches/02_grid.diff: game grid didn't show good with cairo > 1.5.8.

 -- Filippo Argiolas <email address hidden> Mon, 28 Apr 2008 08:10:52 +0200

[Colin Watson (cjwatson)]

Copied to hardy-updates following successful verification.