update-manager: spelling errors in hardy.tar.gz

Bug #213040 reported by Peter Cordes
6
Affects Status Importance Assigned to Milestone
update-manager (Ubuntu)
Fix Released
Undecided
Michael Vogt

Bug Description

Binary package hint: update-manager

I spell-checked the files in hardy.tar.gz that update-manager downloads when upgrading from gutsy to hardy.
(I was originally looking at it to see if I was missing anything by just using aptitude, so I could remove instead of upgrade some packages, and choose different ways of resolving conflicts.)

 Anyway, I noticed enough typos that I thought it would benefit from spell checking by a native English speaker. I used emacs's ispell mode, which works pretty well for doing a batch of files, since you can just let it add all the python variable and function names to the local temporary local dictionary. That highlighted cases where a function/variable name was typoed in a comment, or even in code in one case.

 I fixed many typos, and some grammar and awkward language, in error and dialogue strings. I fixed on typo in an environment variable name, and another in a variable name that was mis-typed in an error-handling block. There were many spelling errors in the code comments, which I fixed, but I didn't try to re-word many of the comments, since they're not user-visible.

  I haven't tried to verify that the code still works, since I'm done upgrading to Hardy beta (using aptitude, which worked nicely). I do know a little Python, and most of the changes are in comments and logging strings, not in anything that other code looks at.

 Anyway, I hope this helps.

Tags: patch
Revision history for this message
Peter Cordes (peter-cordes) wrote :
Revision history for this message
Richard Birnie (rbirnie-deactivatedaccount) wrote :

Peter,

thanks for including the corrections. It would be a big help if you could also provide a diff between your version of the files and the original version so that a developer can review the changes

Revision history for this message
xtknight (xt-knight) wrote :

This debdiff should fix the problem. Thanks for the patch, Peter Cordes.

Changed in update-manager:
status: New → Confirmed
Revision history for this message
Daniel Holbach (dholbach) wrote :

Michael: can you please take a look at it?

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks a lot, patch commited :)

Changed in update-manager:
assignee: nobody → mvo
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:0.90.0

---------------
update-manager (1:0.90.0) intrepid; urgency=low

  * merged branches:
    - ~alefteris/update-manager/alefteris (thanks!)
  * UpdateManager/Core/DistUpgradeFetcherCore.py:
    - do not crash if the tarfile can not be read (LP: #203504)
  * fix a bunch of spelling mistakes (LP: #213040), thanks
    to Peter Cordes
  * AutoUpgradeTester/automatic-upgrade-testing:
    - add "--additional-pkgs" argument that can be used to install
      the given packages (seperated with ",") into the VM before
      the upgrade is performed
  * DistUpgrade/DistUpgradeConfigParser.py:
    - write error to log in getListFromFile() if file is not
      found
  * DistUpgrade/DistUpgradeCache.py:
    - fix plural form text (LP: #226695)
  * update-manager-core.install, update-manager.install:
    - move the DistUpgrade part into update-manager-core
  * DistUpgrade/DistUpgradeController.py, update-manager, dist-upgrade.py:
    - move partialUpgrade() functionality into the controller and
      expose it with --partial in dist-upgrade.py
  * DistUpgrade/DistUpgrade.cfg:
    - prepare for hardy->intrepid upgrades

 -- Michael Vogt <email address hidden> Tue, 06 May 2008 10:02:16 +0200

Changed in update-manager:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.