[FFe] Please upgrade to new upstream release

[Matti Lindell]

Binary package hint: obex-data-server

Upstream released a minor bug-fix release today which fixes two crashers (including bug #196733). Version also adds a new feature, but overall changes look small. New 0.3.1 version is available at http://tadas.dailyda.com/software/obex-data-server-0.3.1.tar.gz

0.3.1 version
 * Fix two crashers (bugs #57, #59)
 * Add SDP record support for PBAP server (no real PBAP support yet) (bug #60)
 * Fix naming issue in configure.in

[Onkar Shinde (onkarshinde)]

@Matti,

AFAIK, The new practice is to attach only .diff.gz when requesting new releases instead of interdiff. :-)

[Loïc Minier (lool)]

I reviewed the full diff; it looks quite reasonable, but I have to actually test the new release.

I also wonder whether the new debug message is visible in .xsession-errors.

[Loïc Minier (lool)]

I gave the new release a spin by merging the proposed debdiff with 0.3-0ubuntu2 from #196733 and it worked fine, I didn't get any additional debugging in .xsession-errors.

This looks good to include.

[Steve Langasek (vorlon)]

FFe ack, please go ahead.

[Matti Lindell (mlind)]

It would be reasonable to just sync the package from Debian unstable as it has the 0.3.1 version, including fixes for packaging information and a patch for more friendly usage of ods-server-test.py.

[Daniel Holbach (dholbach)]

Loïc: can you please take care of it?

[Loïc Minier (lool)]

The Debian changes are hard to review and suspicious:
obex-data-server-0.3.1/src/ods-error.h
obex-data-server-0.3.1/src/ods-error.c
obex-data-server-0.3.1/src/ods-server-session.c
obex-data-server-0.3.1/src/ods-manager.c
obex-data-server-0.3.1/src/ods-session.c
obex-data-server-0.3.1/src/ods-common.h
obex-data-server-0.3.1/src/ods-main.c
obex-data-server-0.3.1/src/ods-bluez.c
obex-data-server-0.3.1/ChangeLog
obex-data-server-0.3.1/configure.in
obex-data-server-0.3.1/configure
obex-data-server-0.3.1/debian/rules
obex-data-server-0.3.1/debian/README.examples
obex-data-server-0.3.1/debian/changelog
obex-data-server-0.3.1/debian/obex-data-server.1
obex-data-server-0.3.1/debian/control
obex-data-server-0.3.1/debian/obex-data-server.examples
obex-data-server-0.3.1/debian/compat
obex-data-server-0.3.1/debian/watch
obex-data-server-0.3.1/debian/docs
obex-data-server-0.3.1/debian/copyright
obex-data-server-0.3.1/debian/patches/000-test-server-usage.patch
obex-data-server-0.3.1/dbus-api.txt

This looks like bogus usage of $SCM; I'm rejecting the sync which sets us back to 0.3 (the Debian diff is basically reverting most of the 0.3 -> 0.3.1 release).

[Loïc Minier (lool)]

Unsubed -sponsors; please subscribe again when either there's a debdiff against the current version to sponsor or the package is fixed in Debian and can be synced.

[Matti Lindell (mlind)]

Thanks Loïc for noticing, I overlooked the Debian changes obviously.

[Loïc Minier (lool)]

1) Please keep the simple-patchsys include; it's in Debian and we don't need to drop it; also it's considered intrusive to add/remove a patch system, so it's best to have it in place in case we need to -- for example -- add patches for security updates

2) Minor style remark: instead of saying that you revert all changes in 0.3-0ubuntu2, simply state that this and that patch were dropped ("because they were merged upstream" for instance); at least one reason for this is that it makes it easy to grep for the patch name to see in which revisions it was included; another reason is that I find it slightly negative to state that you revert the changes: the changes were truly needed back then! ;-)

Could you please prepare an updated debdiff (or .dsc + .diff.gz -- since your dropping files that's a bit easier to handle, didn't think of that when asking a debdiff) with at least 1) fixed? Thanks!

[Matti Lindell (mlind)]

Attaching required files as .tar archive

[Launchpad Janitor (janitor)]

This bug was fixed in the package obex-data-server - 0.3.1-0ubuntu1

---------------
obex-data-server (0.3.1-0ubuntu1) hardy; urgency=low

  * New upstream release (LP: #210344)
  * debian/control: Update Homepage URL
  * debian/patches/01_setlocale.patch,
    debian/patches/02_fix_umount_crash.patch:
    - Drop, merged upstream

 -- Matti Lindell <email address hidden> Tue, 08 Apr 2008 20:47:21 +0300

[Loïc Minier (lool)]

Thanks!

[Loïc Minier (lool)]

The Debian package has been fixed; if you like you can check it again and request its sync.

[Matti Lindell (mlind)]

Thanks for your help Loïc!