Module involflt doesn't build for kernel at build time

[John Cabaj]

[Impact]

* For Focal and Jammy releases, the package never left the -proposed pocket due to dh-dkms being added to initial upload during sponsorship, which is not available in those respective releases.
* For Noble release, the package is only installable via DKMS, but cannot be built and signed alongside the kernel build during kernel SRU cycle (https://wiki.ubuntu.com/Kernel/StableReleaseCadence). This is because the kernel source directory was fixed to /lib/modules/($uname -r), which works for building when DKMS package is installed, but not when built within context of a Launchpad kernel build, where the build headers are self-contained during the build process.
* Correcting src/md5.c also mistakenly set to public domain in copyright
* Using debhelper-compat (= 12) for Focal
* Correcting section from "misc" to "kernel"
* Removing executable permissions from C source files
* Updating Standards-Version to 4.7.0

[Fix]

* Simple re-package, with updated .dkms file, dependencies, and copyright

[Test Plan]

* Install requisite kernel (Focal, Jammy, or Noble) in some virtual environment (LXD or otherwise)
* Install DKMS module, which will rebuild against the kernel installed
* Ensure DKMS module builds and installs properly, and the module can be inserted via insmod

* Microsoft has additionally tested the module in-depth

[Where problems could occur]

* Regression risk is low as this module has been tested already, and these changes are limited to packaging.
* These updates allow the module to build for both Focal and Jammy, as those packages never left the -proposed pocket due to build dependency issues.
* In the case of Noble, the risk is that this could fail to build in some unforeseen circumstance where the kernel_source_dir variable is missing, though that would point to broader issues in DKMS.

[John Cabaj (john-cabaj)]

This is a debdiff for Noble applicable to 0.1.0-0ubuntu7. This was built using sbuild against a Noble chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Jammy applicable to 0.1.0-0ubuntu7~22.04.1. This was built using sbuild against a Jammy chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Focal applicable to 0.1.0-0ubuntu7. This was built using sbuild against a Focal chroot, and works as intended.

[Nick Rosbrook (enr0n)]

Hi John,

1. The first thing I notice is that the bug number is missing from all of the debdiffs.
2. Second, I am not an SRU team member, but before sponsoring I would want to be sure this has an acceptable test plan and regression risk analysis. IMO, this is currently lacking those two things. Why is the regression risk low? Where *would* a problem occur, however low the risk may be? And could you provide a test plan with more detail, e.g. what commands someone should run to test this?

[John Cabaj (john-cabaj)]

This is a debdiff for Noble applicable to 0.1.0-0ubuntu7. This was built using sbuild against a Noble chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Jammy applicable to 0.1.0-0ubuntu7~22.04.1. This was built using sbuild against a Jammy chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Focal applicable to 0.1.0-0ubuntu7. This was built using sbuild against a Focal chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Noble applicable to 0.1.0-0ubuntu7~24.04.1. This was built using sbuild against a Noble chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Oracular applicable to 0.1.0-0ubuntu7. This was built using sbuild against a Oracular chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Oracular applicable to 0.1.0-0ubuntu7. This was built using sbuild against a Oracular chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Noble applicable to 0.1.0-0ubuntu7~24.04.1. This was built using sbuild against a Noble chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Jammy applicable to 0.1.0-0ubuntu7~22.04.1. This was built using sbuild against a Jammy chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Focal applicable to 0.1.0-0ubuntu7~20.04.1. This was built using sbuild against a Focal chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Oracular applicable to 0.1.0-0ubuntu7. This was built using sbuild against a Oracular chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Noble applicable to 0.1.0-0ubuntu7~24.04.1. This was built using sbuild against a Noble chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Jammy applicable to 0.1.0-0ubuntu7~22.04.1. This was built using sbuild against a Jammy chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Focal applicable to 0.1.0-0ubuntu7~20.04.1. This was built using sbuild against a Focal chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Oracular applicable to 0.1.0-0ubuntu7. This was built using sbuild against a Oracular chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Noble applicable to 0.1.0-0ubuntu7~24.04.1. This was built using sbuild against a Noble chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Jammy applicable to 0.1.0-0ubuntu7~22.04.1. This was built using sbuild against a Jammy chroot, and works as intended.

[John Cabaj (john-cabaj)]

This is a debdiff for Focal applicable to 0.1.0-0ubuntu7~20.04.1. This was built using sbuild against a Focal chroot, and works as intended.

[Benjamin Drung (bdrung)]

Sponsored latest patches for oracular, noble, jammy, focal.

[Launchpad Janitor (janitor)]

This bug was fixed in the package involflt - 0.1.0-0ubuntu7

---------------
involflt (0.1.0-0ubuntu7) oracular; urgency=medium

  * Module doesn't build for kernel at build time (LP: #2073010)
    - Modifying kernel source directory fixed to /lib/modules to
      kernel_source_dir
    - Changing from "misc" section to "kernel"
    - Removing executable permission on source files (.c, .h)
    - Updated Standards-Version to 4.7.0

 -- John Cabaj <email address hidden> Fri, 19 Jul 2024 18:05:56 +0200

[Brian Murray (brian-murray)]

Hello John, or anyone else affected,

Accepted involflt into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/involflt/0.1.0-0ubuntu7~24.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello John, or anyone else affected,

Accepted involflt into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/involflt/0.1.0-0ubuntu7~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello John, or anyone else affected,

Accepted involflt into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/involflt/0.1.0-0ubuntu7~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.