ui.patron.edit.au.second_given_name.show doesn't do anything on OPAC

[Llewellyn Marshall]

Evergreen 3.11.1

One of our team members was going through library settings and found that setting ui.patron.edit.au.second_given_name.show to false had no effect on the OPAC's patron self registration form. "Middle Name" will show up on the form no matter what.

After a lot of testing and digging through source code, I discovered that the code in perlmods/lib/OpenILS/WWW/EGCatLoader/Register.pm will skip any library settings that do not have a truthy value. False is not a truthy value and therefore our setting is skipped, becomes undefined, and then set to the hardcoded truthy value for second_given_name.

I will be attaching a very small patch that will check if the setting is defined rather than truthy.

[Llewellyn Marshall (lbmarshallv)]

my branch off of main

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/lew/lp2071656_false_regis_settings

[Jennifer Pringle (jpringle-u)]

I think this bug may be a duplicate of https://bugs.launchpad.net/evergreen/+bug/1815950

[Llewellyn Marshall (lbmarshallv)]

This glitch is only found on the OPAC's patron self registration form and not the patron edit page in the staff client.