lxd-installer wait message confuses version checkers
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
lxd-installer (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The fact that lxd-installer echoes "Installing LXD snap, please be patient." to stdout while it `snap install lxd` behind the scene can confuse version checkers like `snapcraft`:
$ lxc launch ubuntu-
$ lxc exec o1 -- apt-get update -qq
$ lxc exec o1 -- apt-get install --no-install-
$ lxc exec o1 -- git clone https:/
$ lxc exec o1 -- snap wait system seed
$ lxc exec o1 -- snap install --classic snapcraft
$ lxc exec o1 -- sh -c 'cd /root/lxd-pkg-snap && snapcraft'
craft-providers error: Failed to parse LXD version.
Version data returned: 'Installing'
Full execution log: '/root/
In the above, we see that `snapcraft` tried to interpret the first word on stdout ("Installing") as the LXD version but that's failing for obvious reasons.
lxd-installer should not output anything to stdout as that should be left to the real `lxd` and `lxc` commands.
Related branches
- Lucas Kanashiro (community): Approve
- Thomas Parrott (community): Approve
-
Diff: 89 lines (+19/-9)5 files modifiedMakefile (+2/-1)
debian/changelog (+9/-0)
debian/control (+1/-1)
debian/tests/install-on-demand (+2/-2)
scripts/lxc (+5/-5)
This bug was fixed in the package lxd-installer - 7
---------------
lxd-installer (7) oracular; urgency=medium
* scripts/lxc: output to stderr only (LP: #2069754) install- on-demand: check user notification on stderr
- d/tests/
* Makefile: make `lxd` a symlink to /usr/sbin/lxc
* d/control: bump standards-version to 4.7.0 (no change required)
-- Simon Deziel <email address hidden> Tue, 18 Jun 2024 11:17:33 -0400