ddcci-dkms FTBS with linux hwe 6.8 on jammy

[Andrea Righi]

[Impact]

/var/lib/dkms/ddcci/0.4.1/build/ddcci/ddcci.c:1677:9: error: implicit declaration of function ‘strlcpy’; did you mean ‘strscpy’? [-Werror=implicit-function-declaration]
 1677 | strlcpy(info->type, (outer_addr == DDCCI_DEFAULT_DEVICE_ADDR) ? "ddcci" : "ddcci-dependent", I2C_NAME_SIZE);
      | ^~~~~~~
      | strscpy
/var/lib/dkms/ddcci/0.4.1/build/ddcci/ddcci.c: At top level:
/var/lib/dkms/ddcci/0.4.1/build/ddcci/ddcci.c:1835:27: error: ‘I2C_CLASS_DDC’ undeclared here (not in a function); did you mean ‘I2C_CLASS_SPD’?
 1835 | .class = I2C_CLASS_DDC,
      | ^~~~~~~~~~~~~
      | I2C_CLASS_SPD
cc1: some warnings being treated as errors

[Test case]

install both GA and HWE kernels, and

 $ sudo apt install ddcci-dkms

then check that the build for both kernels succeeds

[Fix]

Backport from Noble the required changes to properly support the new 6.8 kernel ABI.

[Regression potential]

DDC/CI is a driver for compatible monitors and their integration into the backlight system class. We may experience graphical regressions in systems that are using this particular driver.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: ddcci-dkms 0.4.1-3ubuntu3
ProcVersionSignature: User Name 6.8.0-35.35.1~22.04.1-lowlatency 6.8.4
Uname: Linux 6.8.0-35-lowlatency x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSubPlatform: config-disk (/dev/vdb)
Date: Tue Jun 18 09:22:45 2024
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=C.UTF-8
 SHELL=/bin/bash
SourcePackage: ddcci-driver-linux
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

Test build with the new 6.8 HWE kernel:

ddcci.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

ddcci-backlight.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

Test build with GA kernel 5.15:

ddcci.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

ddcci-backlight.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

[Robie Basak (racb)]

Please amend the Test Plan to make it clear that testing both the GA and HWE kernels is required. I expect to see this in the Test Plan for every HWE backport fix (and if it's not required then an explanation as to why).

I understand that I could just do this myself but it feels like every time I look at an HWE backport fix this isn't in the Test Plan, so I'm pushing back now to get this done properly from the beginning. That way there will be less effort for everyone at a time that the SRU queues are quite large and efficiency matters.

[Timo Aaltonen (tjaalton)]

Hello Andrea, or anyone else affected,

Accepted ddcci-driver-linux into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ddcci-driver-linux/0.4.1-3ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Paolo Pisati (p-pisati)]

$ dkms status
ddcci/0.4.1, 5.15.0-113-generic, x86_64: installed
ddcci/0.4.1, 6.8.0-38-generic, x86_64: installed

GA:
$ lsmod | grep ddcci
ddcci 45056 0

HWE:
$ lsmod | grep ddcci
ddcci 45056 0

build, install and load fine on GA and HWE kernels.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ddcci-driver-linux - 0.4.1-3ubuntu4

---------------
ddcci-driver-linux (0.4.1-3ubuntu4) jammy; urgency=medium

  * Support Linux 6.8 ABI (LP: #2069710):
    - debian/patches/Linux-6.8-support.patch

 -- Andrea Righi <email address hidden> Fri, 21 Jun 2024 06:58:27 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for ddcci-driver-linux has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.