[SRU] fix for user first run should not affect live session user

[Erich Eickmeyer]

[Impact]

The fix for configuring users for audio in Ubuntu Studio in LP: #2063899 and LP: #2067510 should not affect and launch for the live session user as it will adversely prompt for a restart when this is not necessary for the live session.

While the live session user is, admittedly, not part of the audio group (which should be rectified somehow but is outside of the scope of this SRU), we want to prevent Ubuntu Studio Audio Configuration from launching to do this. This is done by preventing a user named `ubuntu-studio` from running the fix.

[Test Case]

With a live .iso image of Ubuntu Studio

 * Fully `apt upgrade`
 * `systemctl --global enable ubuntustudio-fix-firstrun.service`
 * `systemctl restart sddm`

Expected: Nothing
Actual: User is prompted to reboot

[What could go wrong]

This means that a user cannot be created with the username `ubuntu-studio` and expect normal operation. Users will be notified via release notes that this is the case as it's a reserved username for the live session user. Also, users will be notified via release notes that Ubuntu Studio should not be normally run via persistent USB but should be installed to a system, and that we cannot support persistent USB setups.

With the demand Ubuntu Studio has on systems from its applications, realistically, we don't support USB pendrive setups anyhow, so persistent USB setups are discouraged, but now they will be explicitly unsupported.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntustudio-installer - 1.21

---------------
ubuntustudio-installer (1.21) oracular; urgency=medium

  * Globally enable ubuntustudio-fix-firstrun.service (LP: #2067510)
  * Prevent ubuntustudio-fix-firstrun.service from having effect
    on live session user (LP: #2067512)

 -- Erich Eickmeyer <email address hidden> Wed, 29 May 2024 11:33:00 -0700

[Timo Aaltonen (tjaalton)]

Hello Erich, or anyone else affected,

Accepted ubuntustudio-installer into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntustudio-installer/1.18.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Erich Eickmeyer (eeickmeyer)]

Unfortunately, verification has failed in this case as during testing, using ubuntustudio-installer/1.18.3 from noble-proposed, it would pop-up prior to loading the system installer (ubuntu-desktop-bootstrap) and wouldn't start the installer until after it was closed.

This simply will require the User systemd service file to be changed to the following:

- ExecStart=sh -c 'if ! [ -e ${HOME}/.config/ubuntustudio-audio-firstrun ]; then /usr/bin/ubuntustudio-audio-config; fi'
+ ExecStart=sh -c 'if ! [ -e ${HOME}/.config/ubuntustudio-audio-firstrun ] && ! [ "$(id -nu)" = "ubuntu-studio" ]; then /usr/bin/ubuntustudio-audio-config; fi'

This will prevent it from running in the Live Session user on startup completely.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntustudio-installer - 1.22

---------------
ubuntustudio-installer (1.22) oracular; urgency=medium

  * Prevent ubuntudio-fix-firstrun.service from launching for live
    session user (LP: #2067512)

 -- Erich Eickmeyer <email address hidden> Fri, 14 Jun 2024 12:00:42 -0700

[Mauricio Faria de Oliveira (mfo)]

Hello Erich, or anyone else affected,

Accepted ubuntustudio-installer into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntustudio-installer/1.18.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Erich Eickmeyer (eeickmeyer)]

$ apt-cache policy ubuntustudio-installer
ubuntustudio-installer:
  Installed: 1.18.4
  Candidate: 1.18.4
  Version table:
 *** 1.18.4 100
        100 http://us.archive.ubuntu.com/ubuntu noble-proposed/universe amd64 Packages
        100 http://us.archive.ubuntu.com/ubuntu noble-proposed/universe i386 Packages
     1.18.2 500
        500 http://us.archive.ubuntu.com/ubuntu noble-updates/universe amd64 Packages
        500 http://us.archive.ubuntu.com/ubuntu noble-updates/universe i386 Packages
     1.18 500
        500 http://us.archive.ubuntu.com/ubuntu noble/universe amd64 Packages
        500 http://us.archive.ubuntu.com/ubuntu noble/universe i386 Packages

* Upgraded fully
* Installed from noble-proposed
* Restarted sddm to restart live session
* ubuntustudio-audio-config did *not* pop-up at all.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntustudio-installer - 1.18.4

---------------
ubuntustudio-installer (1.18.4) noble; urgency=medium

  * Prevent ubuntudio-fix-firstrun.service from launching for live
    session user (LP: #2067512)

ubuntustudio-installer (1.18.3) noble; urgency=medium

  * Globally enable ubuntustudio-fix-firstrun.service (LP: #2067510)
  * Prevent ubuntustudio-fix-firstrun.service from having effect
    on live session user (LP: #2067512)

 -- Erich Eickmeyer <email address hidden> Fri, 14 Jun 2024 12:00:42 -0700

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for ubuntustudio-installer has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.