Option needed to Honor OPAC Visibility in the Staff Catalog Search Library Selector

[Michele Morgan]

Breaking this off from bug 1910773:

The Angular staff catalog needs an option to control visibility of org units in the Search Library selector, similar to the global flag 'Org Units Do Not Inherit Visibilty' that applies to the public catalog.

More information was shared for feedback to the general Evergreen list in this thread:
http://list.evergreen-ils.org/pipermail/evergreen-general/2024-January/002358.html

And this followup sharing the requirements:
http://list.evergreen-ils.org/pipermail/evergreen-general/2024-March/002455.html

Sharing the requirements here also:
https://docs.google.com/document/d/1Aioe5GfQXHXrWVF90r_xdsbMhm1PjHP1vFOyyO0R3DY/edit?usp=sharing

Jane Sandberg will be doing this work on behalf of NOBLE.

[Jane Sandberg (sandbergja)]

Here is a branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2063849-staff-catalog-hidden-ous / user/sandbergja/lp2063849-staff-catalog-hidden-ous
Here is a 3.12-compatible branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2063849-staff-catalog-hidden-ous-3-12 / user/sandbergja/lp2063849-staff-catalog-hidden-ous-3-12

Here are some testing notes:

1. Use the OU admin screen (Administration > Server Administration > Organizational Units) to set some systems, branches, bookmobiles, etc. to not be visible in the Staff Catalog. Include at least one case in which a branch is visible but its parent system is not. Note: if you are using the classic concerto data set, there is a new branch called BR5 that is not visible in the staff catalog.
2. Run autogen.sh as the opensrf user
3. Go to the staff catalog.
4. Open the staff catalog org unit selector. The expected behavior is that the org units that you hid in step 1 will no longer appear in the dropdown.
5. Do some searches for titles that can only be found at the org units that you hid in step 1. Expected behavior is that they will not appear in the search results.
6. Search for a title at the visible branch with an invisible system parent. Expected behavior is that the item counts on the search result screen will include counts for the consortium and the branch, but not the hidden system.

Note that this bug has some definite similarities to bug 1849497. The main difference is that this totally takes non-visible org units out of the library selector in the UI, and takes away the ability to search them. Josh's patch leaves the orgs in the library selector as an opt-in, so that it's still possible to do searches at those orgs if needed.

Not adding pullrequest yet, to give NOBLE a chance to test this.

[Jane Sandberg (sandbergja)]

Whoops, I neglected to mention: This work is perched atop the branch for bug 2062917. So it's 1 commit from that bug, then 5 commits for this one, making a total of 6 commits you'll need to try this development out.

[Jane Sandberg (sandbergja)]

Grabbing this ticket again to rebase on the new branch for bug 2062917, which restores the ability to show combined org name + org shortname in the catalog org selector.

[Jane Sandberg (sandbergja)]

Rebase force-pushed to both user/sandbergja/lp2063849-staff-catalog-hidden-ous and user/sandbergja/lp2063849-staff-catalog-hidden-ous-3-12

[Michele Morgan (mmorgan)]

Thanks for your work on this, Jane! I have found one issue:

In Search Preferences, I am able to see and select the org units that are not staff catalog visible as Default Search Library and Preferred Library.

Setting a not staff catalog visible org unit as the preferred library has no observable negative affect, but selecting a not staff catalog visible org unit as the Default Search Library results in searches that never complete.

I would say that the not staff catalog visible org units should not display in the Search Preferences dropdown.