[jammy/mantic] ftbfs due to build-time incompatibility with updated openvswitch

[Frode Nordahl]

[Impact]
ovn package currently FTBFS due to changes in the openvswitch package after recent security updates - doc tooling in the openvswitch source package that ovn uses has changed.

[Test Case]
Build ovn package in mantic or jammy
Build fails:

make[2]: *** No rule to make target '/home/ubuntu/ovn/b/ovn-22.03.3/ovs/python/build/soutil.py', needed by 'manpages.mk'. Stop.

Confirm manpages are built properly with the new pacakge.

[Where problems could occur]
The proposed patches change the part of the build process uses to generate documentation (manpages), so we need to make sure the new package actually have manpages properly generated.

[Original bug report]
make[2]: *** No rule to make target '/home/ubuntu/ovn/b/ovn-22.03.3/ovs/python/build/soutil.py', needed by 'manpages.mk'. Stop.

For jammy we need [0].
For mantic we need to drop d/p/revert-ovs-python-build-rename.patch

0: https://github.com/ovn-org/ovn/commit/827ff007a254acb929d06772da42a2bd5c7b2a68

[Andreas Hasenack (ahasenack)]

You could have versioned the mantic package as 23.09.0-1ubuntu0.2 instead of 23.09.0-1ubuntu1. But since noble is at 24.03.x already, I don't see a conflict arising there.

Since this changes how manpages are build, please add a simple test case check for these. Check that the shipped manpages are built correctly, have no syntax errors, etc.

Your [Where problems could occur] section is merely stating what you changed, not what could go wrong. In this particular case, since you are changing how manpages are built, that is what could go wrong, and is why I ask that you please add the test case item I mentioned above.

[Andreas Hasenack (ahasenack)]

Hello Frode, or anyone else affected,

Accepted ovn into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ovn/23.09.0-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andreas Hasenack (ahasenack)]

Hello Frode, or anyone else affected,

Accepted ovn into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ovn/22.03.3-0ubuntu0.22.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Frode Nordahl (fnordahl)]

This log contains output from the ovn system testsuite for kernel data path with this package source facilitated by backporting the autopkgtest from noble.

[Frode Nordahl (fnordahl)]

This log contains output from the ovn system testsuite for dpdk data path with this package source facilitated by backporting the autopkgtest from noble.

[Frode Nordahl (fnordahl)]

This log contains output from the ovn system testsuite for kernel data path with this package source facilitated by backporting the autopkgtest from noble.

There is no dpdk data path testsuite available for the version of OVN in jammy.

[Frode Nordahl (fnordahl)]

> You could have versioned the mantic package as 23.09.0-1ubuntu0.2 instead of 23.09.0-1ubuntu1. But since noble is at 24.03.x already, I don't see a conflict arising there.

Ack, thanks, I'll make sure to use the expected versioning scheme for SRU's moving forward.

> Since this changes how manpages are build, please add a simple test case check for these. Check that the shipped manpages are built correctly, have no syntax errors, etc.
> Your [Where problems could occur] section is merely stating what you changed, not what could go wrong. In this particular case, since you are changing how manpages are built, that is what could go wrong, and is why I ask that you please add the test case item I mentioned above.

Ack, have added a manpage-centric test case and will provide binary package test results in the next comments.

[Frode Nordahl (fnordahl)]

ubuntu@m-lp-2056769:~$ sudo apt install ovn-central ovn-host
ubuntu@m-lp-2056769:~$ dpkg -l | grep ovn
ii ovn-central 23.09.0-1ubuntu0.1 amd64 OVN central components
ii ovn-common 23.09.0-1ubuntu0.1 amd64 OVN common components
ii ovn-host 23.09.0-1ubuntu0.1 amd64 OVN host components
ubuntu@m-lp-2056769:~$ dpkg -L ovn-central ovn-common ovn-host | awk '/man.*..gz/'|xargs zcat|sha1sum
00665fbed247f989d18f5b01ce3404f8ca9b241d -

ubuntu@m-lp-2056769:~$ sudo apt -t mantic-proposed install ovn-central ovn-host
ubuntu@m-lp-2056769:~$ dpkg -l | grep ovn
ii ovn-central 23.09.0-1ubuntu1 amd64 OVN central components
ii ovn-common 23.09.0-1ubuntu1 amd64 OVN common components
ii ovn-host 23.09.0-1ubuntu1 amd64 OVN host components
ubuntu@m-lp-2056769:~$ dpkg -L ovn-central ovn-common ovn-host | awk '/man.*..gz/'|xargs zcat|sha1sum
00665fbed247f989d18f5b01ce3404f8ca9b241d -

[Frode Nordahl (fnordahl)]

ubuntu@j-lp-2056769:~$ sudo apt install ovn-central ovn-host
ubuntu@j-lp-2056769:~$ dpkg -l | grep ovn
ii ovn-central 22.03.3-0ubuntu0.22.04.2 amd64 OVN central components
ii ovn-common 22.03.3-0ubuntu0.22.04.2 amd64 OVN common components
ii ovn-host 22.03.3-0ubuntu0.22.04.2 amd64 OVN host components
ubuntu@j-lp-2056769:~$ for f in $(dpkg -L ovn-central ovn-common ovn-host | awk '/man.*..gz/') ; do mkdir -p 22.03.3-0ubuntu0.22.04.2;cp $f 22.03.3-0ubuntu0.22.04.2;done

ubuntu@j-lp-2056769:~$ sudo apt install ovn-central ovn-host
ubuntu@j-lp-2056769:~$ dpkg -l |grep ovn
ii ovn-central 22.03.3-0ubuntu0.22.04.3 amd64 OVN central components
ii ovn-common 22.03.3-0ubuntu0.22.04.3 amd64 OVN common components
ii ovn-host 22.03.3-0ubuntu0.22.04.3 amd64 OVN host components
ubuntu@j-lp-2056769:~$ for f in $(dpkg -L ovn-central ovn-common ovn-host | awk '/man.*..gz/') ; do mkdir -p 22.03.3-0ubuntu0.22.04.3;cp $f 22.03.3-0ubuntu0.22.04.3;done

ubuntu@j-lp-2056769:~/22.03.3-0ubuntu0.22.04.2$ gunzip *
ubuntu@j-lp-2056769:~/22.03.3-0ubuntu0.22.04.2$ ls -l
total 11
-rw-r--r-- 1 ubuntu ubuntu 8726 Mar 15 09:57 ovn-appctl.8
-rw-r--r-- 1 ubuntu ubuntu 114771 Mar 15 09:57 ovn-architecture.7
-rw-r--r-- 1 ubuntu ubuntu 34283 Mar 15 09:57 ovn-controller.8
-rw-r--r-- 1 ubuntu ubuntu 13301 Mar 15 09:57 ovn-ctl.8
-rw-r--r-- 1 ubuntu ubuntu 6229 Mar 15 09:57 ovn-detrace.1
-rw-r--r-- 1 ubuntu ubuntu 179018 Mar 15 09:57 ovn-nb.5
-rw-r--r-- 1 ubuntu ubuntu 80745 Mar 15 09:57 ovn-nbctl.8
-rw-r--r-- 1 ubuntu ubuntu 162975 Mar 15 09:57 ovn-northd.8
-rw-r--r-- 1 ubuntu ubuntu 171108 Mar 15 09:57 ovn-sb.5
-rw-r--r-- 1 ubuntu ubuntu 46296 Mar 15 09:57 ovn-sbctl.8
-rw-r--r-- 1 ubuntu ubuntu 28886 Mar 15 09:57 ovn-trace.8

ubuntu@j-lp-2056769:~/22.03.3-0ubuntu0.22.04.3$ gunzip *
ubuntu@j-lp-2056769:~/22.03.3-0ubuntu0.22.04.3$ ls -l
total 11
-rw-r--r-- 1 ubuntu ubuntu 8726 Mar 15 09:57 ovn-appctl.8
-rw-r--r-- 1 ubuntu ubuntu 114771 Mar 15 09:57 ovn-architecture.7
-rw-r--r-- 1 ubuntu ubuntu 34283 Mar 15 09:57 ovn-controller.8
-rw-r--r-- 1 ubuntu ubuntu 13301 Mar 15 09:57 ovn-ctl.8
-rw-r--r-- 1 ubuntu ubuntu 6229 Mar 15 09:57 ovn-detrace.1
-rw-r--r-- 1 ubuntu ubuntu 179018 Mar 15 09:57 ovn-nb.5
-rw-r--r-- 1 ubuntu ubuntu 80745 Mar 15 09:57 ovn-nbctl.8
-rw-r--r-- 1 ubuntu ubuntu 162975 Mar 15 09:57 ovn-northd.8
-rw-r--r-- 1 ubuntu ubuntu 171108 Mar 15 09:57 ovn-sb.5
-rw-r--r-- 1 ubuntu ubuntu 46296 Mar 15 09:57 ovn-sbctl.8
-rw-r--r-- 1 ubuntu ubuntu 28886 Mar 15 09:57 ovn-trace.8

# There is a minor change of contents for the ovn-detrace.1 file which is most likely
# caused by the difference in versions of openvswitch-source the two packages are built against.
ubuntu@j-lp-2056769:~$ diff -ru 22.03.3-0ubuntu0.22.04.2 22.03.3-0ubuntu0.22.04.3
diff -ru 22.03.3-0ubuntu0.22.04.2/ovn-detrace.1 22.03.3-0ubuntu0.22.04.3/ovn-detrace.1
--- 22.03.3-0ubuntu0.22.04.2/ovn-detrace.1 2024-03-15 09:57:07.523418777 +0000
++...

[Launchpad Janitor (janitor)]

This bug was fixed in the package ovn - 23.09.0-1ubuntu1

---------------
ovn (23.09.0-1ubuntu1) mantic; urgency=medium

  * d/control: Update openvswitch-source build dependency version.
  * d/p/revert-ovs-python-build-rename.patch: Drop to fix FTBFS
    (LP: #2056769).

 -- Frode Nordahl <email address hidden> Thu, 14 Mar 2024 14:34:06 +0000

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for ovn has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ovn - 22.03.3-0ubuntu0.22.04.3

---------------
ovn (22.03.3-0ubuntu0.22.04.3) jammy; urgency=medium

  * d/control: Update openvswitch-source build dependency version.
  * d/p/lp-2056769-ftbfs.patch: Fix FTBFS (LP: #2056769).

 -- Frode Nordahl <email address hidden> Thu, 14 Mar 2024 14:22:40 +0000

[Andreas Hasenack (ahasenack)]

Thank you for the extra verification.

I will also note that ovn on mantic is not available on the armhf architecture, including the release pocket. I.e., mantic was released without armhf binary builds of src:ovn, so this update is not introducing a regression in that regard.