FTBFS 1..42 on Riscv64

[Christian Ehrhardt ]

As seen here:
https://launchpadlibrarian.net/714631105/buildlog_ubuntu-noble-riscv64.xdp-tools_1.4.2-1ubuntu1_BUILDING.txt.gz

Working on Debian
https://buildd.debian.org/status/fetch.php?pkg=xdp-tools&arch=riscv64&ver=1.4.2-1&stamp=1707177296&raw=1

It seems our bpftools does not come in well, configure complains:

"pftool not found or doesn't support skeleton generation; not building all tools"

This works fine in former builds as well as on all architectures other than riscv64.

It installs linux-tools-generic to get that
and then configure runs this:

if command -v $BPFTOOL &>/dev/null && $BPFTOOL gen help 2>&1 | grep 'gen skeleton.*name' > /dev/null; then

[Christian Ehrhardt  (paelzer)]

According to Xypron (thanks for the help) this should work.
He tried in 24.04 and got this:

$ bpftool gen help 2>&1 | grep 'gen skeleton.*name'
bpftool gen skeleton FILE [name OBJECT_NAME]

So it should work ... ??!?

[Christian Ehrhardt  (paelzer)]

Tested on Mantic ...

Mantic@riscv64:
ubuntu@ubuntu:~$ which bpftool
/usr/sbin/bpftool
ubuntu@ubuntu:~$ dpkg -S /usr/sbin/bpftool
linux-tools-common: /usr/sbin/bpftool
ubuntu@ubuntu:~$ bpftool gen help 2>&1 | grep 'gen skeleton.*name'
ubuntu@ubuntu:~$ bpftool gen help 2>&1
WARNING: bpftool not found for kernel 6.5.0-9

$ sudo apt install linux-tools-6.5.0-9-generic
$ bpftool gen help 2>&1 | grep 'gen skeleton.*name'
       bpftool gen skeleton FILE [name OBJECT_NAME]

So maybe dependencies are broken and the right thing isn't pulled in anymore?

This is redirected and actually in here.
1. /usr/sbin/bpftool = script that selects for the current kernel
And that is actually in:
2. linux-riscv-tools-6.5.0-9: /usr/lib/linux-riscv-tools-6.5.0-9/bpftool

Now on the builders we have this:
   3 Kernel version: Linux bos03-riscv64-017 5.19.0-1021-generic #23~22.04.1-Ubuntu SMP Thu Jun 22 12:49:35 UTC 2023 riscv64

[Christian Ehrhardt  (paelzer)]

The code Debian kindly took seems not to work, debugging that on Ubuntu showed that we need a fix to find bpftool, working on that ...

[Christian Ehrhardt  (paelzer)]

Uploaded as
https://launchpad.net/ubuntu/+source/xdp-tools/1.4.2-1ubuntu2

Submitted to Debian in https://salsa.debian.org/debian/xdp-tools/-/merge_requests/3

[Christian Ehrhardt  (paelzer)]

Actually since I did so the other day it is merged in Debian, which will further reduce the delta next time.

[Launchpad Janitor (janitor)]

This bug was fixed in the package xdp-tools - 1.4.2-1ubuntu2

---------------
xdp-tools (1.4.2-1ubuntu2) noble; urgency=medium

  * d/rules: fix bpftool detection (LP: #2054095)

 -- Christian Ehrhardt <email address hidden> Fri, 16 Feb 2024 13:20:28 +0100