AAVMF firmware volume (de)serialization broken

Bug #2051348 reported by Mate Kukri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-uefivars (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

python-uefivars has some bugs and broken assumptions that make it incompatible with AAVMF (ARM64 edk2 firmware) variable volumes.

This bug has an attached debdiff that cherry-picks some patches from my upstream branch that solve the issue:
- "edk2.py: Use length from firmware volume header (Fixes #9) #10": Merged into upstream main
- "edk2.py: Improve firmware volume (de)serialization #11": Open pull request

Please see upstream bug report and pull requests for more details:
- https://github.com/awslabs/python-uefivars/issues/9
- https://github.com/awslabs/python-uefivars/pull/10
- https://github.com/awslabs/python-uefivars/pull/11

Revision history for this message
Simon Chopin (schopin) wrote :

Hi Mate,

Thanks for the debdiff. There are still a few things that can be improved before uploading, though:

* Please add a bug reference in your d/changelog entry
* We're sorely lacking context to understand what this is about, could you add some more in the bug title and description?
* Please add DEP-2 headers to your patches to make ongoing maintenance easier: https://dep-team.pages.debian.net/deps/dep3/
  Notably the headers regarding upstream status are IMHO particularly useful: Forwarded, Applied-Upstream.

Unsubscribing ubuntu-sponsors, please re-subscribe once you think my concerns have been addressed.

Cheers,
Simon

Revision history for this message
Mate Kukri (mkukri) wrote :

* Uploading new debdiff with bug reference
* Changing the title and description with more details
* Re DEP-3, these are git commits from my upstream branch cherry-picked then exported via `gbp pq export`.
  I would prefer to not mangle the headers (unless gbp pq can do DEP-3?).
  - One of these patches is already included in upstream git, and I would like the same for the others.

summary: - New version with bugfixes
+ AAVMF firmware volume (de)serialization broken
description: updated
description: updated
Revision history for this message
Mate Kukri (mkukri) wrote :
Changed in python-uefivars (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-uefivars - 1.0.0-0ubuntu2

---------------
python-uefivars (1.0.0-0ubuntu2) noble; urgency=medium

  * Cherry-pick edk2 firmware volume (de)serialization fixes (LP: #2051348)

 -- Mate Kukri <email address hidden> Mon, 12 Feb 2024 14:16:09 +0000

Changed in python-uefivars (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.