Add MediaTek Genio mt8370 support and update mt8390 and mt8395 configs

Bug #2051199 reported by ethan.hsieh
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
alsa-ucm-conf (Ubuntu)
Status tracked in Noble
Jammy
Fix Released
Undecided
Unassigned
Mantic
Fix Released
Undecided
Unassigned
Noble
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
Add MediaTek Genio mt8370 support and update mt8390 and mt8395 configs.

mt8370-evk (G510):
https://github.com/alsa-project/alsa-ucm-conf/pull/380
https://github.com/alsa-project/alsa-ucm-conf/commit/a0856afae4e8e071e7626958667cde049ec81e97
mt8390-evk (G700):
https://github.com/alsa-project/alsa-ucm-conf/pull/321
https://github.com/alsa-project/alsa-ucm-conf/commit/c5366bdff656092241225d2ad663c3e41b146f8b
mt8395-evk (G1200):
https://github.com/alsa-project/alsa-ucm-conf/pull/322
https://github.com/alsa-project/alsa-ucm-conf/commit/5e75929e8a487498e24db27023be0b57bac222b0
Fix a file type issue:
https://github.com/alsa-project/alsa-ucm-conf/pull/386
https://github.com/alsa-project/alsa-ucm-conf/commit/d864e945ce4171fcaf6249bebec4f683fef0f5cf
mt8395-evk (G1200) HDMI RX:
https://github.com/alsa-project/alsa-ucm-conf/pull/389
https://github.com/alsa-project/alsa-ucm-conf/commit/1ab2d020d71a570f691fafbd341782fabb6569d1

[Where problems could occur]
1. Patches (LP: #2000228) for mt8390-evk and mt8395-evk merged into Ubuntu archive was rejected by upstream. Replace them with new patches accepted by upstream.
2. Add initial support for mt8370-evk
3. Add mt8395-evk HDMI RX support

[Test Case]
Verify audio function on MediaTek Genio boards (mt8370-evk, mt8390-evk, and mt8395-evk).
1. Headset Jack Playback
2. Audio (Speaker) Jack Playback
3. mt8395-evk: HDMI RX

Play audio by following commands.
$ speaker-test -D pulse -c 2 -r 48000 -f S16_LE -t wav

[Regression Potential]
1. mt8370-evk: Add initial support for mt8370-evk. There should be no risk.
2. mt8390-evk and mt8395-evk: changes in configs were reviewed by upstream and new configs have been verified by MediaTek. It should be low risk.

tags: added: oem-priority originate-from-2037058
description: updated
description: updated
description: updated
description: updated
description: updated
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "noble.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
description: updated
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

Test packages

[1]: alsa-ucm-conf (1.2.10-1ubuntu3) noble
[1]: alsa-ucm-conf (1.2.9-1ubuntu3.3) mantic
[2]: alsa-ucm-conf (1.2.6.3-1ubuntu1.11) jammy

---
[1] https://launchpad.net/~ethan.hsieh/+archive/ubuntu/sru
[2] https://launchpad.net/~ethan.hsieh/+archive/ubuntu/sru-test

tags: added: originate-from-2000353
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Could you please add DEP-3 headers to the patches you're adding? If you see the patch being removed, you're going to notice the headers there, so you can use them to guide you.

I'm going to unsubscribe ubuntu-sponsors from the bug for now. Please resubscribe it once you've addressed the point above. Thanks.

Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

Hi Sergio.
I re-uploaded the patches with DEP-3 headers (Origin and Bug). Please see comment#7~9. Thanks~

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Hi Ethan,

I uploaded the change to Noble. It's better to wait for it to migrate before proceed with the other uploads.

Also, this is an Ubuntu Sponsors bug, so I will leave the other uploads to whoever is on the patch pilot shift.

Thanks.

Changed in alsa-ucm-conf (Ubuntu Noble):
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-ucm-conf - 1.2.10-1ubuntu3

---------------
alsa-ucm-conf (1.2.10-1ubuntu3) noble; urgency=medium

  * Dropped changes:
    - d/p/0001-Add-initial-support-for-MediaTek-mt8390-evk-and-mt83.patch
      - replace it with patches accepted by upstream
  * Added changes:
    - d/p/0001-ucm2-MediaTek-mt8390-evk-Add-alsa-ucm-support.patch
    - d/p/0002-ucm2-MediaTek-mt8395-evk-Add-alsa-ucm-support.patch
    - d/p/0003-ucm2-MediaTek-mt8370-evk-Add-alsa-ucm-support.patch
    - d/p/0001-ucm2-conf.d-mt8370-evk-Fix-the-type-of-mt8370-evk.co.patch
    - d/p/0001-ucm-MediaTek-mt8395-evk-Add-HDMIRX-config.patch
      - add supports for MediaTek mt8390-evk, mt8395-evk, and mt8370-evk.
      - fix a file type issue on the mt8370-evk config
      - add mt8395 HDMI RX support
        (LP: #2051199)

 -- Ethan Hsieh <email address hidden> Thu, 25 Jan 2024 13:29:18 +0800

Changed in alsa-ucm-conf (Ubuntu Noble):
status: In Progress → Fix Released
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

Hi Sergio,
Thanks~

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello ethan.hsieh, or anyone else affected,

Accepted alsa-ucm-conf into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-ucm-conf/1.2.9-1ubuntu3.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in alsa-ucm-conf (Ubuntu Mantic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-mantic
Changed in alsa-ucm-conf (Ubuntu Jammy):
status: New → Fix Committed
tags: added: verification-needed-jammy
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello ethan.hsieh, or anyone else affected,

Accepted alsa-ucm-conf into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-ucm-conf/1.2.6.3-1ubuntu1.11 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

Verified packages on matnic and jammy-proposed.
Platforms: g510 (mt8370), g1200 (mt8395), and g700 (mt8390).
1. Headset Jack Playback: Pass
2. Audio (Speaker) Jack Playback: Pass
3. HDMI TX Playback: Pass
4. mt8395-evk: HDMI RX: Pass

tags: added: verification-done-jammy verification-done-mantic
removed: verification-needed-jammy verification-needed-mantic
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Ethan, thanks for the verification.

In the future, please include the exact version of the package that you tested, and where it came from. I.e., the output of "apt-cache policy <package>" shows all that information.

There have been a few cases in the past where the verification was mistakenly done using packages from a PPA, for example, and we want to avoid that.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-ucm-conf - 1.2.9-1ubuntu3.3

---------------
alsa-ucm-conf (1.2.9-1ubuntu3.3) mantic; urgency=medium

  * Dropped changes:
    - d/p/0001-Add-initial-support-for-MediaTek-mt8390-evk-and-mt83.patch
      - replace it with patches accepted by upstream
  * Added changes:
    - d/p/0001-ucm2-MediaTek-mt8390-evk-Add-alsa-ucm-support.patch
    - d/p/0002-ucm2-MediaTek-mt8395-evk-Add-alsa-ucm-support.patch
    - d/p/0003-ucm2-MediaTek-mt8370-evk-Add-alsa-ucm-support.patch
    - d/p/0001-ucm2-conf.d-mt8370-evk-Fix-the-type-of-mt8370-evk.co.patch
    - d/p/0001-ucm-MediaTek-mt8395-evk-Add-HDMIRX-config.patch
      - add supports for MediaTek mt8390-evk, mt8395-evk, and mt8370-evk.
      - fix a file type issue on the mt8370-evk config
      - add mt8395 HDMI RX support
        (LP: #2051199)

 -- Ethan Hsieh <email address hidden> Thu, 01 Feb 2024 15:54:00 +0800

Changed in alsa-ucm-conf (Ubuntu Mantic):
status: Fix Committed → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote : Update Released

The verification of the Stable Release Update for alsa-ucm-conf has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-ucm-conf - 1.2.6.3-1ubuntu1.11

---------------
alsa-ucm-conf (1.2.6.3-1ubuntu1.11) jammy; urgency=medium

  * Dropped changes:
    - d/p/0001-Add-initial-support-for-MediaTek-mt8390-evk-and-mt83.patch
      - replace it with patches accepted by upstream
  * Added changes:
    - d/p/0001-ucm2-MediaTek-mt8365-evk-Add-alsa-ucm-support.patch
      - cherry-pick the patch for mt8365 from the dropped changes
    - d/p/0001-ucm2-MediaTek-mt8390-evk-Add-alsa-ucm-support.patch
    - d/p/0002-ucm2-MediaTek-mt8395-evk-Add-alsa-ucm-support.patch
    - d/p/0003-ucm2-MediaTek-mt8370-evk-Add-alsa-ucm-support.patch
    - d/p/0001-ucm2-conf.d-mt8370-evk-Fix-the-type-of-mt8370-evk.co.patch
    - d/p/0001-ucm-MediaTek-mt8395-evk-Add-HDMIRX-config.patch
      - add supports for MediaTek mt8390-evk, mt8395-evk, and mt8370-evk.
      - fix a file type issue on the mt8370-evk config
      - add mt8395 HDMI RX support
        (LP: #2051199)

 -- Ethan Hsieh <email address hidden> Thu, 01 Feb 2024 16:10:15 +0800

Changed in alsa-ucm-conf (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

Get it. Thanks~

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.