[SRU] Update d/control file with dependencies

[Chloé Smith]

[SRU]
=======

[Impact]

`google-guest-agent` is a package provided by Google for installation within guests that run on Google Compute Engine (GCE). It is part of a collection of tools and daemons that ensure that Ubuntu images published to GCE run properly on the platform.

There is a diff between Google's packaged debian distro [0] `debian/control` file and what's currently in the ubuntu archive. This was originally harmless but now has caused a customer issue.

Unattended upgrades caused a `google-guest-agent` update (the last release was a no-change-rebuild against `-security`) but as there was _no_ dependency on `google-compute-engine-oslogin` in the d/control file, users became locked out of their instances.

This is because the creation of the `sudoers` file has moved from the PAM module to `authorized keys` (example diffs in jammy here [1][2]). It was previously in the PAM account manager stack, but since the latest update this `google-guest-agent` version doesn't try to setup an account manager stack anymore. In other words the responsibility of creating these files has changed, but without the dependency in d/control on `google-compute-engine-oslogin` the `sudoers` file is not created when a user tries OSlogin.

[Test Case]

When the new version of this package is uploaded to -proposed, the following will happen:

 * an image based on -proposed will be built for GCE and published
 * the GCE team will be asked to validate that the new package addresses the issues it is expected to address, and that the image passes their internal image validation.
 * Each test image will be launched, and we will validate:
 ** the package version(s)
 ** that the correct ssh keys have been imported
 ** that the google specific services are running successfully

If all the testing indicates that the image containing the new package is acceptable, verification will be considered to be done.

[Additional Information]

This bug is used to track the release of this new version for all the supported suites, as per the policy mentioned here [3].

[0]: https://github.com/GoogleCloudPlatform/guest-agent/tree/main/packaging/debian
[1]: https://launchpadlibrarian.net/709883238/google-guest-agent_20220622.00-0ubuntu2~22.04.1_20231004.02-0ubuntu1~22.04.2.diff.gz
[2]: https://launchpadlibrarian.net/696732553/google-compute-engine-oslogin_20220714.00-0ubuntu1~22.04.1_20231004.00-0ubuntu1~22.04.1.diff.gz
[3]: https://wiki.ubuntu.com/google-guest-agent-Updates

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "debdiff of versions 20231004.02-0ubuntu1 vs. 20231004.02-0ubuntu2" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20231004.02-0ubuntu3

---------------
google-guest-agent (20231004.02-0ubuntu3) noble; urgency=medium

  * d/control: Fix dependency version of `google-compute-engine-oslogin`
    to match archive (LP: #2050956)

google-guest-agent (20231004.02-0ubuntu2) noble; urgency=medium

  * d/control: There should b a dependency on `google-compute-engine-oslogin`
    to match the Google managed control file (LP: #2050956)
    * Also updated the `Vcs-` fields and removed the `Uploaders` field.

 -- Chloé 'kajiya' Smith <email address hidden> Fri, 26 Jan 2024 15:12:02 +0000

[Chloé Smith (kajiya)]

Fix released in version 20231004.02-0ubuntu3

[Chloé Smith (kajiya)]

mantic debdiff (20231004.02-0ubuntu1~23.10.1ubuntu1 diffed against 20231004.02-0ubuntu1~23.10.1)

[Chloé Smith (kajiya)]

jammy debdiff (20231004.02-0ubuntu1~22.04.2ubuntu1 diffed againt 20231004.02-0ubuntu1~22.04.2)

[Chloé Smith (kajiya)]

focal debdiff (20231004.02-0ubuntu1~20.04.2ubuntu1 diffed against 20231004.02-0ubuntu1~20.04.2)

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20231004.02-0ubuntu1~20.04.3

---------------
google-guest-agent (20231004.02-0ubuntu1~20.04.3) focal-security; urgency=medium

  * d/control: Add a dependency on `google-compute-engine-oslogin`
    (LP: #2050956)

 -- Chloé 'kajiya' Smith <email address hidden> Sat, 27 Jan 2024 01:44:03 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20231004.02-0ubuntu1~23.10.2

---------------
google-guest-agent (20231004.02-0ubuntu1~23.10.2) mantic-security; urgency=medium

  * d/control: Add a dependency on `google-compute-engine-oslogin`
    (LP: #2050956)

 -- Chloé 'kajiya' Smith <email address hidden> Fri, 26 Jan 2024 23:49:12 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20231004.02-0ubuntu1~22.04.3

---------------
google-guest-agent (20231004.02-0ubuntu1~22.04.3) jammy-security; urgency=medium

  * d/control: Add a dependency on `google-compute-engine-oslogin`
    (LP: #2050956)

 -- Chloé 'kajiya' Smith <email address hidden> Sat, 27 Jan 2024 01:05:12 +0000

[Chloé Smith (kajiya)]

bionic debdiff of 20231004.02-0ubuntu1~18.04.2 vs. 20231004.02-0ubuntu1~18.04.3 (built in an ubuntu pro instance)

[Chloé Smith (kajiya)]

xenial debdiff of 20231004.02-0ubuntu1~16.04.1 vs. 20231004.02-0ubuntu1~16.04.2 (built in an ubuntu pro instance)

[Simon Chopin (schopin)]

Bionic and Xenial are out of standard support, making this out of scope for ubuntu-sponsors. I guess you should get in touch with the Security team for them to take this up?

[Chloé Smith (kajiya)]

@schopin Sorry for the noise, I'd already reached out to Security I was just using this bug as a base to share the debdiffs :)

[Chloé Smith (kajiya)]

Fixed via https://launchpad.net/~ubuntu-esm/+archive/ubuntu/esm-apps-updates (version 20231004.02-0ubuntu1~16.04.2)

[Chloé Smith (kajiya)]

Fixed via https://launchpad.net/~ubuntu-esm/+archive/ubuntu/esm-apps-updates (version 20231004.02-0ubuntu1~18.04.3)