Unable to receive canceled line items in search

[Tiffany Little]

Found on our 3.10 production server.

In Acq Search, you're unable to receive a previously cancelled line item. This is possible in the Angular PO, and should be possible in the line item search as well.

This is also possible in the legacy acq search, so adding the regression tag.

[Christine Morgan (cmorgan-z)]

Confirmed in 3.10

[Tiffany Little (tslittle)]

To add to this, since I don't think it was necessarily explicit: Not only can you not receive a previously true cancel (cancel reason with keep_debits=f) but you also can't receive something that's backordered (cancel reason with keep_debits=t).

It's more egregious not to be able to receive backordered items, since it's obviously much more frequent to receive something that was previously marked backordered.

[Tiffany Little (tslittle)]

Patch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=915f814e0d217794305c61433d64c8222eab2b6c

[Jane Sandberg (sandbergja)]

Works great for me! Thanks, Tiffany! Signoff here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/LP2047940_ReceivecanceledLIs-signoff or user/sandbergja/LP2047940_ReceivecanceledLIs-signoff

[Galen Charlton (gmc)]

After reviewing the patch, I'm setting this to needs-discussion, as the result of this patch would not be quite in alignment with the Angular LI list.

At present, the LI list will permit receiving a line item only if the line item's status is either on-order or "delayed" (i.e., cancelled with a reason that has keep_debits set to true).

The patch would permit receiving if the line item status is either on-order or cancelled, regardless of the value of keep_debits of the cancel reason.

The API that does the receiving, open-ils.acq.lineitem.receive.batch, requires that the line item status is either on-order or cancelled, regardless of the value of keep_debits of the cancel reason. It will recreate the fund debits if necessary for a fully cancelled LI.

So, my question is this: is in fact preferable to not permit receiving of "truly" cancelled LIs? Or at least put up a roadbump? Note that adding the roadblock would require code changes.

If it's preferred that receiving of cancelled LIs be permitted regardless of the keep_debits value, then line 399 of lineitem-list.component.html should be adjusted as well so that the behavior is made fully consistent.

[Tiffany Little (tslittle)]

Hi Galen, I just tested and I'm able to receive a "true canceled" line item in the Angular PO interface. (I don't have this patch loaded, fwiw.) Is that what you mean by the Angular LI list, or is there somewhere else I should double check?

I feel pretty strongly that true canceled line items should still be able to be received. We have a fair bit of accidental cancels when someone is working through a cancellation list, and then the item later arrives. This also happens a lot after fiscal year end, when vendors didn't truly cancel something that they should have and then the item arrives.

[Galen Charlton (gmc)]

Here's what I see with a test order set up with a delayed LI and a fully cancelled one:

Delayed
-------
* Actions drop-down in the LI has Mark Received active
* When expanding LI details, the Mark Received link/button is present (as is the Cancel link/button, to allow the LI to be fully cancelled)

Fully cancelled
---------------
* Actions drop-down in the LI has Mark Received inactive
* When expanding LI details, neither Mark Received nor Cancel show up

In both cases, "Mark Selected Line Items as Received" in the Actions drop-down in the PO header is active (provided that at least one LI is selected) - and will receive any LI that is on order, delayed, or cancelled.

[Galen Charlton (gmc)]

That said, in this case, I'm just advocating for consistency, so if there's consensus that cancelled LIs should be receivable without roadblocks, that's fine with me.