burp: FTBFS with zlib 1.3 due to 'make check' failure

[Shengjing Zhu]

Imported from Debian bug http://bugs.debian.org/1057880:

Source: burp
Version: 3.1.4-3
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: <email address hidden>

Dear Maintainer,

The unit tests for 'burp' perform a version check[1] on zlib to decide[2]
between a choice of zip-related assertions to run during the tests.

Most zlib versions have contained two or three dots, but the version check
logic considers version '1.3' to be less than a threshold value of '1.2.3' due
to the single dot in the former -- but that selects a faulty test assertion:

  utest/test_fzp.c:95:F:Core:test_fzp_gzseek:0: Assertion 'fzp_seek(fzp, d->pos, SEEK_SET)==-1' failed

The relevant conditional has been removed[3] entirely from upstream as cleanup
during other test-related changes, and the version of zlib in Debian
old-old-stable is 1.2.11 - so perhaps it's safe to remove the conditional from
the Debian source package too?

The test failure can be found in the test regressions currently blocking the
migration of zlib 1.3 to Debian testing in debci[4][5].

Regards,
James

[1] - https://sources.debian.org/src/burp/3.1.4-3/utest/test_fzp.c/#L182

[2] - https://sources.debian.org/src/burp/3.1.4-3/utest/test_fzp.c/#L93

[3] - https://github.com/grke/burp/commit/0de49dd3e39290ba4697ae20dd8007d31731ec84#diff-a915eb7475e84e4605e12ecb65f769d80686eda03b958929fb20303333331802L182-L183

[4] - https://qa.debian.org/excuses.php?package=zlib

[5] - https://ci.debian.net/packages/b/burp/testing/amd64/40814901/

[Launchpad Janitor (janitor)]

This bug was fixed in the package burp - 3.1.4-3ubuntu1

---------------
burp (3.1.4-3ubuntu1) noble; urgency=medium

  * Add patch to remove unnecessary but broken zlib version check in fzp test
    (Closes: #1057880, LP: #2046149)

 -- Shengjing Zhu <email address hidden> Mon, 11 Dec 2023 18:59:33 +0800