[SRU][22.04.04]: mpi3mr driver update

Bug #2045233 reported by Chandrakanth Patil
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Status tracked in Noble
Jammy
Opinion
Wishlist
Unassigned
Mantic
Fix Released
Medium
Jeff Lane 
Noble
Confirmed
Medium
Jeff Lane 

Bug Description

[Impact]

This update has been initiated to incorporate the mpi3mr driver from upstream into the upcoming Ubuntu releases (Ubuntu 22.04.x point releases).

This has been requested by both Broadcom as the upstream and by one of the larger OEM partners who are going to be selling systems with these storage controllers to customers. This series of patches includes bug fixes and support for current Broadcom controllers.

[Fixes]
Below are the commit IDs for the latest upstream version (v6.8).

The 22.04 LTS point kernel already includes the latest mpi3mr driver version 8.0.0.69.0. Therefore, the listed commit IDs below correspond to the subsequent patches.

The commit IDs listed below are in sequential order from bottom to top, indicating the order for applying the patches.

linux-next
d0a60e3edaa4 scsi: mpi3mr: Update driver version to 8.5.1.0.0
9536af615dc9 scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-3
fb231d7deffb scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-2
c432e1675239 scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-1
07ac6adda4d3 scsi: mpi3mr: Fetch correct device dev handle for status reply descriptor
f8fb3f39148e scsi: mpi3mr: Block PEL Enable Command on Controller Reset and Unrecoverable State
c01d515687e3 scsi: mpi3mr: Clean up block devices post controller reset
e5aab848dfdf scsi: mpi3mr: Refresh sdev queue depth after controller reset
b4d94164ff32 scsi: mpi3mr: driver version upgrade to 8.5.0.0.50
1193a89d2b6d scsi: mpi3mr: Add support for status reply descriptor
cb5b60894602 scsi: mpi3mr: Increase maximum number of PHYs to 64 from 32
c9260ff28ee5 scsi: mpi3mr: Add PCI checks where SAS5116 diverges from SAS4116
6fa21eab82be scsi: mpi3mr: Add support for SAS5116 PCI IDs

Mainline at 6.6/6.7
82b2fb52d6ec scsi: mpi3mr: Split off bus_reset function from host_reset
9a9068b2afa0 scsi: mpi3mr: Update driver version to 8.5.0.0.0
d9a5ab0ea98f scsi: mpi3mr: Enhance handling of devices removed after controller reset
e7a8648e1ce2 scsi: mpi3mr: WRITE SAME implementation
d9adb81e67e9 scsi: mpi3mr: Add support for more than 1MB I/O
6f81b1cfdf33 scsi: mpi3mr: Update MPI Headers to version 3.00.28
9134211f7bed scsi: mpi3mr: Invoke soft reset upon TSU or event ack time out

[Testing]
verify the mpi3mr driver is loaded
verify the version string shows 8.5.1.0.0

[Regression Risk]
Low. These patches are contained to the mpi3mr driver code itself and are all already accepted upstream. They cleanly pick into our 6.5 kernel tree.

Broadcom has tested these and the only concern is the kernel warning below in Comment #7

Sumit Saxena (ssaxena)
summary: - mpi3mr driver update request
+ [Ubuntu 22.04.04]: mpi3mr driver update request
Sumit Saxena (ssaxena)
description: updated
Jeff Lane  (bladernr)
Changed in linux (Ubuntu Noble):
assignee: nobody → Jeff Lane  (bladernr)
Changed in linux (Ubuntu Mantic):
assignee: nobody → Jeff Lane  (bladernr)
Changed in linux (Ubuntu Noble):
status: New → Confirmed
Changed in linux (Ubuntu Mantic):
status: New → Confirmed
Changed in linux (Ubuntu Jammy):
status: New → Opinion
importance: Undecided → Wishlist
Changed in linux (Ubuntu Mantic):
importance: Undecided → Medium
Changed in linux (Ubuntu Noble):
importance: Undecided → Medium
Revision history for this message
Jeff Lane  (bladernr) wrote (last edit ): Re: [Ubuntu 22.04.04]: mpi3mr driver update request

I ran a quick check. Everything up to these exists already in our 6.5 kernel.

9134211f7bed missing in Ubuntu, possibly upstream at v6.6-rc1~11^2~45^2~5
6f81b1cfdf33 missing in Ubuntu, possibly upstream at v6.6-rc1~11^2~45^2~4
d9adb81e67e9 missing in Ubuntu, possibly upstream at v6.6-rc1~11^2~45^2~3
e7a8648e1ce2 missing in Ubuntu, possibly upstream at v6.6-rc1~11^2~45^2~2
d9a5ab0ea98f missing in Ubuntu, possibly upstream at v6.6-rc1~11^2~45^2~1
9a9068b2afa0 missing in Ubuntu, possibly upstream at v6.6-rc1~11^2~45^2
82b2fb52d6ec does not appear in Ubuntu. Best guess on first appearance upstream: v6.7-rc1
6fa21eab82be does not appear in either ubuntu or the upstream kernel.
c9260ff28ee5 does not appear in either ubuntu or the upstream kernel.
cb5b60894602 does not appear in either ubuntu or the upstream kernel.
1193a89d2b6d does not appear in either ubuntu or the upstream kernel.
b4d94164ff32 does not appear in either ubuntu or the upstream kernel.

Those last five are not in any tree I checked (mainline, linux-next).
Edit: I found them 6.8/scsi-staging queued for 6.8.

I'd rather not pull any of these until they've landed at least in linux-next.

Also I'm only going to pull them as far back as 6.5 once they are all in at least linux-next. I'll revisit this in a week or so and see where we are.

Revision history for this message
Chandrakanth Patil (cpatubuntu) wrote :

Thank you, Jeff. We have a few more critical bug fixes patches and one feature update. And below are the commit IDs:

d0a60e3edaa4 scsi: mpi3mr: Update driver version to 8.5.1.0.0
9536af615dc9 scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-3
fb231d7deffb scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-2
c432e1675239 scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-1
07ac6adda4d3 scsi: mpi3mr: Fetch correct device dev handle for status reply descriptor
f8fb3f39148e scsi: mpi3mr: Block PEL Enable Command on Controller Reset and Unrecoverable State
c01d515687e3 scsi: mpi3mr: Clean up block devices post controller reset
e5aab848dfdf scsi: mpi3mr: Refresh sdev queue depth after controller reset

Revision history for this message
Jeff Lane  (bladernr) wrote :

The cutoff is January 3 for patch submission. And We are closed for the holidays after this friday. I do not nkow that these are going to make 22.04.4 initially.

Revision history for this message
Chandrakanth Patil (cpatubuntu) wrote :

Hi Jeff,

Please include the below critical defects if enhancement is not possible:

07ac6adda4d3 scsi: mpi3mr: Fetch correct device dev handle for status reply descriptor
f8fb3f39148e scsi: mpi3mr: Block PEL Enable Command on Controller Reset and Unrecoverable State
c01d515687e3 scsi: mpi3mr: Clean up block devices post controller reset
e5aab848dfdf scsi: mpi3mr: Refresh sdev queue depth after controller reset

Revision history for this message
Jeff Lane  (bladernr) wrote :

Hi Chandrakanth,

Can you install and test this test kernel onto a 22.04.3 deployment?

THere's a tarball you can find here:

https://people.canonical.com/~kamal/for-jeffl/

that has all the test packages for you. YOu probably don't need all of them, at a minimum:

linux-image-unsigned
linux-modules
linux-modules-extra

Possibly linux-headers too.

Please let me know ASAP, that shoudl include all the requested commits.

Revision history for this message
Chandrakanth Patil (cpatubuntu) wrote :

Hi Jeff,

I will install it quickly and cover the required dev testing. I will update the test here ASAP.

Revision history for this message
Chandrakanth Patil (cpatubuntu) wrote :
Download full text (4.4 KiB)

Hi Jeff,

I have covered the required testing and found no critical issues except the below minor issues.

[Wed Dec 13 22:05:56 2023] memcpy: detected field-spanning write (size 128) of single field "bsg_reply_buf->reply_buf" at drivers/scsi/mpi3mr/mpi3mr_app.c:1658 (size 1)
[Wed Dec 13 22:05:56 2023] WARNING: CPU: 4 PID: 3587 at drivers/scsi/mpi3mr/mpi3mr_app.c:1658 mpi3mr_bsg_process_mpt_cmds+0x1302/0x14c0 [mpi3mr]
[Wed Dec 13 22:05:56 2023] Modules linked in: mpi3mr tls intel_rapl_msr intel_rapl_common kvm_amd ccp kvm binfmt_misc irqbypass crct10dif_pclmul polyval_clmulni polyval_generic ghash_clmulni_intel aesni_intel crypto_simd cryptd nls_iso8859_1 input_leds serio_raw joydev bochs drm_vram_helper drm_ttm_helper ttm mac_hid drm_kms_helper qemu_fw_cfg sch_fq_codel msr parport_pc ppdev lp parport drm efi_pstore ip_tables x_tables autofs4 ses enclosure hid_generic usbhid hid crc32_pclmul i2c_i801 ahci psmouse i2c_smbus libahci lpc_ich scsi_transport_sas virtio_rng xhci_pci xhci_pci_renesas [last unloaded: mpi3mr]
[Wed Dec 13 22:05:56 2023] CPU: 4 PID: 3587 Comm: kworker/4:2H Tainted: G W OE 6.5.0-14-generic #14
[Wed Dec 13 22:05:56 2023] Hardware name: Red Hat KVM/RHEL, BIOS 1.16.1-1.el9 04/01/2014
[Wed Dec 13 22:05:56 2023] Workqueue: kblockd blk_mq_run_work_fn
[Wed Dec 13 22:05:56 2023] RIP: 0010:mpi3mr_bsg_process_mpt_cmds+0x1302/0x14c0 [mpi3mr]
[Wed Dec 13 22:05:56 2023] Code: b9 01 00 00 00 48 89 c6 4c 89 55 90 48 c7 c2 58 2f 2a c0 48 c7 c7 a8 2f 2a c0 48 89 45 98 c6 05 4e a8 00 00 01 e8 8e d1 a6 c6 <0f> 0b 4c 8b 55 90 48 8b 45 98 e9 3b ff ff ff 31 db e9 a4 fd ff ff
[Wed Dec 13 22:05:56 2023] RSP: 0018:ffffacd300243c38 EFLAGS: 00010246
[Wed Dec 13 22:05:56 2023] RAX: 0000000000000000 RBX: ffff9190d4fe7540 RCX: 0000000000000000
[Wed Dec 13 22:05:56 2023] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
[Wed Dec 13 22:05:56 2023] RBP: ffffacd300243cf8 R08: 0000000000000000 R09: 0000000000000000
[Wed Dec 13 22:05:56 2023] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9191c6ba9100
[Wed Dec 13 22:05:56 2023] R13: ffff9191c3fb8830 R14: ffff9190d4fe7000 R15: 0000000000000000
[Wed Dec 13 22:05:56 2023] FS: 0000000000000000(0000) GS:ffff91923bd00000(0000) knlGS:0000000000000000
[Wed Dec 13 22:05:56 2023] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[Wed Dec 13 22:05:56 2023] CR2: 000000000213ecf8 CR3: 000000000a04a000 CR4: 0000000000350ee0
[Wed Dec 13 22:05:56 2023] Call Trace:
[Wed Dec 13 22:05:56 2023] <TASK>
[Wed Dec 13 22:05:56 2023] ? show_regs+0x6d/0x80
[Wed Dec 13 22:05:56 2023] ? __warn+0x89/0x160
[Wed Dec 13 22:05:56 2023] ? mpi3mr_bsg_process_mpt_cmds+0x1302/0x14c0 [mpi3mr]
[Wed Dec 13 22:05:56 2023] ? report_bug+0x17e/0x1b0
[Wed Dec 13 22:05:56 2023] ? handle_bug+0x51/0xa0
[Wed Dec 13 22:05:56 2023] ? exc_invalid_op+0x18/0x80
[Wed Dec 13 22:05:56 2023] ? asm_exc_invalid_op+0x1b/0x20
[Wed Dec 13 22:05:56 2023] ? mpi3mr_bsg_process_mpt_cmds+0x1302/0x14c0 [mpi3mr]
[Wed Dec 13 22:05:56 2023] ? mpi3mr_bsg_process_mpt_cmds+0x1302/0x14c0 [mpi3mr]
[Wed Dec 13 22:05:56 2023] mpi3mr_bsg_request+0x23/0x70 [mpi3mr]
[Wed Dec 13 22:05:56 2023] bsg_queue_rq+0xac/0x100
[Wed Dec 13 22:05:56 2023...

Read more...

Revision history for this message
Chandrakanth Patil (cpatubuntu) wrote :

This warning will not appear in the 22.04.2 kernel. Maybe UBSAN enabled in this kernel leads to this warning.

Note: This is just a warning and there is no functional impact.

Revision history for this message
Jeff Lane  (bladernr) wrote : Re: [Bug 2045233] Re: [Ubuntu 22.04.04]: mpi3mr driver update request
Download full text (9.1 KiB)

Does that warning appear on bare metal running ubuntu, or on a ubuntu vm on
an ubuntu host? This appears to be on an ubuntu VM running on a RHEL host?

Hardware name: Red Hat KVM/RHEL, BIOS 1.16.1-1.el9 04/01/2014

On Wed, Dec 13, 2023 at 1:25 PM Chandrakanth Patil <
<email address hidden>> wrote:

> This warning will not appear in the 22.04.2 kernel. Maybe UBSAN enabled
> in this kernel leads to this warning.
>
> Note: This is just a warning and there is no functional impact.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/2045233
>
> Title:
> [Ubuntu 22.04.04]: mpi3mr driver update request
>
> Status in linux package in Ubuntu:
> Confirmed
> Status in linux source package in Jammy:
> Opinion
> Status in linux source package in Mantic:
> Confirmed
> Status in linux source package in Noble:
> Confirmed
>
> Bug description:
> This BZ has been initiated to incorporate the mpi3mr driver from
> upstream into the upcoming Ubuntu
> releases (Ubuntu 22.04.x point releases). Below are the commit IDs for
> the latest upstream version (v6.8).
>
> The 22.04 LTS point kernel already includes the latest mpi3mr driver
> version 8.0.0.69.0. Therefore, the listed commit IDs below correspond
> to the subsequent patches.
>
> The commit IDs listed below are in sequential order from bottom to top,
> indicating the order
> for applying the patches.
>
> b4d94164ff32 scsi: mpi3mr: driver version upgrade to 8.5.0.0.50
> 1193a89d2b6d scsi: mpi3mr: Add support for status reply descriptor
> cb5b60894602 scsi: mpi3mr: Increase maximum number of PHYs to 64 from 32
> c9260ff28ee5 scsi: mpi3mr: Add PCI checks where SAS5116 diverges from
> SAS4116
> 6fa21eab82be scsi: mpi3mr: Add support for SAS5116 PCI IDs
> 82b2fb52d6ec scsi: mpi3mr: Split off bus_reset function from host_reset
> 9a9068b2afa0 scsi: mpi3mr: Update driver version to 8.5.0.0.0
> d9a5ab0ea98f scsi: mpi3mr: Enhance handling of devices removed after
> controller reset
> e7a8648e1ce2 scsi: mpi3mr: WRITE SAME implementation
> d9adb81e67e9 scsi: mpi3mr: Add support for more than 1MB I/O
> 6f81b1cfdf33 scsi: mpi3mr: Update MPI Headers to version 3.00.28
> 9134211f7bed scsi: mpi3mr: Invoke soft reset upon TSU or event ack time
> out
> f762326b2baa scsi: mpi3mr: Propagate sense data for admin queue SCSI I/O
> 144679dfb584 scsi: mpi3mr: Fix the type used for pointers to bitmap
> 2a954832015d scsi: mpi3mr: Use -ENOMEM instead of -1 in
> mpi3mr_expander_add()
> 2acc635a0e5e scsi: mpi3mr: Use IRQ save variants of spinlock to protect
> chain frame allocation
> a3d27dfdcfc2 scsi: mpi3mr: Handle soft reset in progress fault code
> (0xF002)
> b85f82f3c92a scsi: mpi3mr: Declare SCSI host template const
> 1ea41edd88f2 scsi: mpi3mr: Update driver version to 8.4.1.0.0
> e74f2fbd8b06 scsi: mpi3mr: Update copyright year
> 80b8fd0231d5 scsi: mpi3mr: Fix W=1 compilation warnings
> e5f596bc2592 scsi: mpi3mr: Update MPI Headers to revision 27
> f1dec6b1e25e scsi: mpi3mr: Avoid escalating to higher level reset when
> target is removed
> 22beef38e52c scsi: mpi3mr: Modify MUR timeout...

Read more...

Revision history for this message
Chandrakanth Patil (cpatubuntu) wrote : Re: [Ubuntu 22.04.04]: mpi3mr driver update request

Yes, it's an Ubuntu VM running on a RHEL host. It shouldn't make a difference, right?
The same issue could occur on bare metal as well.

Jeff Lane  (bladernr)
summary: - [Ubuntu 22.04.04]: mpi3mr driver update request
+ [SRU][22.04.04]: mpi3mr driver update
Revision history for this message
Jeff Lane  (bladernr) wrote :
Download full text (5.4 KiB)

These patches are all in Ubuntu from 5.19 to 6.5. I've moved them to this comment and out of the original summary to tidy that up. These are in log order.

f762326b2baa scsi: mpi3mr: Propagate sense data for admin queue SCSI I/O
144679dfb584 scsi: mpi3mr: Fix the type used for pointers to bitmap
2a954832015d scsi: mpi3mr: Use -ENOMEM instead of -1 in mpi3mr_expander_add()
2acc635a0e5e scsi: mpi3mr: Use IRQ save variants of spinlock to protect chain frame allocation
a3d27dfdcfc2 scsi: mpi3mr: Handle soft reset in progress fault code (0xF002)
b85f82f3c92a scsi: mpi3mr: Declare SCSI host template const
1ea41edd88f2 scsi: mpi3mr: Update driver version to 8.4.1.0.0
e74f2fbd8b06 scsi: mpi3mr: Update copyright year
80b8fd0231d5 scsi: mpi3mr: Fix W=1 compilation warnings
e5f596bc2592 scsi: mpi3mr: Update MPI Headers to revision 27
f1dec6b1e25e scsi: mpi3mr: Avoid escalating to higher level reset when target is removed
22beef38e52c scsi: mpi3mr: Modify MUR timeout value to 120 seconds
23b3d1cf1572 scsi: mpi3mr: Fix admin queue memory leak upon soft reset
3f1254ed01d0 scsi: mpi3mr: Successive VD delete and add causes FW fault
ce756daa36e1 scsi: mpi3mr: Fix expander node leak in mpi3mr_remove()
c798304470ca scsi: mpi3mr: Fix memory leaks in mpi3mr_init_ioc()
d4caa1a4255c scsi: mpi3mr: Fix sas_hba.phy memory leak in mpi3mr_remove()
d0f3c3728da8 scsi: mpi3mr: Fix mpi3mr_hba_port memory leak in mpi3mr_remove()
7d2b02172b6a scsi: mpi3mr: Fix config page DMA memory leak
f305a7b6ca21 scsi: mpi3mr: Fix throttle_groups memory leak
8e45183978d6 scsi: mpi3mr: Bad drive in topology results kernel crash
4f297e856a7b scsi: mpi3mr: NVMe command size greater than 8K fails
ba8a9ba41fbd scsi: mpi3mr: Return proper values for failures in firmware init path
0a319f162949 scsi: mpi3mr: Wait for diagnostic save during controller init
5b06a7169c59 scsi: mpi3mr: Driver unload crashes host when enhanced logging is enabled
02ca7da2919a scsi: mpi3mr: ioctl timeout when disabling/enabling interrupt
66b381d874fa scsi: mpi3mr: Remove unneeded version.h include
e39ea831ebad scsi: mpi3mr: Fix missing mrioc->evtack_cmds initialization
339e61565f81 scsi: mpi3mr: Use number of bits to manage bitmap sizes
eeb270aee3e0 scsi: mpi3mr: Remove unnecessary memcpy() to alltgt_info->dmi
fb428a2005fc scsi: mpi3mr: Fix issues in mpi3mr_get_all_tgt_info()
ae7d45f5283d scsi: mpi3mr: Fix an issue found by KASAN
f0a43ba6c66c scsi: mpi3mr: Refer CONFIG_SCSI_MPI3MR in Makefile
d347a951906b scsi: mpi3mr: Remove usage of dma_get_required_mask() API
7d21fcfb4095 scsi: mpi3mr: Suppress command reply debug prints
65244389b1b3 scsi: mpi3mr: Select CONFIG_SCSI_SAS_ATTRS
c863a2dcb9b0 scsi: mpi3mr: Remove unnecessary cast
f616efbee9d6 scsi: mpi3mr: Update driver version to 8.2.0.3.0
2e31be8697b1 scsi: mpi3mr: Fix scheduling while atomic type bug
f84e8b5bb57e scsi: mpi3mr: Scan the devices during resume time
130fc180a481 scsi: mpi3mr: Free enclosure objects during driver unload
bad2f28da625 scsi: mpi3mr: Handle 0xF003 Fault Code
f2a79d2030ad scsi: mpi3mr: Graceful handling of surprise removal of PCIe HBA
7f9f953d537a scsi: mpi3mr: Schedule IRQ kthreads only on non-RT kernels
47cd930ee6ae scsi: mpi3mr: Support ne...

Read more...

Jeff Lane  (bladernr)
description: updated
Jeff Lane  (bladernr)
description: updated
Revision history for this message
Chandrakanth Patil (cpatubuntu) wrote :

I didn't get you. These below patches will also be included right?
d0a60e3edaa4 scsi: mpi3mr: Update driver version to 8.5.1.0.0
9536af615dc9 scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-3
fb231d7deffb scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-2
c432e1675239 scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-1
07ac6adda4d3 scsi: mpi3mr: Fetch correct device dev handle for status reply descriptor
f8fb3f39148e scsi: mpi3mr: Block PEL Enable Command on Controller Reset and Unrecoverable State
c01d515687e3 scsi: mpi3mr: Clean up block devices post controller reset
e5aab848dfdf scsi: mpi3mr: Refresh sdev queue depth after controller reset

Revision history for this message
Jeff Lane  (bladernr) wrote : Re: [Bug 2045233] Re: [SRU][22.04.04]: mpi3mr driver update
Download full text (5.3 KiB)

I have picked those into my branch since they were all in linux-next at
this point for 6.8

On Thu, Dec 14, 2023 at 2:30 AM Chandrakanth Patil <
<email address hidden>> wrote:

> I didn't get you. These below patches will also be included right?
> d0a60e3edaa4 scsi: mpi3mr: Update driver version to 8.5.1.0.0
> 9536af615dc9 scsi: mpi3mr: Support for preallocation of SGL BSG data
> buffers part-3
> fb231d7deffb scsi: mpi3mr: Support for preallocation of SGL BSG data
> buffers part-2
> c432e1675239 scsi: mpi3mr: Support for preallocation of SGL BSG data
> buffers part-1
> 07ac6adda4d3 scsi: mpi3mr: Fetch correct device dev handle for status
> reply descriptor
> f8fb3f39148e scsi: mpi3mr: Block PEL Enable Command on Controller Reset
> and Unrecoverable State
> c01d515687e3 scsi: mpi3mr: Clean up block devices post controller reset
> e5aab848dfdf scsi: mpi3mr: Refresh sdev queue depth after controller reset
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/2045233
>
> Title:
> [SRU][22.04.04]: mpi3mr driver update
>
> Status in linux package in Ubuntu:
> Confirmed
> Status in linux source package in Jammy:
> Opinion
> Status in linux source package in Mantic:
> Confirmed
> Status in linux source package in Noble:
> Confirmed
>
> Bug description:
> [Impact]
>
> This update has been initiated to incorporate the mpi3mr driver from
> upstream into the upcoming Ubuntu releases (Ubuntu 22.04.x point
> releases).
>
> This has been requested by both Broadcom as the upstream and by one of
> the larger OEM partners who are going to be selling systems with these
> storage controllers to customers. This series of patches includes bug
> fixes and support for current Broadcom controllers.
>
> [Fixes]
> Below are the commit IDs for the latest upstream version (v6.8).
>
> The 22.04 LTS point kernel already includes the latest mpi3mr driver
> version 8.0.0.69.0. Therefore, the listed commit IDs below correspond
> to the subsequent patches.
>
> The commit IDs listed below are in sequential order from bottom to
> top, indicating the order for applying the patches.
>
> linux-next
> d0a60e3edaa4 scsi: mpi3mr: Update driver version to 8.5.1.0.0
> 9536af615dc9 scsi: mpi3mr: Support for preallocation of SGL BSG data
> buffers part-3
> fb231d7deffb scsi: mpi3mr: Support for preallocation of SGL BSG data
> buffers part-2
> c432e1675239 scsi: mpi3mr: Support for preallocation of SGL BSG data
> buffers part-1
> 07ac6adda4d3 scsi: mpi3mr: Fetch correct device dev handle for status
> reply descriptor
> f8fb3f39148e scsi: mpi3mr: Block PEL Enable Command on Controller Reset
> and Unrecoverable State
> c01d515687e3 scsi: mpi3mr: Clean up block devices post controller reset
> e5aab848dfdf scsi: mpi3mr: Refresh sdev queue depth after controller
> reset
> b4d94164ff32 scsi: mpi3mr: driver version upgrade to 8.5.0.0.50
> 1193a89d2b6d scsi: mpi3mr: Add support for status reply descriptor
> cb5b60894602 scsi: mpi3mr: Increase maximum number of PHYs to 64 from 32
> c9260ff28ee5 scsi: mpi3mr: Add PCI checks where SAS5116 diverges from
> SAS41...

Read more...

Revision history for this message
Chandrakanth Patil (cpatubuntu) wrote :

ok, Jeff. Regarding warning:

1. Since there is no functional impact, we can ignore it as of now.
2. We will submit the warning fix to upstream ASAP.

Do you have any suggestions on this?

Revision history for this message
Jeff Lane  (bladernr) wrote :
Download full text (4.8 KiB)

If you get a patch to fix the warning upstream we can pull it later once
it's accepted.

On Thu, Dec 14, 2023 at 3:25 AM Chandrakanth Patil <
<email address hidden>> wrote:

> ok, Jeff. Regarding warning:
>
> 1. Since there is no functional impact, we can ignore it as of now.
> 2. We will submit the warning fix to upstream ASAP.
>
>
> Do you have any suggestions on this?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/2045233
>
> Title:
> [SRU][22.04.04]: mpi3mr driver update
>
> Status in linux package in Ubuntu:
> Confirmed
> Status in linux source package in Jammy:
> Opinion
> Status in linux source package in Mantic:
> Confirmed
> Status in linux source package in Noble:
> Confirmed
>
> Bug description:
> [Impact]
>
> This update has been initiated to incorporate the mpi3mr driver from
> upstream into the upcoming Ubuntu releases (Ubuntu 22.04.x point
> releases).
>
> This has been requested by both Broadcom as the upstream and by one of
> the larger OEM partners who are going to be selling systems with these
> storage controllers to customers. This series of patches includes bug
> fixes and support for current Broadcom controllers.
>
> [Fixes]
> Below are the commit IDs for the latest upstream version (v6.8).
>
> The 22.04 LTS point kernel already includes the latest mpi3mr driver
> version 8.0.0.69.0. Therefore, the listed commit IDs below correspond
> to the subsequent patches.
>
> The commit IDs listed below are in sequential order from bottom to
> top, indicating the order for applying the patches.
>
> linux-next
> d0a60e3edaa4 scsi: mpi3mr: Update driver version to 8.5.1.0.0
> 9536af615dc9 scsi: mpi3mr: Support for preallocation of SGL BSG data
> buffers part-3
> fb231d7deffb scsi: mpi3mr: Support for preallocation of SGL BSG data
> buffers part-2
> c432e1675239 scsi: mpi3mr: Support for preallocation of SGL BSG data
> buffers part-1
> 07ac6adda4d3 scsi: mpi3mr: Fetch correct device dev handle for status
> reply descriptor
> f8fb3f39148e scsi: mpi3mr: Block PEL Enable Command on Controller Reset
> and Unrecoverable State
> c01d515687e3 scsi: mpi3mr: Clean up block devices post controller reset
> e5aab848dfdf scsi: mpi3mr: Refresh sdev queue depth after controller
> reset
> b4d94164ff32 scsi: mpi3mr: driver version upgrade to 8.5.0.0.50
> 1193a89d2b6d scsi: mpi3mr: Add support for status reply descriptor
> cb5b60894602 scsi: mpi3mr: Increase maximum number of PHYs to 64 from 32
> c9260ff28ee5 scsi: mpi3mr: Add PCI checks where SAS5116 diverges from
> SAS4116
> 6fa21eab82be scsi: mpi3mr: Add support for SAS5116 PCI IDs
>
> Mainline at 6.6/6.7
> 82b2fb52d6ec scsi: mpi3mr: Split off bus_reset function from host_reset
> 9a9068b2afa0 scsi: mpi3mr: Update driver version to 8.5.0.0.0
> d9a5ab0ea98f scsi: mpi3mr: Enhance handling of devices removed after
> controller reset
> e7a8648e1ce2 scsi: mpi3mr: WRITE SAME implementation
> d9adb81e67e9 scsi: mpi3mr: Add support for more than 1MB I/O
> 6f81b1cfdf33 scsi: mpi3mr: Update MPI Headers to version 3.00.28
> 9134211f7bed scsi: mp...

Read more...

Revision history for this message
Chandrakanth Patil (cpatubuntu) wrote :

OK. I will submit the patch to upstream ASAP.

Tim Gardner (timg-tpi)
Changed in linux (Ubuntu Mantic):
status: Confirmed → In Progress
Changed in linux (Ubuntu Mantic):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-hwe-6.5/6.5.0-18.18~22.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-hwe-6.5' to 'verification-done-jammy-linux-hwe-6.5'. If the problem still exists, change the tag 'verification-needed-jammy-linux-hwe-6.5' to 'verification-failed-jammy-linux-hwe-6.5'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-hwe-6.5-v2 verification-needed-jammy-linux-hwe-6.5
Revision history for this message
Chandrakanth Patil (cpatubuntu) wrote :

Hi Roxana,

Do We get the kernel source tree link where we can check our included patches for confirmation?

Revision history for this message
Roxana Nicolescu (roxanan) wrote :

Hi everyone! Could you verify the kernel in proposed, see above message? So that we can release this kernel to -updates?

Revision history for this message
Roxana Nicolescu (roxanan) wrote :

Kernel source tree is here, but note that if it's there, it does not say when it's gonna be released.
https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/jammy/log/?h=hwe-6.5-next

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux/6.5.0-25.25 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-mantic-linux' to 'verification-done-mantic-linux'. If the problem still exists, change the tag 'verification-needed-mantic-linux' to 'verification-failed-mantic-linux'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-mantic-linux-v2 verification-needed-mantic-linux
Revision history for this message
Chandrakanth Patil (cpatubuntu) wrote :

Hi All,

We have covered the driver validation on the provided kernel and haven't found any issues. Thank you.

Jeff Lane  (bladernr)
tags: added: verification-done-jammy-linux-hwe-6.5 verification-done-mantic-linux
removed: verification-needed-jammy-linux-hwe-6.5 verification-needed-mantic-linux
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (121.8 KiB)

This bug was fixed in the package linux - 6.5.0-25.25

---------------
linux (6.5.0-25.25) mantic; urgency=medium

  * mantic/linux: 6.5.0-25.25 -proposed tracker (LP: #2052615)

  * Packaging resync (LP: #1786013)
    - debian/dkms-versions -- update from kernel-versions (main/2024.02.05)

  * [SRU][22.04.04]: mpi3mr driver update (LP: #2045233)
    - scsi: mpi3mr: Invoke soft reset upon TSU or event ack time out
    - scsi: mpi3mr: Update MPI Headers to version 3.00.28
    - scsi: mpi3mr: Add support for more than 1MB I/O
    - scsi: mpi3mr: WRITE SAME implementation
    - scsi: mpi3mr: Enhance handling of devices removed after controller reset
    - scsi: mpi3mr: Update driver version to 8.5.0.0.0
    - scsi: mpi3mr: Split off bus_reset function from host_reset
    - scsi: mpi3mr: Add support for SAS5116 PCI IDs
    - scsi: mpi3mr: Add PCI checks where SAS5116 diverges from SAS4116
    - scsi: mpi3mr: Increase maximum number of PHYs to 64 from 32
    - scsi: mpi3mr: Add support for status reply descriptor
    - scsi: mpi3mr: driver version upgrade to 8.5.0.0.50
    - scsi: mpi3mr: Refresh sdev queue depth after controller reset
    - scsi: mpi3mr: Clean up block devices post controller reset
    - scsi: mpi3mr: Block PEL Enable Command on Controller Reset and Unrecoverable
      State
    - scsi: mpi3mr: Fetch correct device dev handle for status reply descriptor
    - scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-1
    - scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-2
    - scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-3
    - scsi: mpi3mr: Update driver version to 8.5.1.0.0

  * The display becomes frozen after some time when a HDMI device is connected.
    (LP: #2049027)
    - drm/i915/dmc: Don't enable any pipe DMC events

  * Audio balancing setting doesn't work with the cirrus codec (LP: #2051050)
    - ALSA: hda/cs8409: Suppress vmaster control for Dolphin models

  * partproke is broken on empty loopback device (LP: #2049689)
    - block: Move checking GENHD_FL_NO_PART to bdev_add_partition()

  * CVE-2023-51780
    - atm: Fix Use-After-Free in do_vcc_ioctl

  * CVE-2023-6915
    - ida: Fix crash in ida_free when the bitmap is empty

  * Update Ubuntu.md (LP: #2051176)
    - [Packaging] update Ubuntu.md

  * test_021_aslr_dapper_libs from ubuntu_qrt_kernel_security failed on K-5.19 /
    J-OEM-6.1 / J-6.2 AMD64 (LP: #1983357)
    - [Config]: set ARCH_MMAP_RND_{COMPAT_, }BITS to the maximum

  * Intel E810-XXV - NETDEV WATCHDOG: (ice): transmit queue timed out
    (LP: #2036239)
    - ice: Add driver support for firmware changes for LAG
    - ice: alter feature support check for SRIOV and LAG

  * Mantic update: upstream stable patchset 2024-01-29 (LP: #2051584)
    - Upstream stable to v6.1.67, v6.6.6
    - vdpa/mlx5: preserve CVQ vringh index
    - hrtimers: Push pending hrtimers away from outgoing CPU earlier
    - i2c: designware: Fix corrupted memory seen in the ISR
    - netfilter: ipset: fix race condition between swap/destroy and kernel side
      add/del/test
    - zstd: Fix array-index-out-of-bounds UBSAN warning
    - tg3: Move the [rt]x_dropped counters...

Changed in linux (Ubuntu Mantic):
status: Fix Committed → Fix Released
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-aws/6.5.0-1015.15 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-mantic-linux-aws' to 'verification-done-mantic-linux-aws'. If the problem still exists, change the tag 'verification-needed-mantic-linux-aws' to 'verification-failed-mantic-linux-aws'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-mantic-linux-aws-v2 verification-needed-mantic-linux-aws
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-azure/6.5.0-1016.16 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-mantic-linux-azure' to 'verification-done-mantic-linux-azure'. If the problem still exists, change the tag 'verification-needed-mantic-linux-azure' to 'verification-failed-mantic-linux-azure'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-mantic-linux-azure-v2 verification-needed-mantic-linux-azure
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-nvidia-6.5/6.5.0-1014.14 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-nvidia-6.5' to 'verification-done-jammy-linux-nvidia-6.5'. If the problem still exists, change the tag 'verification-needed-jammy-linux-nvidia-6.5' to 'verification-failed-jammy-linux-nvidia-6.5'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-nvidia-6.5-v2 verification-needed-jammy-linux-nvidia-6.5
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.