Marking org unit as non-visible in the OPAC defaults patrons' preferred pickup locations to the first org unit

[Susan Morrison]

3.10

Opening this up for discussion. If an org unit is marked as non-visible in the OPAC, the default pickup library for patrons who have that org unit selected for their default pickup library automatically defaults to the first library in the org unit tree in the patron’s OPAC account. This causes patrons who don’t notice the change to place holds with the wrong pickup location. It makes sense that the org unit marked non-visible does not show in the pickup location dropdown, but wondering if there’s a way the pickup location could default to something else, like the consortium or system level, which can’t be chosen as pickup locations. Since those levels are not pickup locations, the fix in https://bugs.launchpad.net/evergreen/+bug/1477154 may work. Or there may be a better way to block and/or alert the patron when placing the hold through the OPAC.

To test:
1. Make an org unit not visible (and run autogen).
2. Log in to the OPAC with a patron’s account that has that org unit as their default pickup location.
3. Place a hold and note the pickup location has defaulted to the first org unit in the tree. This can also be confirmed through My Account > Preferences > Search & History > Preferred pickup location.

[Terran McCanna (tmccanna)]

I *think* this could be solved by adding another IF block to the fix for https://bugs.launchpad.net/evergreen/+bug/1477154 that checks to see if the patron's default pickup library is in the retrieved list of org units or not, and giving the alert if it's not.

[Steven Mayo (stmayo)]

Added a check for this on the OPAC holds screen. If the patron's preferred pickup library is not in the dropdown, it adds a new option to the dropdown that asks them to choose a pickup library. It also disables the submit button until they do.

Branch at: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/smayo/lp2043127-Nonvisible_Preferred_Pickup_Location_Starts_OPAC_Hold_Screen_On_Different_Org

[Susan Morrison (smorrison425)]

Tested on 3.12 server and everything worked as expected. If a patron's default pickup library was non-visible in the OPAC, the pickup location dropdown defaulted to "Choose a pickup location" and did not allow a hold until a location was chosen. Confirmed this was also the behavior when a patron didn't have a default pickup library set and their home library was non-visible in the OPAC.

[Terran McCanna (tmccanna)]

Note for testing - I had to restart apache on my test server in order for the OPAC to pick up the branch visibility change in the dropdown list.

[Michele Morgan (mmorgan)]

This is a good addition to the fix for bug 1477154. It looks great to me.

Pushed all the way back to rel_3_10 as was 1477154.

Thanks Steven, Susan, Terran and Pines!