pwr-mlxbf: Several bug fixes for focal

Bug #2041996 reported by Asmaa Mnebhi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-bluefield (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned

Bug Description

SRU Justification:

[Impact]

There is are several changes that needs to be made to pwr-mlxbf in focal:
* There is a race condition between gpio-mlxbf2.c driver being loaded and pwr-mlxbf.c being loaded
* When the module is removed, there is a panic due to NULL pointer access
* soft reset needs to be replaced by graceful reboot

[Fix]

* Fix race condition between gpio-mlxbf2.c driver being loaded and pwr-mlxbf.c being loaded
* Fix panic due to access to NULL pointer when driver is removed via rmmod
* support graceful reboot instead of soft reset

[Test Case]

* all test cases are for BF2:
* trigger the gpio toggling from the BMC: ipmitool raw 0x32 0xA1 0x02
  This should trigger a graceful reboot of the DPU.
* rmmod/modprobe
* reboot test and make sure the driver is always loaded

[Regression Potential]

* Run the 100 reboot test and make sure that the driver is loaded with no issues. That the gpio graceful reboot works.

Changed in linux-bluefield (Ubuntu):
status: New → Invalid
Changed in linux-bluefield (Ubuntu Focal):
status: New → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-bluefield/5.4.0-1076.82 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal-linux-bluefield' to 'verification-done-focal-linux-bluefield'. If the problem still exists, change the tag 'verification-needed-focal-linux-bluefield' to 'verification-failed-focal-linux-bluefield'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-focal-linux-bluefield-v2 verification-needed-focal-linux-bluefield
tags: added: verification-done-focal-linux-bluefield
removed: verification-needed-focal-linux-bluefield
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (45.2 KiB)

This bug was fixed in the package linux-bluefield - 5.4.0-1076.82

---------------
linux-bluefield (5.4.0-1076.82) focal; urgency=medium

  * focal/linux-bluefield: 5.4.0-1076.82 -proposed tracker (LP: #2041621)

  * pwr-mlxbf: Several bug fixes for focal (LP: #2041996)
    - SAUCE: Fix race condition between loading pwr-mlxbf.c and gpio-mlxbf2.c
      drivers
    - SAUCE: pwr-mlxbf.c: rmmod results in kernel panic due to access to NULL
      pointer
    - SAUCE: pwr-mlxbf: support graceful reboot instead of soft reset

  [ Ubuntu: 5.4.0-169.187 ]

  * focal/linux: 5.4.0-169.187 -proposed tracker (LP: #2044375)
  * USB bus error after upgrading to proposed kernel on lunar, jammy and focal
    (LP: #2043197)
    - USB: core: Fix oversight in SuperSpeed initialization
  * Packaging resync (LP: #1786013)
    - [Packaging] resync git-ubuntu-log
    - [Packaging] resync update-dkms-versions helper
    - [Packaging] update annotations scripts

  [ Ubuntu: 5.4.0-168.186 ]

  * focal/linux: 5.4.0-168.186 -proposed tracker (LP: #2041652)
  * Focal update: v5.4.257 upstream stable release (LP: #2040284)
    - erofs: ensure that the post-EOF tails are all zeroed
    - ARM: pxa: remove use of symbol_get()
    - mmc: au1xmmc: force non-modular build and remove symbol_get usage
    - net: enetc: use EXPORT_SYMBOL_GPL for enetc_phc_index
    - rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc_poweroff
    - modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules
    - USB: serial: option: add Quectel EM05G variant (0x030e)
    - USB: serial: option: add FOXCONN T99W368/T99W373 product
    - HID: wacom: remove the battery when the EKR is off
    - staging: rtl8712: fix race condition
    - Bluetooth: btsdio: fix use after free bug in btsdio_remove due to race
      condition
    - serial: sc16is7xx: fix bug when first setting GPIO direction
    - firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in probe
    - fsi: master-ast-cf: Add MODULE_FIRMWARE macro
    - nilfs2: fix general protection fault in nilfs_lookup_dirty_data_buffers()
    - nilfs2: fix WARNING in mark_buffer_dirty due to discarded buffer reuse
    - pinctrl: amd: Don't show `Invalid config param` errors
    - 9p: virtio: make sure 'offs' is initialized in zc_request
    - ASoC: da7219: Flush pending AAD IRQ when suspending
    - ASoC: da7219: Check for failure reading AAD IRQ events
    - ethernet: atheros: fix return value check in atl1c_tso_csum()
    - vxlan: generalize vxlan_parse_gpe_hdr and remove unused args
    - m68k: Fix invalid .section syntax
    - s390/dasd: use correct number of retries for ERP requests
    - s390/dasd: fix hanging device after request requeue
    - fs/nls: make load_nls() take a const parameter
    - ASoc: codecs: ES8316: Fix DMIC config
    - ASoC: atmel: Fix the 8K sample parameter in I2SC master
    - platform/x86: intel: hid: Always call BTNL ACPI method
    - platform/x86: huawei-wmi: Silence ambient light sensor
    - security: keys: perform capable check only on privileged operations
    - clk: fixed-mmio: make COMMON_CLK_FIXED_MMIO depend on HAS_IOMEM
    - net: usb: qmi_wwan: add Quectel EM05GV2
    - idmaengine: make FSL_EDMA and INTEL_IDMA64 d...

Changed in linux-bluefield (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.