rmlint 2.9.0-2.5 fails to build: test_stdin.test_stdin_read hangs

[Benjamin Drung]

rmlint 2.9.0-2.5 fails to build:

```
test_sorting.test_sort_by_regex ... ok
test_sorting.test_sort_by_regex_bad_input ... ok
test_stdin.test_stdin_read ...
(process:30529): rmlint-CRITICAL (recursed) **: 
E: Build killed with signal TERM after 150 minutes of inactivity
```

I successfully built rmlint 2.9.0-2.5 on unstable and mantic with sbuild locally. Build time was around two minutes.

The failure is reproducible on the Launchpad builders.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Steve Langasek (vorlon)]

Benjamin, do you have any ideas what's going wrong here? Looking at the test case in question, it uses subprocess.Popen() and Popen.communicate() and poring over the subprocess documentation I can't see any wrong assumptions.

[Benjamin Drung (bdrung)]

It looks like the called binary is hanging. Since `Popen.communicate()` is called without `timeout` set, it will wait forever to exit. Upstream has a fix for a hanging case: https://github.com/sahib/rmlint/pull/557

I am currently testing if that will fix the hang in our case.

[Benjamin Drung (bdrung)]

Cherry-picking https://github.com/sahib/rmlint/pull/557 is not enough. I am going to package 2.10.2 instead of bisecting the additional needed commit(s).

[Launchpad Janitor (janitor)]

This bug was fixed in the package rmlint - 2.10.2-0ubuntu1

---------------
rmlint (2.10.2-0ubuntu1) oracular; urgency=medium

  * New upstream release (LP: #2039957)
  * d/rules: exclude jquery-fix.js from dh_sphinxdoc -prmlint-doc call
  * Drop patches applied upstream and refresh remaining patches
  * Build-depend on python3-xattr for new unit tests
  * Replace obsolete pkg-config by pkgconf
  * scons: add missing newline for included headers and check *xattr functions
    with correct arguments (Closes: #1065947, LP: #2066970)

 -- Benjamin Drung <email address hidden> Tue, 28 May 2024 11:20:05 +0200