Exit code of locations mount script is not respecting error

[Marco Trevisan (Treviño)]

[ Impact ]

When mounting an external location a script is used to get the current default app for a type, its return error is parsed by the dock to provide users a feedback, but the returned code is not valid in case of error.

[ Test case ]

Run:
  gjs -m /<email address hidden>/locationsWorker.js handler file:///foo/bar/baz
  echo $?

An error should be shown and the return code should be 1

Doing instead

  gjs -m /<email address hidden>/locationsWorker.js handler file://$HOME
  echo $?

The file manager desktop-id should be printed and the script should return 0.

[ Regression Potential ]

Some locations may not have a default handler and so not being launched

[Utkarsh Gupta (utkarsh)]

Hey, gnome-shell-extension-ubuntu-dock is not something that we (release team) are planning to accept ahead of Mantic release, so we're going to let it be in the unapproved queue and consider this for a 0-day SRU.

[Andreas Hasenack (ahasenack)]

This bug is ready for verification. Due to the status mantic was in when the package was accepted, the tooling failed to add the template comment to this bug, and add the tags, and I did all of that manually now.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 87ubuntu2

---------------
gnome-shell-extension-ubuntu-dock (87ubuntu2) mantic; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * locationsWorker: Exit with the main script exit code (LP: #2038783)

  [ Stuart Hayhurst ]
  * appIcons: Use Mtk.Rectangle instead of Meta.Rectangle (LP: #2034664)

 -- Marco Trevisan (Treviño) <email address hidden> Mon, 09 Oct 2023 03:04:54 +0200

[Jeremy Bícha (jbicha)]

I successfully completed the test case with gnome-shell-extension-ubuntu-dock 87ubuntu2 on Ubuntu 23.10.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 87ubuntu2

---------------
gnome-shell-extension-ubuntu-dock (87ubuntu2) mantic; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * locationsWorker: Exit with the main script exit code (LP: #2038783)

  [ Stuart Hayhurst ]
  * appIcons: Use Mtk.Rectangle instead of Meta.Rectangle (LP: #2034664)

 -- Marco Trevisan (Treviño) <email address hidden> Mon, 09 Oct 2023 03:04:54 +0200

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for gnome-shell-extension-ubuntu-dock has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.