crash reports not sent to the Error Tracker

[Brian Murray]

[ Impact ]

Crash reports aren't sent in when going through the UI, unless the user looks at the crash details.

[ Test Plan ]

0) Make sure that error reporting is set to manual in the system settings (in Privacy screen)
1) Launch xeyes
2) pkill -11 xeyes
3) Click send in the apport dialog. DO NOT look at the details of the report.
4) ls -lh /var/crash/*xeyes*

There should be 3 files:

-rw-r----- 1 bdmurray whoopsie 3370567 Oct 6 11:53 _usr_bin_xeyes.1000.crash
-rw-rw-r-- 1 bdmurray bdmurray 0 Oct 6 11:53 _usr_bin_xeyes.1000.upload
-rw------- 1 whoopsie whoopsie 37 Oct 6 11:53 _usr_bin_xeyes.1000.uploaded

[ Where problems could occur ]

If the patch is wrong, we actually see similar bugs for other UI paths, e.g. ticking the "Remember this" box, etc. I tried to cover them during manual testing but I might have missed some.

[ Other Info ]

If possible I'd like for us not to wait too long for this to mature in -proposed, as this would affect crashes during the upgrade.

[ Original report ]
From what I can tell when I click the send button to send a crash report to the Error Tracker the crash doesn't actually get sent. My testing process follows:

1) Launch xeyes
2) pkill -11 xeyes
3) Click send in the apport dialog
4) ls -lh /var/crash

I would expect there to be three files in /var/crash:

-rw-r----- 1 bdmurray whoopsie 3370567 Oct 6 11:53 _usr_bin_xeyes.1000.crash
-rw-rw-r-- 1 bdmurray bdmurray 0 Oct 6 11:53 _usr_bin_xeyes.1000.upload
-rw------- 1 whoopsie whoopsie 37 Oct 6 11:53 _usr_bin_xeyes.1000.uploaded

However, after step #4 I'm only seeing the .crash file and not a .upload or .uploaded. I was able to get the .upload and .uploaded files created if I chose to "View Report" and then click "Send".

It's worth noting though that I did notice the size of the .crash file increase after clicking "Send" so some post-processing was done.

ProblemType: BugDistroRelease: Ubuntu 23.10
Package: apport 2.27.0-0ubuntu4
ProcVersionSignature: Ubuntu 6.5.0-5.5-generic 6.5.0
Uname: Linux 6.5.0-5-generic x86_64
NonfreeKernelModules: zfs
ApportVersion: 2.27.0-0ubuntu4
Architecture: amd64
CasperMD5CheckResult: pass
CrashReports: 640:1000:123:20944237:2023-10-06 12:10:47.809248208 +0100:2023-10-06 12:11:23.340030509 +0100:/var/crash/_usr_bin_mpv.1000.crash
CurrentDesktop: ubuntu:GNOME
Date: Fri Oct 6 12:12:46 2023
InstallationDate: Installed on 2022-01-07 (637 days ago)
InstallationMedia: Ubuntu 21.10 "Impish Indri" - Release amd64 (20211012)
PackageArchitecture: allSourcePackage: apport
UpgradeStatus: No upgrade log present (probably fresh install)

[Simon Chopin (schopin)]

This was caused by the addition of this feature: https://github.com/canonical/apport/pull/131

It broke an assumption that Dependencies was only added by the late stage info collection, and said collection also had some other side-effects that were relied upon to trigger the upload.

I'll create a hotfix patch for it this afternoon to unlock the situation, and we'll work on a less fragile approach when Benjamin comes back from PTO.

[Simon Chopin (schopin)]

Looking at the code it seems to be affecting Lunar as well. I'm spinning up a VM to confirm it (LXD containers are being difficult for this)

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.27.0-0ubuntu5

---------------
apport (2.27.0-0ubuntu5) mantic; urgency=medium

  * d/p/lp2038650: Fix crash reporting when going through the UI (LP: #2038650)

 -- Simon Chopin <email address hidden> Mon, 09 Oct 2023 15:52:13 +0200

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Simon Chopin (schopin)]

We've agreed with Benjamin that the current fix is probably the way to go for the SRU, while we work on the overall design to make this less fragile (which would probably be way too much invasive for an SRU).

[Brian Murray (brian-murray)]

Hello Brian, or anyone else affected,

Accepted apport into lunar-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.26.1-0ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-lunar to verification-done-lunar. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-lunar. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Simon Chopin (schopin)]

Verified in a fresh Lunar VM.

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for apport has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.26.1-0ubuntu2.1

---------------
apport (2.26.1-0ubuntu2.1) lunar; urgency=medium

  * d/p/lp2038650: Fix crash reporting when going through the UI (LP: #2038650)

 -- Simon Chopin <email address hidden> Mon, 16 Oct 2023 17:09:25 +0200