FTBFS: missing strl* symbols fail the build

[Andreas Hasenack]

[ Impact ]

The package cannot be built in Mantic. If for any reason someone needs to rebuild the package that's not possible.

The proposed fix should be staged in mantic-proposed and be released in the next update.

[ Test Plan ]

The package needs to build successfully in Mantic.

[ Where problems could occur ]

The fix involves marking two symbols as optional because now they are provided by glibc. If there is any issue related to strlcat and strlcpy, it might be related to this update.

[ Original description ]

See ubuntu-devel thread[1] and mantic rebuild report[2].

dpkg-gensymbols: error: some symbols or patterns disappeared in the symbols file: see diff output below
dpkg-gensymbols: warning: debian/libqb100/DEBIAN/symbols doesn't match completely debian/libqb100.symbols
--- debian/libqb100.symbols (libqb100_2.0.8-1_amd64)
+++ dpkg-gensymbolsTJnRGb 2023-09-04 11:09:48.720929506 +0000
@@ -244,6 +244,6 @@
  qb_vsnprintf_deserialize@Base 2.0.1
  qb_vsnprintf_serialize@Base 2.0.1
  remove_tempdir@Base 2.0.1
- strlcat@Base 2.0.1
- strlcpy@Base 2.0.1
+#MISSING: 2.0.8-1# strlcat@Base 2.0.1
+#MISSING: 2.0.8-1# strlcpy@Base 2.0.1
  use_filesystem_sockets@Base 2.0.1
dh_makeshlibs: error: failing due to earlier errors

1. https://lists.ubuntu.com/archives/ubuntu-devel/2023-September/042784.html
2. https://people.canonical.com/~ginggs/ftbfs-report/test-rebuild-20230830-mantic-mantic.html#ubuntu-server-team

[Christian Ehrhardt  (paelzer)]

New flags between
https://launchpadlibrarian.net/678368627/buildlog_ubuntu-mantic-amd64.libqb_2.0.8-1_BUILDING.txt.gz
and
https://launchpadlibrarian.net/685152138/buildlog_ubuntu-mantic-amd64.libqb_2.0.8-1_BUILDING.txt.gz
are: -fstack-clash-protection -fcf-protection

That is part of the Ubuntu hardening.

Most likely the "fix" is just the same as in
http://launchpadlibrarian.net/686836480/gpsd_3.25-2ubuntu1_3.25-2ubuntu2.diff.gz

But we'd want to ask Debian to take the same, for that we need to find which-of/if the flags above are causing this.

Likely strl* functions are not meant to be exported as they are part of libbsd-dev see https://manpages.ubuntu.com/manpages/jammy/man3/strlcpy.3bsd.html and not of e.g. in this case libqb.
So maybe the compiler flags now hides these not meant to be exported symbols that are actually in libbsd0?

Once sufficiently understood consider providing a PR on Salsa to avoid this from ever affecting Debian (and link it from here)

[Paride Legovini (paride)]

I confirmed the FTBFS and that the fix suggested by Christian works.

[Steve Langasek (vorlon)]

Hello Andreas, or anyone else affected,

Accepted libqb into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libqb/2.0.8-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted libqb (2.0.8-1ubuntu0.1) for mantic have finished running.
The following regressions have been reported in tests triggered by the package:

corosync/3.1.7-1ubuntu1 (arm64)
kronosnet/1.26-1 (armhf)
sbd/1.5.1-2ubuntu1 (arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/mantic/update_excuses.html#libqb

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Lucas Kanashiro (lucaskanashiro)]

The package built successfully in mantic-proposed in all supported architectures:

https://launchpad.net/ubuntu/+source/libqb/2.0.8-1ubuntu0.1

[Launchpad Janitor (janitor)]

This bug was fixed in the package libqb - 2.0.8-1ubuntu1

---------------
libqb (2.0.8-1ubuntu1) noble; urgency=medium

  * d/libqb100.symbols: Mark strlcat strlcpy as optional, since they are now
    part of glibc (LP: #2036251).

 -- Lucas Kanashiro <email address hidden> Fri, 24 Nov 2023 16:25:20 -0300