minimize-manual script takes an argument but is not used throughout script

Bug #2036198 reported by Philip Roche
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
livecd-rootfs (Ubuntu)
Fix Released
Undecided
Philip Roche

Bug Description

minimize-manual takes an argument of the path to the chroot but of the 3 commands that are run the argument is only used twice and with the third hardcoding "chroot" as the path to the chroot.

Thankfully "chroot" has been the patch passed in for the current uses of minimize-manual but this could cause issues later if that were to change.

```
chroot=$1

auto_packages=$(/usr/share/livecd-rootfs/auto-markable-pkgs $chroot)
if [ -n "$auto_packages" ]; then
 chroot chroot apt-mark auto $auto_packages
fi
[ -z "$(/usr/share/livecd-rootfs/auto-markable-pkgs $chroot 2> /dev/null)" ]

```

See https://git.launchpad.net/livecd-rootfs/tree/minimize-manual

Revision history for this message
Philip Roche (philroche) wrote :
Changed in livecd-rootfs (Ubuntu):
assignee: nobody → Philip Roche (philroche)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 23.10.37

---------------
livecd-rootfs (23.10.37) mantic; urgency=medium

  * fix: ensure minimize-manual script uses passed in argument for all commands (LP: #2036198)
  * fix: armhf flavour for 6.5+ kernel is now generic (LP: #2036192)

 -- Philip Roche <email address hidden> Fri, 15 Sep 2023 11:58:23 +0100

Changed in livecd-rootfs (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.