systemd FTBFS on ppc64el due to fuzzer failures

[Nick Rosbrook]

[Impact]

systemd FTBFS on ppc64el due to failing fuzz tests.

[Test Plan]

The build-time tests and fuzzing should pass so that the build ultimately passes on ppc64el.

[Where problems could occur]

The patch just removes the "pure" attribute from bus_message_type_from_string, because that attribute was incorrect for the behavior of the function. Hence, the regression potential should be limited to building the package.

[Original Description]

This PPA build[1] demonstrates the issue, the relevant part being:

[ ... ]
1061/1066 systemd:dist-check / check-help-networkctl OK 0.04s
1062/1066 systemd:dist-check / check-version-networkctl OK 0.03s
1063/1066 systemd:dist-check / check-help-kernel-install OK 0.03s
1064/1066 systemd:dist-check / check-version-kernel-install OK 0.02s
1065/1066 systemd:dist-check / check-directives OK 0.18s
1066/1066 systemd:dist-check / parse-hwdb OK 5.43s

Summary of Failures:

 661/1066 systemd:fuzzers / fuzz-bus-match_bugzilla1935084.input FAIL 0.22s killed by signal 11 SIGSEGV
 667/1066 systemd:fuzzers / fuzz-bus-match_test.input FAIL 0.25s killed by signal 11 SIGSEGV

Ok: 1032
Expected Fail: 0
Fail: 2
Unexpected Pass: 0
Skipped: 32
Timeout: 0

Full log written to /<<PKGBUILDDIR>>/obj-powerpc64le-linux-gnu/meson-logs/testlog.txt
make[1]: *** [debian/rules:308: override_dh_auto_test] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:312: binary-arch] Error 2
dpkg-buildpackage: error: debian/rules binary-arch subprocess returned exit status 2

This appears to be related to a toolchain change, because I get the same result when doing a no-change rebuild of systemd on ppc64el in Lunar (i.e. the FTBFS is not introduced by the changes I am testing).

[1] https://launchpadlibrarian.net/682104329/buildlog_ubuntu-lunar-ppc64el.systemd_252.5-2ubuntu4~ppa11_BUILDING.txt.gz

[Nick Rosbrook (enr0n)]

When looking at the upstream git log patches, I came across[1], which fixes the build.

[1] https://github.com/systemd/systemd-stable/commit/bf2f71a0615b3831f170728760171d8bfb13fc5e

[Łukasz Zemczak (sil2100)]

Hello Nick, or anyone else affected,

Accepted systemd into lunar-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/252.5-2ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-lunar to verification-done-lunar. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-lunar. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted systemd (252.5-2ubuntu3.1) for lunar have finished running.
The following regressions have been reported in tests triggered by the package:

apt/2.6.0ubuntu0.1 (armhf)
clutter-1.0/unknown (amd64)
corosync/3.1.7-1ubuntu1 (i386)
cryptsetup/unknown (s390x)
libreswan/unknown (s390x)
libsdl2/unknown (s390x)
linux-lowlatency/6.2.0-1012.12 (arm64)
mutter/44.3-0ubuntu1 (amd64)
netplan.io/0.106-0ubuntu3 (arm64)
samba/2:4.17.7+dfsg-1ubuntu2.2 (arm64)
stunnel4/3:5.68-2 (i386)
stunnel4/unknown (s390x)
systemd-bootchart/234-2 (amd64)
ubuntu-drivers-common/1:0.9.7.1.1 (ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/lunar/update_excuses.html#systemd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Nick Rosbrook (enr0n)]

The ppc64el build of systemd 252.5-2ubuntu3.1 (https://launchpad.net/ubuntu/+source/systemd/252.5-2ubuntu3.1/+build/26537841 succeeded), with all built-time tests and fuzzers passing.

[Launchpad Janitor (janitor)]

This bug was fixed in the package systemd - 252.5-2ubuntu3.1

---------------
systemd (252.5-2ubuntu3.1) lunar; urgency=medium

  * debian/tests/tests-in-lxd: use --reuse flag in lxc publish (LP: #2023229)
    File: debian/tests/tests-in-lxd
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=2a443ddd5b67596647e463eee64d58c3c71bbf08
  * udev-rules: fix nvme symlink creation on namespace changes (LP: #2028180)
    File: debian/patches/lp2028180-udev-rules-fix-nvme-symlink-creation-on-namespace-changes.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=064c7c00aa133b697ab3c0082b825e2f197f91cc
  * core: reorder systemd arguments on reexec (LP: #2013543)
    File: debian/patches/lp2013543-core-reorder-systemd-arguments-on-reexec.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=45541ccbc16ed30b6a120cda7401f69cce164d54
  * network/dhcp4: do not ignore the gateway even if the destination is in same network (LP: #2009743)
    Files:
    - debian/patches/lp2009743/network-dhcp4-do-not-ignore-the-gateway-even-if-the-desti.patch
    - debian/patches/lp2009743/test-network-add-one-more-testcase-for-DHCPv4-classless-r.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=ddea3bcbca3421299b13cfe897157cfbf9f0f06d
  * debian/systemd.postint: do not daemon re-exec if we could hit LP: #2013543
    File: debian/systemd.postinst
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=e1a08bb427e19ced6c16f054ebdee43ccbc9c528
  * Drop debian/UBUNTU-wait-online-exit-if-no-links-are-managed.patch (LP: #1982218)
    File: debian/patches/debian/UBUNTU-wait-online-exit-if-no-links-are-managed.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=8235427fd8859ee393a08d425e1a52e1ebcbe2f1
  * sd-bus: bus_message_type_from_string is not pure (LP: #2031683)
    File: debian/patches/lp2031683-sd-bus-bus_message_type_from_string-is-not-pure.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=2d65b6c74864976a2bb42c884baf75d1674215fc

 -- Nick Rosbrook <email address hidden> Fri, 18 Aug 2023 14:15:03 -0400

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for systemd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.