Update to version 24.x

[Lucas Kanashiro]

[Impact]

The docker.io-app package is way behind upstream latest version (as opposed as what we have in containerd-app and runc). With the idea of providing the upstream experience to our users, we need to update docker.io-app.

[Test Plan]

Per https://wiki.ubuntu.com/DockerUpdates, our test case is the autopkgtests

[Where problems could occur]

As usual, we deliver most benefit to our users by delivering an upstream experience. A risk of regressions is part of that.

[Original description]

We should update the docker.io-app to the latest upstream version (as we have been doing also to the runc and containerd-app packages). We haven't done so to finish the split of the application and the library but now that it is done I believe it is the time to do it. The latest upstream version at the moment is 24.0.5.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Launchpad Janitor (janitor)]

This bug was fixed in the package docker.io-app - 24.0.5-0ubuntu1

---------------
docker.io-app (24.0.5-0ubuntu1) mantic; urgency=medium

  * Update the way MUT are pre-processed and imported.
    - d/get-orig-source.sh: create a script to be called by uscan when
      importing a new version. This script is going to fetch all the needed
      components and combine all the tarballs into a single one.
    - d/helpers/{real,tini}-upstream-version.sh: create helper scripts to
      support the d/get-orig-source.sh. They process the upstream version of
      differente components.
    - d/watch: update to track just github.com/moby/moby which is the main
      component of this package, the others are now tracked and fetched by
      d/get-orig-source.sh.
  * New upstream version 24.0.5 (LP: #2030500).
  * The libnetwork component is now shipped inside the engine component.
    - d/rules: update to build proxy from the new path.
    - d/docker.io.docs: do not install NOTICE from the removed libnetwork
      component.
    - d/copyright: remove all entries for libnetwork component.
  * Build CLI manpages before build time to avoid downloading modules from the
    Internet.
    - d/docker.io.manpages: install manpages from debian/manpages.
    - d/helpers/build-manpages.sh: create a wrapper for the upstream script
      to generate manpages and place them in the expected directory.
    - d/rules: do not try to build manpage during build time, instead, check
      if the manpages version matches with the upstream one.
  * Create debian/manpages with debian/helpers/build-manpages.sh.
  * Do not override dh_strip, it works fine with Go binaries nowadays.
    - d/docker.io.lintian-overrides: remove unneeded overrides.
    - d/rules: do not override dh_strip.
  * d/control: use arch:any instead of hard-coded arches.
    The list already contains all the supported architectures in all
    supported releases (non-ESM).
  * d/control: suggests docker-buildx and docker-compose-v2.
  * d/README.source: document how to import a new upstream release.
  * Build with Go 1.20. Let's rely on a fixed version for all supported
    releases.
    - d/control: b-d on golang-1.20-go instead of golang-go.
    - d/rules: add Go 1.20 to $PATH.
  * d/docker.io.lintian-overrides: ignore statically-linked-binary.
    This is not a problem for Go binaries.

 -- Lucas Kanashiro <email address hidden> Wed, 16 Aug 2023 18:32:36 -0300

[Andreas Hasenack (ahasenack)]

I'm going over the upstream release notes[1], and found this bit for version 24.0.0:

  Remove the deprecated AUFS and legacy overlay storage drivers. moby/moby#45342, moby/moby#45359

I thought AUFS was already removed, see bug #1939106[2]. But my question is if the removal of "overlay" is bound to cause another issue like that? How common is the overlay storage driver? It looks like the default is overlay2, so maybe "overlay" is really old and deprecated.

I know back in [2] it was decided to stick with upstream's deprecation. I'm just wondering if this will be another such case where we will have to defend our choice.

1. https://github.com/moby/moby/releases
2. https://bugs.launchpad.net/ubuntu/+source/docker.io/+bug/1939106

[Lucas Kanashiro (lucaskanashiro)]

AFAICT the "overlay" storage driver is not used for a while, I do not expect any fallout because of that.

It is not even mentioned in the upstream documentation:

https://docs.docker.com/storage/storagedriver/select-storage-driver/

I do not expect people using it anymore. Thinking about providing "the upstream experience" we shouldn't be worried too much about that.

[Andreas Hasenack (ahasenack)]

Hello Lucas, or anyone else affected,

Accepted docker.io-app into lunar-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/docker.io-app/24.0.5-0ubuntu1~23.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-lunar to verification-done-lunar. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-lunar. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andreas Hasenack (ahasenack)]

Hello Lucas, or anyone else affected,

Accepted docker.io-app into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/docker.io-app/24.0.5-0ubuntu1~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andreas Hasenack (ahasenack)]

Hello Lucas, or anyone else affected,

Accepted docker.io-app into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/docker.io-app/24.0.5-0ubuntu1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted docker.io-app (24.0.5-0ubuntu1~23.04.1) for lunar have finished running.
The following regressions have been reported in tests triggered by the package:

docker.io-app/unknown (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/lunar/update_excuses.html#docker.io-app

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Lucas Kanashiro (lucaskanashiro)]

The regression reported in comment #11 is not a real regression, after re-triggering the test it passed.

[Lucas Kanashiro (lucaskanashiro)]

# Verification

autopkgtest summary run on each release using the version from -proposed:

## Lunar

autopkgtest [17:46:14]: @@@@@@@@@@@@@@@@@@@@ summary
basic-smoke PASS
docker-in-lxd PASS

## Jammy

autopkgtest [17:50:44]: @@@@@@@@@@@@@@@@@@@@ summary
basic-smoke PASS
docker-in-lxd PASS

## Focal

autopkgtest [17:41:15]: @@@@@@@@@@@@@@@@@@@@ summary
basic-smoke PASS
docker-in-lxd PASS

[Launchpad Janitor (janitor)]

This bug was fixed in the package docker.io-app - 24.0.5-0ubuntu1~23.04.1

---------------
docker.io-app (24.0.5-0ubuntu1~23.04.1) lunar; urgency=medium

  * Backport version from Mantic to Lunar (LP: #2030500).
    - d/control: do not suggests docker-buildx and docker-compose-v2. They are
      not available in Lunar at the moment.

 -- Lucas Kanashiro <email address hidden> Mon, 21 Aug 2023 16:50:14 -0300

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for docker.io-app has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package docker.io-app - 24.0.5-0ubuntu1~22.04.1

---------------
docker.io-app (24.0.5-0ubuntu1~22.04.1) jammy; urgency=medium

  * Backport version from Mantic to Jammy (LP: #2030500).
    - d/control: do not suggest docker-buildx and docker-compose-v2. They are
      not available in Jammy at the moment.

 -- Lucas Kanashiro <email address hidden> Mon, 21 Aug 2023 16:50:14 -0300

[Launchpad Janitor (janitor)]

This bug was fixed in the package docker.io-app - 24.0.5-0ubuntu1~20.04.1

---------------
docker.io-app (24.0.5-0ubuntu1~20.04.1) focal; urgency=medium

  * Backport version from Mantic to Focal (LP: #2030500).
    - d/t/basic-smoke: import GPG key from Debian stable. The
      debian-archive-keyring package is out-dated after the release of Debian
      12. Now, the key is downloaded from the ftp-master keyring directly.
    - d/control: do not suggest docker-buildx and docker-compose-v2. They are
      not available in Focal at the moment.

 -- Lucas Kanashiro <email address hidden> Mon, 21 Aug 2023 16:50:14 -0300

[willmo (willmo)]

Per bug 1968035, and as sort of alluded in the changelog entries for the backports, this eliminated buildx from focal/jammy/lunar, which is a significant regression.

[Andreas Schildbach (schildbach)]

I think this change should be rolled back for Focal, Jammy and Lunar (especially for the LTS versions), until a fix for the regression is implemented. Currently, building images is pretty much broken and that's a very common usecase.

[Andreas Hasenack (ahasenack)]

See https://bugs.launchpad.net/ubuntu/+source/docker-buildx/+bug/1968035/comments/13 and https://bugs.launchpad.net/ubuntu/+source/docker-buildx/+bug/1968035/comments/15

With docker 20.10.21-0ubuntu3, from lunar release (for example):

Works without warnings:

  $ docker build .

Works without warnings:

  $ DOCKER_BUILDKIT=1 docker build .

With 24.0.5-0ubuntu1~23.04.1 from lunar-updates:

Works with a warning about using a deprecated build system:

  $ docker build .
  DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
              Install the buildx component to build images with BuildKit:
              https://docs.docker.com/go/buildx/

Does not work:

  $ DOCKER_BUILDKIT=1 docker build .
  ERROR: BuildKit is enabled but the buildx component is missing or broken.
         Install the buildx component to build images with BuildKit:
         https://docs.docker.com/go/buildx/