[SRU][Ubuntu] mpi3mr: Include the latest patchset from upstream into 22.04.4/later LTS

[Chandrakanth Patil]

[Impact]
This BUG is created to integrate the latest mpi3mr driver available upstream into the upcoming Ubuntu LTS OS inbox driver.
- The mpi3mr inbox driver version available in the latest LTS (22.04.02) is 8.0.0.69.0. which is
  considerably the base driver + management app support.
- The latest mpi3mr driver available in the upstream is 8.4.1.0.0 which has various important features and
  critical bugs.

[Fix]
Please include below the latest mpi3mr upstream patset:

git online commit id and description:

f762326b2baa scsi: mpi3mr: Propagate sense data for admin queue SCSI I/O
144679dfb584 scsi: mpi3mr: Fix the type used for pointers to bitmap
2a954832015d scsi: mpi3mr: Use -ENOMEM instead of -1 in mpi3mr_expander_add()
2acc635a0e5e scsi: mpi3mr: Use IRQ save variants of spinlock to protect chain frame allocation
a3d27dfdcfc2 scsi: mpi3mr: Handle soft reset in progress fault code (0xF002)
b85f82f3c92a scsi: mpi3mr: Declare SCSI host template const
1ea41edd88f2 scsi: mpi3mr: Update driver version to 8.4.1.0.0
e74f2fbd8b06 scsi: mpi3mr: Update copyright year
80b8fd0231d5 scsi: mpi3mr: Fix W=1 compilation warnings
e5f596bc2592 scsi: mpi3mr: Update MPI Headers to revision 27
f1dec6b1e25e scsi: mpi3mr: Avoid escalating to higher level reset when target is removed
22beef38e52c scsi: mpi3mr: Modify MUR timeout value to 120 seconds
23b3d1cf1572 scsi: mpi3mr: Fix admin queue memory leak upon soft reset
3f1254ed01d0 scsi: mpi3mr: Successive VD delete and add causes FW fault
ce756daa36e1 scsi: mpi3mr: Fix expander node leak in mpi3mr_remove()
c798304470ca scsi: mpi3mr: Fix memory leaks in mpi3mr_init_ioc()
d4caa1a4255c scsi: mpi3mr: Fix sas_hba.phy memory leak in mpi3mr_remove()
d0f3c3728da8 scsi: mpi3mr: Fix mpi3mr_hba_port memory leak in mpi3mr_remove()
7d2b02172b6a scsi: mpi3mr: Fix config page DMA memory leak
f305a7b6ca21 scsi: mpi3mr: Fix throttle_groups memory leak
8e45183978d6 scsi: mpi3mr: Bad drive in topology results kernel crash
4f297e856a7b scsi: mpi3mr: NVMe command size greater than 8K fails
ba8a9ba41fbd scsi: mpi3mr: Return proper values for failures in firmware init path
0a319f162949 scsi: mpi3mr: Wait for diagnostic save during controller init
5b06a7169c59 scsi: mpi3mr: Driver unload crashes host when enhanced logging is enabled
02ca7da2919a scsi: mpi3mr: ioctl timeout when disabling/enabling interrupt
66b381d874fa scsi: mpi3mr: Remove unneeded version.h include
e39ea831ebad scsi: mpi3mr: Fix missing mrioc->evtack_cmds initialization
339e61565f81 scsi: mpi3mr: Use number of bits to manage bitmap sizes
eeb270aee3e0 scsi: mpi3mr: Remove unnecessary memcpy() to alltgt_info->dmi
fb428a2005fc scsi: mpi3mr: Fix issues in mpi3mr_get_all_tgt_info()
ae7d45f5283d scsi: mpi3mr: Fix an issue found by KASAN
f0a43ba6c66c scsi: mpi3mr: Refer CONFIG_SCSI_MPI3MR in Makefile
d347a951906b scsi: mpi3mr: Remove usage of dma_get_required_mask() API
7d21fcfb4095 scsi: mpi3mr: Suppress command reply debug prints
65244389b1b3 scsi: mpi3mr: Select CONFIG_SCSI_SAS_ATTRS
c863a2dcb9b0 scsi: mpi3mr: Remove unnecessary cast
f616efbee9d6 scsi: mpi3mr: Update driver version to 8.2.0.3.0
2e31be8697b1 scsi: mpi3mr: Fix scheduling while atomic type bug
f84e8b5bb57e scsi: mpi3mr: Scan the devices during resume time
130fc180a481 scsi: mpi3mr: Free enclosure objects during driver unload
bad2f28da625 scsi: mpi3mr: Handle 0xF003 Fault Code
f2a79d2030ad scsi: mpi3mr: Graceful handling of surprise removal of PCIe HBA
7f9f953d537a scsi: mpi3mr: Schedule IRQ kthreads only on non-RT kernels
47cd930ee6ae scsi: mpi3mr: Support new power management framework
ee6f2d6bb2a0 scsi: mpi3mr: Update mpi3 header files
5ba207e55e7f scsi: mpi3mr: Fix error code in mpi3mr_transport_smp_handler()
a113c02f5738 scsi: mpi3mr: Fix error codes in mpi3mr_report_manufacture()
7f90bc70d1a6 scsi: mpi3mr: Block I/Os while refreshing target dev objects
2745ce0e6d30 scsi: mpi3mr: Refresh SAS ports during soft reset
176d4aa69c6e scsi: mpi3mr: Support SAS transport class callbacks
2bd37e284914 scsi: mpi3mr: Add framework to issue MPT transport cmds
7f56c791969e scsi: mpi3mr: Add SAS SATA end devices to STL
626665e9c38d scsi: mpi3mr: Get target object based on rphy
e22bae30667a scsi: mpi3mr: Add expander devices to STL
c4723e68a0d8 scsi: mpi3mr: Enable STL on HBAs where multipath is disabled
42fc9fee116f scsi: mpi3mr: Add helper functions to manage device's port
125ad1e6b445 scsi: mpi3mr: Add helper functions to retrieve device objects
fc7212fd3100 scsi: mpi3mr: Add framework to add phys to STL
7188c03ff884 scsi: mpi3mr: Enable Enclosure device add event
64a8d9315b85 scsi: mpi3mr: Add helper functions to retrieve config pages
32d457d5a2af scsi: mpi3mr: Add framework to issue config requests
3b73c45e6fd2 scsi: mpi3mr: Add config and transport related debug flags
502f4c18704d scsi: mpi3mr: Delete a stray tab
2a8a0147cb52 scsi: mpi3mr: Unlock on error path
cf1ce8b71524 scsi: mpi3mr: Reduce VD queue depth on detecting throttling
f10af057325c scsi: mpi3mr: Resource Based Metering
d29ea7b71621 scsi: mpi3mr: Increase cmd_per_lun to 128
465191d6526a scsi: mpi3mr: Enable shared host tagset
1fcbe4c49039 scsi: mpi3mr: Fix kernel-doc
4094981db7b6 scsi: mpi3mr: Rework mrioc->bsg_device model to fix warnings
9feb5c4c3f95 scsi: mpi3mr: Add target device related sysfs attributes
e51e76edddb1 scsi: mpi3mr: Add shost related sysfs attributes
bc7896d31a92 scsi: mpi3mr: Return error if dma_alloc_coherent() fails
a25eafd13e5f scsi: mpi3mr: Fix a NULL vs IS_ERR() bug in mpi3mr_bsg_init()
256bd4f23d9c scsi: mpi3mr: Return I/Os to an unrecoverable HBA with DID_ERROR
2dd8389f96d6 scsi: mpi3mr: Hidden drives not removed during soft reset
1aa529d40025 scsi: mpi3mr: Increase I/O timeout value to 60s

[ Where problems could occur ]

[ Other Info ]

https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/mpi3mr_update3

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 2029905

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Chandrakanth Patil (cpatubuntu)]

Hi,

Below are a few more mpi3mr driver patches accepted by the upstream. Could we please include these patches as well on top of the earlier patch set?

9a9068b2afa0 scsi: mpi3mr: Update driver version to 8.5.0.0.0
d9a5ab0ea98f scsi: mpi3mr: Enhance handling of devices removed after controller reset
e7a8648e1ce2 scsi: mpi3mr: WRITE SAME implementation
d9adb81e67e9 scsi: mpi3mr: Add support for more than 1MB I/O
6f81b1cfdf33 scsi: mpi3mr: Update MPI Headers to version 3.00.28
9134211f7bed scsi: mpi3mr: Invoke soft reset upon TSU or event ack time out

[Jeff Lane  (bladernr)]

Why is this being requested? What specific certification blockers or customer deployments does this affect?

We don't generally just pull large numbers of patches in like this without a business justification to backport them, unfortunately, the aim is to update the driver to resolve issues that are affecting folks in the field. If someone needs a new driver version the first suggestion is that they should be running the latest HWE kernel which is where those updates normally land.

[Chandrakanth Patil (cpatubuntu)]

+ Sumit

On Mon, Sep 11, 2023 at 11:40 PM Jeff Lane  <email address hidden>
wrote:

> Why is this being requested? What specific certification blockers or
> customer deployments does this affect?
>
> We don't generally just pull large numbers of patches in like this
> without a business justification to backport them, unfortunately, the
> aim is to update the driver to resolve issues that are affecting folks
> in the field. If someone needs a new driver version the first
> suggestion is that they should be running the latest HWE kernel which is
> where those updates normally land.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/2029905
>
> Title:
> [Ubuntu] mpi3mr: Include the latest patchset from upstream into
> 22.04.1/later LTS
>
> Status in linux package in Ubuntu:
> Incomplete
>
> Bug description:
> This BUG is created to integrate the latest mpi3mr driver available
> upstream into the upcoming Ubuntu LTS OS inbox driver.
> - The mpi3mr inbox driver version available in the latest LTS (22.04.02)
> is 8.0.0.69.0. which is
> considerably the base driver + management app support.
> - The latest mpi3mr driver available in the upstream is 8.4.1.0.0 which
> has various important features and
> critical bugs.
>
>
> Please include below the latest mpi3mr upstream patset:
>
>
> git online commit id and description:
>
> f762326b2baa scsi: mpi3mr: Propagate sense data for admin queue SCSI I/O
> f762326b2baa scsi: mpi3mr: Propagate sense data for admin queue SCSI I/O
> 144679dfb584 scsi: mpi3mr: Fix the type used for pointers to bitmap
> 2a954832015d scsi: mpi3mr: Use -ENOMEM instead of -1 in
> mpi3mr_expander_add()
> 2acc635a0e5e scsi: mpi3mr: Use IRQ save variants of spinlock to protect
> chain frame allocation
> a3d27dfdcfc2 scsi: mpi3mr: Handle soft reset in progress fault code
> (0xF002)
> b85f82f3c92a scsi: mpi3mr: Declare SCSI host template const
> 1ea41edd88f2 scsi: mpi3mr: Update driver version to 8.4.1.0.0
> e74f2fbd8b06 scsi: mpi3mr: Update copyright year
> 80b8fd0231d5 scsi: mpi3mr: Fix W=1 compilation warnings
> e5f596bc2592 scsi: mpi3mr: Update MPI Headers to revision 27
> f1dec6b1e25e scsi: mpi3mr: Avoid escalating to higher level reset when
> target is removed
> 22beef38e52c scsi: mpi3mr: Modify MUR timeout value to 120 seconds
> 23b3d1cf1572 scsi: mpi3mr: Fix admin queue memory leak upon soft reset
> 3f1254ed01d0 scsi: mpi3mr: Successive VD delete and add causes FW fault
> ce756daa36e1 scsi: mpi3mr: Fix expander node leak in mpi3mr_remove()
> c798304470ca scsi: mpi3mr: Fix memory leaks in mpi3mr_init_ioc()
> d4caa1a4255c scsi: mpi3mr: Fix sas_hba.phy memory leak in mpi3mr_remove()
> d0f3c3728da8 scsi: mpi3mr: Fix mpi3mr_hba_port memory leak in
> mpi3mr_remove()
> 7d2b02172b6a scsi: mpi3mr: Fix config page DMA memory leak
> f305a7b6ca21 scsi: mpi3mr: Fix throttle_groups memory leak
> 8e45183978d6 scsi: mpi3mr: Bad drive in topology results kernel crash
> 4f297e856a7b scsi: mpi3mr: NVMe command size greater than 8K fails
> ba8a9ba41fbd scsi: mpi3mr: Return proper values for failu...

[Dimitri John Ledkov (xnox)]

Previous request https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1971151

Current driver version in Jammy v5.15 generic kernel with fixes from above bug report. Any changes on top of it should be inline with SRU policy and ideally accepted in linux-stable trees if at all possible.

Current driver version in Jammy v6.2-hwe kernel are up to 8.2.0.3.0 and contain fixes up to the https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2025067 which incorporates fixes up to linux-stable v6.2.15 release

Upcoming Mantic release, and the future Jammy v6.5-hwe kernel will contain 8.4.1.0.0 with fixes up to f762326b2b ("scsi: mpi3mr: Propagate sense data for admin queue SCSI I/O") which will be part of the next 22.04 point release.

Everything mentioned in this bug report will be released in Mantic and hwe kernel in next 22.04 point release.

Thus from Kernel point of view this is all fix-committed and will be part of the hwe kernel on 22.04. Users that require these changes will have to use Server Installer and choose hwe kernel, or switch their installed systems to the hwe kernel.

Individual fixes are suitable for inclusion into the v5.15 generic kernel, if you provide test-plan, regression risk potential, and documentation as required at https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

[Steve Langasek (vorlon)]

This does not appear to be a blocker for Ubuntu 23.10; removing the milestone.

[Michael Reed (mreed8855)]

Here is the test kernel. https://people.canonical.com/~mreed/dell/lp_2029905_mpi3mr/

[Michael Reed (mreed8855)]

This patch is also needed for a clean build.

3d8fa78ebd61 scsi: scsi_transport_sas: Add 22.5 Gbps link rate definitions