apport FTBFS

Bug #2028881 reported by Robie Basak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Rebuilding apport in mantic today FTBFS because of a pylint complaint. We discussed this in #ubuntu-devel today. I don't think that failing the build on a lint failure is appropriate in distribution packaging in a production build since otherwise the build regresses for no good reason. Linting should be done during development but not enabled in production archive builds.

This can be fixed by dropping the lint tests from override_dh_auto_test in debian/rules.

Tags: ftbfs
Revision history for this message
Benjamin Drung (bdrung) wrote :

Proposed solution: Add --errors-only mode to run-linters to only run pylint in --errors-only mode and mypy: https://github.com/canonical/apport/pull/215

Those two can find relevant errors. The linters like black will be skipped.

Revision history for this message
Benjamin Drung (bdrung) wrote :

The new pylint complaints are false positives and I reported them upstream: https://github.com/pylint-dev/pylint/issues/8895

Benjamin Drung (bdrung)
Changed in apport (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.27.0-0ubuntu2

---------------
apport (2.27.0-0ubuntu2) mantic; urgency=medium

  * Run only pylint --errors-only and mypy from tests/run-linters (LP: #2028881)
  * Depend on dictionaries-common for having a dpkg diversion test package
    (LP: #2028879)

 -- Benjamin Drung <email address hidden> Fri, 28 Jul 2023 18:59:34 +0200

Changed in apport (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.