remove magic related warning for focal and bionic

Bug #2028666 reported by nikhil kshirsagar
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
sosreport (Ubuntu)
Fix Committed
Undecided
nikhil kshirsagar
Focal
Fix Released
Undecided
nikhil kshirsagar

Bug Description

[IMPACT]

bionic and focal "sos report" command spews this warning on stderr
and sos defaults to an older approach for binary detection.

"
WARNING: Failed to load 'magic' module version >= 0.4.20 which sos aims
to use for detecting binary files. A less effective method will be used.
It is recommended to install proper python3-magic package with the
module.
"

This stderr output warning causes autopkgtests to fail for focal and bionic.

This patch avoids showing the warning since focal and bionic would anyway never get the python3-magic version needed (0.4.20) so there is no point warning about this and it's better simply to use to the older approach without checking for this version of python3-magic.

See https://bugs.launchpad.net/ubuntu/+source/sosreport/+bug/2022915/comments/37

[TEST PLAN]

Documentation for Special Cases:
https://wiki.ubuntu.com/SosreportUpdates

[WHERE PROBLEMS COULD OCCUR]

Since this patch avoid looking for python3-magic itself it may cause issues in sosreport in other places where there is an assumption about python3-magic having at least being attempted loading. I have however gone through the code and ruled this out, so this patch looks quite safe to me.

Changed in sosreport (Ubuntu):
status: New → Fix Committed
assignee: nobody → nikhil kshirsagar (nkshirsagar)
summary: - remote magic related warning for focal and bionic
+ remove magic related warning for focal and bionic
Revision history for this message
nikhil kshirsagar (nkshirsagar) wrote :
description: updated
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

The patch looks good to me. Solves the false positive autopkgtest issue we discussed before.

tags: added: patch
Revision history for this message
Andreas Hasenack (ahasenack) wrote : Please test proposed package

Hello nikhil, or anyone else affected,

Accepted sosreport into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/4.5.6-0ubuntu1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in sosreport (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (sosreport/4.5.6-0ubuntu1~20.04.1)

All autopkgtests for the newly accepted sosreport (4.5.6-0ubuntu1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

sosreport/4.5.6-0ubuntu1~20.04.1 (ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#sosreport

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Changed in sosreport (Ubuntu Focal):
assignee: nobody → nikhil kshirsagar (nkshirsagar)
Revision history for this message
nikhil kshirsagar (nkshirsagar) wrote :

I have verified this issue is fixed during testing of proposed packages for https://bugs.launchpad.net/bugs/2028327

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 4.5.6-0ubuntu1~20.04.1

---------------
sosreport (4.5.6-0ubuntu1~20.04.1) focal; urgency=medium

  * New 4.5.6 upstream. (LP: #2028327)

  * For more details, full release note is available here:
    - https://github.com/sosreport/sos/releases/tag/4.5.6

  * d/control:
   - Add 'python3-pexpect' as part of the build depends.

  * d/rules:
    - skip running unittests/policy_tests.py due to the avocado dependency

  * New patches:
    - d/p/0002-debian-remove-magic-stderr.patch (LP: #2028666)

  * Former patches, now fixed:
    - d/p/0002-revert-to-old-style-binary-file-detection.patch

  * Remaining patches:
    - d/p/0001-debian-change-tmp-dir-location.patch

 -- Nikhil Kshirsagar <email address hidden> Tue, 25 Jul 2023 10:52:47 +0000

Changed in sosreport (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote : Update Released

The verification of the Stable Release Update for sosreport has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.