failed kernel mapping specification

[Dan Bungert]

In testing the current desktop installer ISOs with a freshly build u-d-i snap, curthooks fails like follows:

 finish: cmd-install/stage-curthooks/builtin/cmd-curthooks/installing-kernel: FAIL: installing kernel
 finish: cmd-install/stage-curthooks/builtin/cmd-curthooks: FAIL: curtin command curthooks
 Traceback (most recent call last):
   File "/snap/ubuntu-desktop-installer/x1/lib/python3.10/site-packages/curtin/commands/main.py", line 202, in main
     ret = args.func(args)
   File "/snap/ubuntu-desktop-installer/x1/lib/python3.10/site-packages/curtin/commands/curthooks.py", line 1918, in curthooks
     builtin_curthooks(cfg, target, state)
   File "/snap/ubuntu-desktop-installer/x1/lib/python3.10/site-packages/curtin/commands/curthooks.py", line 1752, in builtin_curthooks
     install_kernel(cfg, target)
   File "/snap/ubuntu-desktop-installer/x1/lib/python3.10/site-packages/curtin/commands/curthooks.py", line 375, in install_kernel
     config.merge_config(mapping, kernel_cfg.get('mapping', {}))
 AttributeError: 'NoneType' object has no attribute 'get'
 'NoneType' object has no attribute 'get'
 curtin: Installation failed with exception: Unexpected error while running command.
 Command: ['curtin', 'curthooks']
 Exit code: 3
 Reason: -

happened as part of an autoinstall test, no override of the kernel value.

[Olivier Gayot (ogayot)]

I'm not sure yet why you ended up in this scenario. It looks like a subiquity bug.

That said, the install_kernel function in curthooks has code to handle kernel_cfg=None, but then it invokes the .get() method regardless. This is obviously wrong.

    if kernel_cfg is not None:
        kernel_package = kernel_cfg.get('package')
        kernel_fallback = kernel_cfg.get('fallback-package')
    else:
        kernel_package = None
        kernel_fallback = None

    config.merge_config(mapping, kernel_cfg.get('mapping', {}))

[Server Team CI bot (server-team-bot)]

This bug is fixed with commit 168c4fd3 to curtin on branch master.
To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=168c4fd3

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Ubuntu QA Website (ubuntuqa)]

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
https://iso.qa.ubuntu.com/qatracker/reports/bugs/2026225

[Launchpad Janitor (janitor)]

This bug was fixed in the package livecd-rootfs - 23.10.9

---------------
livecd-rootfs (23.10.9) mantic; urgency=medium

  * desktop, budgie: no need to include the kernel directly, it is installed
    at runtime (LP: #2026225)

 -- Dan Bungert <email address hidden> Wed, 02 Aug 2023 13:16:00 -0600

[Dan Bungert (dbungert)]

Reopened, due to reverting this change.

[Launchpad Janitor (janitor)]

This bug was fixed in the package livecd-rootfs - 23.10.34

---------------
livecd-rootfs (23.10.34) mantic; urgency=medium

  [ Steve Langasek ]
  * Drop (outdated, inconsistent) /etc/hosts from ubuntu-server chroot
    includes.

  [ Michael Hudson-Doyle ]
  * auto/config: use the new server-live task to reduce the use of explicit
    calls to add_package and add_snap a bit.

  [ Dave Jones ]
  * clean up references to obsolete pi subarchs no longer built, and remove
    code that writes out /boot/firmware settings that are later clobbered

  [ Dan Bungert ]
  * desktop: adjust kernel to be in the live layer, to support changing which
    kernel is installed rather than always using hwe. (LP: #2026225)

 -- Dan Bungert <email address hidden> Fri, 08 Sep 2023 08:54:13 -0600