Metadata wrong for books from gui.download_ebook

[Florian Bach]

This seems to be a similar bug from the ones I previously reported, related to my ACSM-to-EPUB-plugin:

- Metadata wrong for auto-added books ( https://bugs.launchpad.net/calibre/+bug/1945889 )
- Metadata wrong for books added through the web server ( https://bugs.launchpad.net/calibre/+bug/1992244 )

Metadata is also wrong for ACSM files added to Calibre through Calibre's "download_ebook" function.

When a GUI plugin executes the following code ...
(this link should be permanently valid and leads to a Public Domain eBook, so no issue there)

self.gui.download_ebook("https://contentserver.adobe.com/fulfillment/URLLink.acsm?action=free&ordersource=operator&resid=urn%3Auuid%3Ac0385b71-bcd6-44dd-9a69-ec8a931d25e2")

Calibre does download the ACSM file for the book, does add it to Calibre properly going through all the plugins normally running upon book import, but again just like in the other two bug reports uses the metadata extracted from the ACSM (Title "URLLink" instead of the book's title) instead of the metadata from the final book file.

Can a similar fix you made for bugs 1945889 and 1992244 be made for this API / method as well?

This bug has been tested with Calibre 6.21, both on Linux and on MacOS. If necessary, I can attach a log file.

[ownedbycats (ownedbycats)]

A note that may be helpful: If DeDRM plugin is enabled, metadata _does_ import properly, at least when I tested it with the provided link using ACSM Input. At the least, it provides a workaround for users.

from what I understand, DeDRM intercepts the file, checks for DRM (and attempts to remove if neeede), then hands it back to Calibre.

[ping (ping-modified)]

I do not observe the same behaviour as ownedbycats.

Also using the same link in this bug report, with DeACSM and DeDRM installed, the epub is successfully downloaded and processed but does _not_ have calibre metadata.

The workaround is still to go manually into metadata editor and restore the cover, metadata from the epub.

[Florian Bach (leseratte10)]

@ownedbycats In my case, even with DeDRM installed, metadata is not working properly.

In your test cases, did you actually add this line of code to a GUI plugin and triggered it that way? Downloading the link normally and adding the file to Calibre will work just fine.

I'm attaching a log file of my attempt (with DeDRM enabled). I also tried with the DeDRM plugin disabled but the issue still persists so in my opinion that plugin has nothing to do with the bug (same as it was the case with the previous two linked bugs).

[Kovid Goyal (kovid)]

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.