sysdig-dkms FTBS with linux 6.2 on jammy

[Andrea Righi]

[Impact]

var/lib/dkms/sysdig/0.27.1/build/main.c: In function ‘sysdig_init’:
/var/lib/dkms/sysdig/0.27.1/build/main.c:2490:30: error: assignment to ‘char * (*)(const struct device *, umode_t *)’ {aka ‘char * (*)(const struct device *, short unsigned int *)’} from incompatible pointer type ‘char * (*)(struct device *, umode_t *)’ {aka ‘char * (*)(struct device *, short unsigned int *)’} [-Werror=incompatible-pointer-types]
 2490 | g_ppm_class->devnode = ppm_devnode;
      | ^

[Test case]

 $ sudo apt install sysdig-dkms

With the fix applied:

 - release kernel 5.15:

Building for 5.15.0-77-generic
Building initial module for 5.15.0-77-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

sysdig-probe.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-77-generic/updates/dkms/

 - hwe kernel 6.2:

Building initial module for 6.2.0-25-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

sysdig-probe.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.2.0-25-generic/updates/dkms/

[Fix]

Fix sysdig_init() to properly support the new linux 6.2 kernel ABI (we can't backport a patch from more recent Ubuntu releases, because sysdig-dkms has been obsoleted by falcosecurity-dkms starting with Lunar).

[Regression potential]

We may experience regressions in systems where sysdig is still used as an analysis tool, especially with the new 6.2 kernel.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: sysdig-dkms 0.27.1-0.3ubuntu0.1
ProcVersionSignature: User Name 6.2.0-23.23~22.04.1-generic 6.2.12
Uname: Linux 6.2.0-23-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSubPlatform: config-disk (/dev/vdb)
Date: Wed Jun 21 15:22:06 2023
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=C.UTF-8
 SHELL=/bin/bash
SourcePackage: sysdig
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

debdiff in attach adds support to linux 6.2 ABI.

[Robie Basak (racb)]

> sysdig-dkms has been obsoleted by falcosecurity-dkms starting with Lunar

Thank you for noting this. This means the bug should be Invalid for the development release, right?

Accepting, but please add to your test plan to test against the release kernel as well as the HWE kernel. Please consider this mandatory for HWE DKMS fixes in general.

[Robie Basak (racb)]

Hello Andrea, or anyone else affected,

Accepted sysdig into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sysdig/0.27.1-0.3ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andrea Righi (arighi)]

@racb: yes this bug should only affect Jammy, since the package doesn't exist anymore in the development release.

And ok about the test plan, I should be more clear in the description, if it's not mentioned I always test these fixes both with the release kernel and the hwe kernel. Unfortunately not across all architectures, in fact I need to figure out a better testing workflow. Also because this one seems to regress on riscv64 (even if the failure doesn't seem to be related to my change, I'll double check as soon as I get access to a riscv64 system):

https://launchpadlibrarian.net/673496948/buildlog_ubuntu-jammy-riscv64.sysdig_0.27.1-0.3ubuntu0.2_BUILDING.txt.gz

[Launchpad Janitor (janitor)]

This bug was fixed in the package sysdig - 0.27.1-0.3ubuntu0.2

---------------
sysdig (0.27.1-0.3ubuntu0.2) jammy; urgency=medium

  * Support linux 6.2 (LP: #2024591):
    - debian/patches/support-linux-6.2.patch

 -- Andrea Righi <email address hidden> Wed, 21 Jun 2023 15:33:49 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for sysdig has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.