Update gnome-remote-desktop to 42.9

[Jeremy Bícha]

Impact
------
This is a new stable release in the GNOME 42 series

It backports fixes for some crashes reported to errors.ubuntu.com

Changes since the current Ubuntu 22.04 LTS release:
https://gitlab.gnome.org/GNOME/gnome-remote-desktop/-/compare/42.7...42.9

Test Cases
----------
Complete all the test cases from
https://wiki.ubuntu.com/DesktopTeam/TestPlans/RemoteDesktop

except for the "New Audio Forwarding Feature" test case.

What Could Go Wrong
-------------------
RDP Sharing is a new feature for Ubuntu 22.04 LTS as part of GNOME 42. (Previously only VNC Sharing was offered.)

RDP Sharing can be used for providing remote support so it's important that this feature works well because it may be difficult for the remote admin to fix issues in person.

gnome-remote-desktop is part of GNOME Core and falls under the GNOME Stable Release Update microrelease exception

https://wiki.ubuntu.com/StableReleaseUpdates/GNOME

Other Info
----------
The previous 22.04 LTS SRU, 42.7-0ubuntu1, got stuck in phased updates. We worked with upstream to do a new 42 release in hopes that this update along with the SRU for mutter 42.9 (LP: #1998286) will significantly improve the error rate.

42.7-0ubuntu1 was included in Ubuntu Desktop 22.04.2 so many users already have that version from the original install or got it before phasing was halted.

https://ubuntu-archive-team.ubuntu.com/phased-updates.html

[Robie Basak (racb)]

Accepting, thanks. FTR, I think it's fine to have made improvements in testing without a separate SRU bug. I have reviewed this change and testing looks objectively better now.

[Robie Basak (racb)]

Hello Jeremy, or anyone else affected,

Accepted gnome-remote-desktop into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-remote-desktop/42.8-0ubuntu0.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Marco Trevisan (Treviño) (3v1n0)]

Sadly this new version has a new crash:

Core was generated by `/usr/libexec/gnome-remote-desktop-daemon'.
Program terminated with signal SIGABRT, Aborted.
#0 __pthread_kill_implementation (no_tid=0, signo=6, threadid=140478263563840) at ./nptl/pthread_kill.c:44
44 ./nptl/pthread_kill.c: No such file or directory.
[Current thread is 1 (Thread 0x7fc3a4ff9640 (LWP 412662))]
(gdb) bt
#0 __pthread_kill_implementation (no_tid=0, signo=6, threadid=140478263563840) at ./nptl/pthread_kill.c:44
#1 __pthread_kill_internal (signo=6, threadid=140478263563840) at ./nptl/pthread_kill.c:78
#2 __GI___pthread_kill (threadid=140478263563840, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3 0x00007fc3c4ef2476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4 0x00007fc3c4ed87f3 in __GI_abort () at ./stdlib/abort.c:79
#5 0x00007fc3c5a34b57 in g_assertion_message
    (domain=<optimized out>, file=<optimized out>, line=<optimized out>, func=0x564671390620 <__func__.4.lto_priv.6> "maybe_release_pipewire_buffer_lock", message=<optimized out>) at ../../../glib/gtestutils.c:3253
#6 0x00007fc3c5a8e70f in g_assertion_message_expr
    (domain=domain@entry=0x0, file=file@entry=0x56467138fd98 "../src/grd-rdp-pipewire-stream.c", line=line@entry=194, func=func@entry=0x564671390620 <__func__.4.lto_priv.6> "maybe_release_pipewire_buffer_lock", expr=expr@entry=0x0) at ../../../glib/gtestutils.c:3279
#7 0x0000564671374c00 in maybe_release_pipewire_buffer_lock
    (stream=<optimized out>, stream=0x56467361d280, buffer=0x0) at ../src/grd-rdp-pipewire-stream.c:194
#8 on_frame_ready (stream=0x56467361d280, frame=0x0, success=<optimized out>, user_data=0x0)
    at ../src/grd-rdp-pipewire-stream.c:1055
#9 0x00007fc3c5788195 in impl_node_process_input (object=0x56467364ff90) at ../src/pipewire/stream.c:953
#10 0x00007fc3c5760ab9 in process_node (data=0x564672f78b00) at ../src/pipewire/impl-node.c:1089
#11 0x00007fc3c576649c in node_on_fd_events (source=<optimized out>) at ../src/pipewire/impl-node.c:1147
#12 0x00007fc3b813fe33 in () at /usr/lib/x86_64-linux-gnu/spa-0.2/support/libspa-support.so
#13 0x00007fc3c5743226 in do_loop (user_data=0x564673611750) at ../src/pipewire/data-loop.c:81
#14 0x00007fc3c4f44b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#15 0x00007fc3c4fd6a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
(gdb) f 7
#7 0x0000564671374c00 in maybe_release_pipewire_buffer_lock (stream=0x56467361d280, stream=0x56467361d280,
    buffer=0x0) at ../src/grd-rdp-pipewire-stream.c:194
194 ../src/grd-rdp-pipewire-stream.c: No such file or directory.
(gdb) print stream
$1 = 0x56467361d280
(gdb) print *stream
$2 = {parent = {g_type_instance = {g_class = 0x564673615810 [g_type: None]}, ref_count = 1, qdata = 0x0},
  session_rdp = 0x564672f68050, rdp_surface = 0x7fc37c011050, pipewire_source = 0x564672eb7b10,
  pipewire_context = 0x564673633570, pipewire_core = 0x564672f7b140, pipewire_core_listener = {link = {
      next = 0x56467364ff98, prev = 0x564672f7b1e8}, cb = {funcs = 0x56467139dde0 <core_events.lto_priv>,
      data = 0x56467361d280}, removed = 0x0, priv = 0x0}, buffer_pool = 0x5646736061e0,
  rende...

[Steve Langasek (vorlon)]

Hello Jeremy, or anyone else affected,

Accepted gnome-remote-desktop into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-remote-desktop/42.9-0ubuntu0.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[jenhsun (jenhsun)]

I can confirm 42.9 did fix 42.8's crash issue. Thank you all.

[Robie Basak (racb)]

Thank you for the verification jenhsun!

There was also a plan to carry out testing as documented at https://wiki.ubuntu.com/DesktopTeam/TestPlans/RemoteDesktop. See the plan in the bug description above. Was this done? If so, please document that and flip the tag back.

[Andreas Hasenack (ahasenack)]

This is still missing a jammy verification.

[Marco Trevisan (Treviño) (3v1n0)]

Tested both VNC and RDP cases in 22.04 using 42.9-0ubuntu0.22.04.1

All green, following test cases in https://wiki.ubuntu.com/DesktopTeam/TestPlans/RemoteDesktop.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-remote-desktop - 42.9-0ubuntu0.22.04.1

---------------
gnome-remote-desktop (42.9-0ubuntu0.22.04.1) jammy; urgency=medium

  * New upstream release (LP: #2024248):
    - Fixes a crash found during verification of 42.8, see the bug
      above for further details.

gnome-remote-desktop (42.8-0ubuntu0.22.04.1) jammy; urgency=medium

  * New upstream release (LP: #2024248):
    - vnc: Ensure PipeWire buffers to be queued before destroying them
      (LP: #2024238)
    - rdp: Ensure PipeWire buffers to be queued before destroying them
      (LP: #2024240)
  * debian: Add tests dependencies and run tests failing in case

 -- Marco Trevisan (Treviño) <email address hidden> Wed, 05 Jul 2023 19:54:01 +0200

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for gnome-remote-desktop has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.