flip effect doesn't work on GStreamer 1.22

Bug #2023675 reported by Phelipe Matheus Couto de Aguiar
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNOME Video Effects
Fix Released
Unknown
gnome-video-effects (Debian)
Fix Released
Unknown
gnome-video-effects (Ubuntu)
Fix Released
Undecided
Phelipe Matheus Couto de Aguiar
Lunar
Fix Released
Medium
Jeremy Bícha

Bug Description

Impact
------
The Flip effect in the Cheese app doesn't work in Ubuntu 23.10.

Test Case
---------
1. Install the updated gnome-video-effects packages
2. Open the Cheese app
3. Click the Effects button and verify that Flip is showing a reversed version of No Effect

What Could Go Wrong
-------------------
This is a simple one-line patch. gnome-video-effects has only one reverse dependency in Ubuntu: cheese.

Original Bug Report
-------------------
Distributor ID: Ubuntu
Description: Ubuntu 23.04
Release: 23.04
Codename: lunar

gnome-video-effects:
  Installed: 0.5.0-1ubuntu1
  Candidate: 0.5.0-1ubuntu1
  Version table:
 *** 0.5.0-1ubuntu1 500
        500 http://br.archive.ubuntu.com/ubuntu lunar/main amd64 Packages
        100 /var/lib/dpkg/status

The file located in: /usr/share/gnome-video-effects/flip.effect is using the property "method" which is deprecated as you can see in GStreamer "https://gstreamer.freedesktop.org/documentation/videofilter/videoflip.html?gi-language=c"

Deprecated version: PipelineDescription=videoflip method=horizontal-flip

So the fix for this problem is to change the property to the new one, which is called video-direction, after this the effect will work correctly.

Fix: PipelineDescription=videoflip video-direction=horiz

The program that I used to test this effect was Cheese.

Revision history for this message
Phelipe Matheus Couto de Aguiar (matheus-aguiar-dev) wrote :

here is the bug fix, that was informed in the LP

Changed in gnome-video-effects (Ubuntu):
assignee: nobody → Phelipe Matheus Couto de Aguiar (matheus-aguiar-dev)
status: New → Confirmed
status: Confirmed → Fix Committed
status: Fix Committed → Fix Released
status: Fix Released → New
Jeremy Bícha (jbicha)
Changed in gnome-video-effects (Ubuntu):
status: New → Fix Committed
Changed in gnome-video-effects (Ubuntu Lunar):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Jeremy Bícha (jbicha)
Jeremy Bícha (jbicha)
description: updated
Changed in gnome-video-effects:
status: Unknown → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-video-effects - 0.6.0-1ubuntu1

---------------
gnome-video-effects (0.6.0-1ubuntu1) mantic; urgency=medium

  * Merge with Debian, remaining Ubuntu changes:
    - Split gnome-video-effects that require the "bad" gstreamer plugins
      into a separate package: gnome-video-effects-extra.

gnome-video-effects (0.6.0-1) unstable; urgency=medium

  * New upstream release
    - Fix flip effect with gstreamer 1.22 (Closes: #1037514, LP: #2023675)
  * gnome-video-effects-frei0r.install: Install new scanlines effect

 -- Jeremy Bícha <email address hidden> Tue, 13 Jun 2023 15:30:21 -0400

Changed in gnome-video-effects (Ubuntu):
status: Fix Committed → Fix Released
Changed in gnome-video-effects (Debian):
status: Unknown → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote :

This bug has been triaged as 'Medium', which I believe is correct. It therefore does not fit the Ubuntu SRU policy: https://wiki.ubuntu.com/StableReleaseUpdates#When

Rejecting this upload.

Changed in gnome-video-effects (Ubuntu Lunar):
status: In Progress → Won't Fix
Revision history for this message
Steve Langasek (vorlon) wrote : Proposed package upload rejected

An upload of gnome-video-effects to lunar-proposed has been rejected from the upload queue for the following reason: "does not comply with SRU policy".

Revision history for this message
Jeremy Bícha (jbicha) wrote :

I appeal the rejection of this Stable Release Update using this criteria:

"In the following cases a stable release update is also applicable as they have a low potential for regressing existing installations but a high potential for improving the user experience, particularly for Long Term Support releases:

Bugs which do not fit under above categories, but (1) have an obviously safe patch and (2) affect an application rather than critical infrastructure packages (like X.org or the kernel)."

Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Phelipe, or anyone else affected,

Accepted gnome-video-effects into lunar-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-video-effects/0.5.0-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-lunar to verification-done-lunar. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-lunar. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-video-effects (Ubuntu Lunar):
status: Won't Fix → Fix Committed
tags: added: verification-needed verification-needed-lunar
Revision history for this message
Phelipe Matheus Couto de Aguiar (matheus-aguiar-dev) wrote :

Hi, Steve!

The package(gnome-video-effects 0.5.0-1ubuntu2) was installed and tested using the following steps:

Opened Cheese, in the main screen the flip(horizontal-invertion) effect was applied correctly, checked other effects to confirm if the effect was indeed being applied correctly and yes it was.

So with this tests on the package gnome-video-effects 0.5.0-1ubuntu2 its confirmed that the problem was solved.

tags: added: verification-done-lunar
removed: verification-needed-lunar
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-video-effects has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-video-effects - 0.5.0-1ubuntu2

---------------
gnome-video-effects (0.5.0-1ubuntu2) lunar; urgency=medium

  * Cherry-pick patch to fix flip effect with gstreamer 1.22 (LP: #2023675)

 -- Jeremy Bícha <email address hidden> Tue, 13 Jun 2023 15:34:22 -0400

Changed in gnome-video-effects (Ubuntu Lunar):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.