rtl8812au-dkms FTBS with linux 6.2 in jammy

[Andrea Righi]

[Impact]

/home/ubuntu/rtl8812au-4.3.8.12175.20140902+dfsg/os_dep/osdep_service.c:2310:16: error: implicit declaration of function ‘prandom_u32’; did you mean ‘get_random_u32’? [-Werror=implicit-function-declaration]
 2310 | return prandom_u32();
      | ^~~~~~~~~~~
      | get_random_u32

[Test case]

 $ sudo apt install rtl8812au-dkms

Following some test results with the fix applied:

- hwe kernel 6.2 in Jammy:

$ sudo dpkg -i rtl8812au-dkms_4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2_all.deb
Selecting previously unselected package rtl8812au-dkms.
(Reading database ... 168316 files and directories currently installed.)
Preparing to unpack rtl8812au-dkms_4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2_all.deb ...
Unpacking rtl8812au-dkms (4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2) ...
Setting up rtl8812au-dkms (4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2) ...
Loading new rtl8812au-4.3.8.12175.20140902+dfsg DKMS files...
Building for 6.2.0-23-generic
Building initial module for 6.2.0-23-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.
BUILD_EXCLUSIVE_KERNEL=

8812au.ko:
obsolete_by=
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.2.0-23-generic/updates/dkms/

- release kernel 5.15 in Jammy:

$ sudo dpkg -i rtl8812au-dkms_4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2_all.deb
Selecting previously unselected package rtl8812au-dkms.
(Reading database ... 157140 files and directories currently installed.)
Preparing to unpack rtl8812au-dkms_4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2_all.deb ...
Unpacking rtl8812au-dkms (4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2) ...
Setting up rtl8812au-dkms (4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2) ...
Loading new rtl8812au-4.3.8.12175.20140902+dfsg DKMS files...
Building for 5.15.0-77-generic
Building initial module for 5.15.0-77-generic

EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

8812au.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-77-generic/updates/dkms/

- release kernel 6.2 in Lunar:

$ sudo dpkg -i rtl8812au-dkms_4.3.8.12175.20140902+dfsg-0ubuntu20_all.deb
(Reading database ... 116669 files and directories currently installed.)
Preparing to unpack rtl8812au-dkms_4.3.8.12175.20140902+dfsg-0ubuntu20_all.deb ...
Module rtl8812au-4.3.8.12175.20140902+dfsg for kernel 6.2.0-24-generic (x86_64).
Before uninstall, this module version was ACTIVE on this kernel.

8812au.ko:
 - Uninstallation
   - Deleting from: /lib/modules/6.2.0-24-generic/updates/dkms/
 - Original module
   - No original module was found for this module on this kernel.
   - Use the dkms install command to reinstall any previous module version.
depmod....
Deleting module rtl8812au-4.3.8.12175.20140902+dfsg completely from the DKMS tree.
Unpacking rtl8812au-dkms (4.3.8.12175.20140902+dfsg-0ubuntu20) over (4.3.8.12175.20140902+dfsg-0ubuntu20) ...
Setting up rtl8812au-dkms (4.3.8.12175.20140902+dfsg-0ubuntu20) ...
Loading new rtl8812au-4.3.8.12175.20140902+dfsg DKMS files...
Building for 6.2.0-24-generic
Building initial module for 6.2.0-24-generic
Done.

8812au.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.2.0-24-generic/updates/dkms/

[Fix]

Backport the right patch(es) from Lunar to properly support the new Linux 6.2 kernel ABI.

[Regression potential]

We may experience networking/wifi regressions in systems that are using this driver with the new 6.2 kernel.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: rtl8812au-dkms (not installed)
ProcVersionSignature: User Name 6.2.0-23.23~22.04.1-generic 6.2.12
Uname: Linux 6.2.0-23-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
Date: Tue Jun 13 13:56:49 2023
SourcePackage: rtl8812au
UpgradeStatus: No upgrade log present (probably fresh install)

[Dimitri John Ledkov (xnox)]

KERNEL_VERSION_OBSOLETE 6.2 probably is the right solution for jammy

[Dimitri John Ledkov (xnox)]

in mantic, this package probably needs removal.

[Dimitri John Ledkov (xnox)]

in lunar, this package probably needs to be SRUed to prevent dkms autobuild

[Andrea Righi (arighi)]

I decided to spend some time on this and fix the driver for mantic (now it supports kernels up to 6.4). Now we can SRU this back to lunar and jammy. We don't need to drop this driver.

[Andrea Righi (arighi)]

SRU debdiff for lunar.

[Andrea Righi (arighi)]

SRU debdiff for jammy with linux hwe 6.2.

[Launchpad Janitor (janitor)]

This bug was fixed in the package rtl8812au - 4.3.8.12175.20140902+dfsg-0ubuntu20

---------------
rtl8812au (4.3.8.12175.20140902+dfsg-0ubuntu20) mantic; urgency=medium

  * Support Linux 6.2 (LP: #2023661).

 -- Andrea Righi <email address hidden> Tue, 04 Jul 2023 16:36:51 +0200

[Timo Aaltonen (tjaalton)]

Hello Andrea, or anyone else affected,

Accepted rtl8812au into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/rtl8812au/4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Robie Basak (racb)]

Swapping the tags back as this is still awaiting documented verification. Please see the instructions in comment 9.

[Andrea Righi (arighi)]

We do not have the hardware to validate if the driver is working correctly, the best we can do is to perform a test build for this dkms.

The test plan (in the bug description at the top) already shows the new version of the package (4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2) that has been tested both with the release kernel (5.15.0-77-generic) and the new HWE kernel (6.2.0-24-generic) with positive result.

[Chris Halse Rogers (raof)]

Is someone going to do a Lunar upload for this? I don't see how you can have done a Lunar verification, as there isn't a package in lunar-proposed to test!

[Andreas Hasenack (ahasenack)]

Still no lunar upload. This is blocking the release to jammy.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Andreas Hasenack (ahasenack)]

Still no lunar upload. This is blocking the release to jammy.

[Brian Murray (brian-murray)]

The lunar version of this fix is being tracked in bug 2017672.

[Andreas Hasenack (ahasenack)]

LP: #2017672 is fix released for lunar, so marking the same here.

[Launchpad Janitor (janitor)]

This bug was fixed in the package rtl8812au - 4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2

---------------
rtl8812au (4.3.8.12175.20140902+dfsg-0ubuntu17~22.04.2) jammy; urgency=medium

  * Support Linux 6.2 (LP: #2023661).

 -- Andrea Righi <email address hidden> Tue, 04 Jul 2023 10:29:34 +0000

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for rtl8812au has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.