xtables-addons-dkms FTBS with linux 6.2 in jammy

[Andrea Righi]

[Impact]

xtables-addons-dkms fails to build with linux 6.2 in jammy:

/var/lib/dkms/xtables-addons/3.19/build/extensions/xt_CHAOS.c:70:46: error: implicit declaration of function ‘prandom_u32’; did you mean ‘get_random_u32’? [-Werror=implicit-function-declaration]
   70 | if (!ret || hotdrop || (unsigned int)prandom_u32() > delude_percentage)
      | ^~~~~~~~~~~
      | get_random_u32

[Test case]

 $ sudo apt install xtables-addons-dkms

With the fix applied:

 - hwe kernel 6.2:

Building for 6.2.0-25-generic
Building initial module for 6.2.0-25-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

xt_ACCOUNT.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.2.0-25-generic/updates/dkms/

...

  - release kernel 5.15:

Building for 5.15.0-77-generic
Building initial module for 5.15.0-77-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

xt_ACCOUNT.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-77-generic/updates/dkms/

...

[Fix]

Backport the patch(es) from Lunar to properly support the new Linux 6.2 kernel ABI.

[Regression potential]

Xtables-addons provides extra modules for iptables not present in the upstream kernel, so we may experience networking/firewall-related regressions in systems that are using this module with a 6.2 kernel.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: xtables-addons-dkms 3.19-1
ProcVersionSignature: User Name 6.2.0-23.23~22.04.1-generic 6.2.12
Uname: Linux 6.2.0-23-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
Date: Tue Jun 13 12:12:24 2023
PackageArchitecture: all
SourcePackage: xtables-addons
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

Correct version to fix all the build bugs with linux 6.2 (ignore the previous patches).

[Steve Langasek (vorlon)]

Hello Andrea, or anyone else affected,

Accepted xtables-addons into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xtables-addons/3.19-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andrea Righi (arighi)]

Verified in jammy (updated test plan description with the results).

[Launchpad Janitor (janitor)]

This bug was fixed in the package xtables-addons - 3.19-1ubuntu1

---------------
xtables-addons (3.19-1ubuntu1) jammy; urgency=medium

  * Support Linux 6.2 (LP: #2023655):
    - debian/patches/0001-build-support-for-Linux-6.2.patch

 -- Andrea Righi <email address hidden> Tue, 13 Jun 2023 12:31:18 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for xtables-addons has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Oibaf (oibaf)]

Fixed in 3.19-1ubuntu1.