neomutt crashes when saving copy of sent mail to shown folder

[Hans Dampf]

When sending a mail while visiting a folder other then =Inbox, neomutt crashes after a copy of the sent mail is stored in the visited folder. After the mail is sent and the copy is saved, the screen doesn't show the folder any more. After the next keypress, neomutt crashes.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: neomutt 20211029+dfsg1-1
ProcVersionSignature: Ubuntu 5.15.0-73.80-generic 5.15.98
Uname: Linux 5.15.0-73-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: KDE
Date: Sat Jun 10 13:48:02 2023
InstallationDate: Installed on 2019-01-23 (1598 days ago)
InstallationMedia: Kubuntu 18.04.1 LTS "Bionic Beaver" - Release amd64 (20180725)
SourcePackage: neomutt
UpgradeStatus: Upgraded to jammy on 2022-12-18 (173 days ago)

[Hans Dampf (hda22)]

Sometimes (I couldn't identify a pattern so far) the crash is accompanied by an error message "corrupted double linked list" and even more seldomly "realloc(): invalid pointer"

[Hans Dampf (hda22)]

Probably it is this https://github.com/neomutt/neomutt/issues/3129 respectively this https://github.com/neomutt/neomutt/issues/3116 upstream bug. At least the "workaround" given there (bug isn't triggered in folders listed in mailboxes) works for me. The upstream bug is fixed in newer versions of neomutt.

[Hans Dampf (hda22)]

Obviously, this patch fixes the crash, but might introduce a memory leak.

--- send/sendlib.c.orig 2023-06-25 13:10:50.386174007 +0200
+++ send/sendlib.c 2023-06-25 14:38:38.024274450 +0200
@@ -1746,8 +1746,8 @@

 done:
   m_fcc->append = old_append;
- if (m_fcc->flags == MB_HIDDEN)
- mailbox_free(&m_fcc);
+ //if (m_fcc->flags == MB_HIDDEN)
+ // mailbox_free(&m_fcc);

 #ifdef RECORD_FOLDER_HOOK
   /* We ran a folder hook for the destination mailbox,

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.