dm-writeboost-dkms FTBS with linux 6.2 in Jammy

[Andrea Righi]

[Impact]

/var/lib/dkms/dm-writeboost/2.2.13/build/dm-writeboost.h:506:46: error: ‘struct dm_io_request’ has no member named ‘bi_op’; did you mean ‘bi_opf’?
  506 | #define req_is_write(req) op_is_write((req)->bi_op)
      | ^~~~~
./include/linux/printk.h:429:33: note: in expansion of macro ‘req_is_write’

[Test case]

$ sudo apt install dm-writeboost-dkms

With the fix applied:

 - hwe kernel 6.2:

Building for 6.2.0-25-generic
Building initial module for 6.2.0-25-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

dm-writeboost.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.2.0-25-generic/updates/dkms/

 - release kernel 5.15:

Building for 5.15.0-77-generic
Building initial module for 5.15.0-77-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

dm-writeboost.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-77-generic/updates/dkms/

[Fix]

Backport patches from 6.2 in Lunar to properly support the new kernel ABI.

[Regression potential]

We may experience regressions in systems that are using the dm-writeboost module.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: dm-writeboost-dkms 2.2.13-1ubuntu2
ProcVersionSignature: User Name 6.2.0-23.23~22.04.1-generic 6.2.12
Uname: Linux 6.2.0-23-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
Date: Thu Jun 8 13:23:35 2023
PackageArchitecture: all
SourcePackage: dm-writeboost
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

debdiff to support linux 6.2 in jammy.

[Timo Aaltonen (tjaalton)]

Hello Andrea, or anyone else affected,

Accepted dm-writeboost into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dm-writeboost/2.2.13-1ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andrea Righi (arighi)]

Verified in jammy and test plan updated with results both for the release kernel and the new hwe kernel 6.2.

[Andreas Hasenack (ahasenack)]

Hello Andrea,

I know this SRU has alread been accepted, but I was wondering what's the scenario where jammy would be running a 6.2 kernel? I checked and the current HWE kernel for jammy is 5.19, and dm-writeboost-dkms builds fine with it, as far as I can see, as well as with the released 5.15 kernel:

$ ls -la /lib/modules/*/updates/dkms/dm-writeboost.ko
-rw-r--r-- 1 root root 85964 Jul 6 19:21 /lib/modules/5.15.0-76-generic/updates/dkms/dm-writeboost.ko
-rw-r--r-- 1 root root 87676 Jul 6 19:21 /lib/modules/5.19.0-46-generic/updates/dkms/dm-writeboost.ko

This with dm-writeboost-dkms 2.2.13-1ubuntu2

[Andreas Hasenack (ahasenack)]

And could you please make a statement regarding kinetic, if it was skipped on purpose?

[Łukasz Zemczak (sil2100)]

Andreas, with the next point release we will be bumping the HWE kernel again to the latest released version, so the dkms packages need to be 'prepared' for such a switch once again.

[Launchpad Janitor (janitor)]

This bug was fixed in the package dm-writeboost - 2.2.13-1ubuntu3

---------------
dm-writeboost (2.2.13-1ubuntu3) jammy; urgency=medium

  * Support Linux 6.2 (LP: #2023295)
    - debian/patches/0003-Linux-6.0-support-new-dm_io_request-bi_opf.patch

 -- Andrea Righi <email address hidden> Thu, 08 Jun 2023 13:21:53 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for dm-writeboost has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.