ddcci-dkms FTBS with linux 6.2 in Jammy

[Andrea Righi]

[Impact]

ddcci-dkms fails to build on linux 6.2 with the following error:

 CC [M] /var/lib/dkms/ddcci/0.4.1/build/ddcci/ddcci.o
/var/lib/dkms/ddcci/0.4.1/build/ddcci/ddcci.c:1813:27: error: initialization of ‘void (*)(struct i2c_client *)’ from incompatible pointer type ‘int (*)(struct i2c_client *)’ [-Werror=incompatible-pointer-types]
 1813 | .remove = ddcci_remove,
      | ^~~~~~~~~~~~
/var/lib/dkms/ddcci/0.4.1/build/ddcci/ddcci.c:1813:27: note: (near initialization for ‘ddcci_driver.remove’)
cc1: some warnings being treated as errors

[Test case]

$ sudo apt install ddcci-dkms

With the fix applied:

 - release kernel 5.15:

Building for 5.15.0-77-generic
Building initial module for 5.15.0-77-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

ddcci.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-77-generic/updates/dkms/
...

 - hwe kernel 6.2:

Building for 6.2.0-25-generic
Building initial module for 6.2.0-25-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

ddcci.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.2.0-25-generic/updates/dkms/
...

[Fix]

Backport fixes for 6.2 kernel from Lunar.

[Regression potential]

We may experience regressions with older kernels that are using ddcci-dkms.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: ddcci-dkms 0.4.1-3ubuntu1
ProcVersionSignature: User Name 6.2.0-23.23~22.04.1-generic 6.2.12
Uname: Linux 6.2.0-23-generic x86_64
NonfreeKernelModules: wl
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
Date: Thu Jun 8 12:48:51 2023
PackageArchitecture: all
SourcePackage: ddcci-driver-linux
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

debdiff to support linux-6.2 in Jammy.

[Timo Aaltonen (tjaalton)]

Hello Andrea, or anyone else affected,

Accepted ddcci-driver-linux into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ddcci-driver-linux/0.4.1-3ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andrea Righi (arighi)]

Verified in jammy, test plan updated with results both for the release kernel and the new hwe kernel.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ddcci-driver-linux - 0.4.1-3ubuntu2

---------------
ddcci-driver-linux (0.4.1-3ubuntu2) jammy; urgency=medium

  * Support Linux 6.2 (LP: #2023293):
    - debian/patches/skip-if-no-config-i2c.patch
    - debian/patches/linux-6.1.patch

 -- Andrea Righi <email address hidden> Thu, 08 Jun 2023 12:47:03 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for ddcci-driver-linux has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.