tzdata 2023c-0ubuntu0.22.04.1 might have some inconsistency

[Daniel Nöh]

[ Impact ]

Recent updates have been using `PACKRATDATA=backzone` in order to add all out-of-scope lower-quality pre-1970 data back that existed in earlier tzadata releases (see bug #2003797). However it also leads to time zones like America/Ensenada, Atlantic/Jan_Mayen, Europe/Tiraspol, and Pacific/Enderbury to change:

compared to 2023c-0ubuntu0.22.04.0
- America/Ensenada->only dst changes until 2022 are shown
- Atlantic/Jan_Mayen->now valid data is shown
- Europe/Tiraspol->only dst changes until 2010 are shown

[ Test Plan ]

Add an autopkgtest test case for post-1970 symlink consistency: Check that the timezones for today and in half a year (= to cover DST changes) do not change compared to building them without `PACKRATDATA=backzone`.

The mentioned timezones that differed can also be tested manually. Running following commands should have the same output (the output mentioned here is from tzdata 2023c-0ubuntu0.22.04.0):

```
$ TZ=America/Ensenada date -d "2023-04-28 13:49 Z"
Fri Apr 28 06:49:00 PDT 2023
$ TZ=Atlantic/Jan_Mayen date -d "2023-04-28 13:49 Z"
Fri Apr 28 15:49:00 CEST 2023
$ TZ=Europe/Tiraspol date -d "2023-04-28 13:49 Z"
Fri Apr 28 16:49:00 EEST 2023
```

[ Where problems could occur ]

Timezone data could be wrong. Systems with incorrect timezone set may observe unexpected time shift when updating the package.

[Daniel Nöh (wodn)]

this is a new bug as requested in https://bugs.launchpad.net/ubuntu/+source/tzdata/+bug/2017982

[Benjamin Drung (bdrung)]

Can you document what these zones should use?

[Daniel Nöh (wodn)]

here the expected values:
- America/Ensenada->has also dst changes in 2023, 2023-03-12 from UTC-8 to UTC-7
- Atlantic/Jan_Mayen->has a lot of dst changes over the years, f.e. 2023-03-26 from UTC+1 to UTC+2
- Europe/Tiraspol->has also dst changes in 2023, 2023-03-26 from UTC+2 to UTC+3

[Benjamin Drung (bdrung)]

Wrote attached test case to catch the inconsistencies (patch attached) and forwarded to upstream: https://mm.icann.org/pipermail/tz/2023-May/032937.html

[Benjamin Drung (bdrung)]

The test_all_timezones_count test case for python-tz needs an update for Ubuntu >= 23.04 (lunar and mantic). python-tz debdiff for lunar attached.

[Launchpad Janitor (janitor)]

This bug was fixed in the package tzdata - 2023c-4exp1ubuntu1

---------------
tzdata (2023c-4exp1ubuntu1) mantic; urgency=medium

  * Merge with Debian experimental. Remaining changes:
    - Ship 2023c ICU timezone data which are utilized by PHP in tzdata-icu
    - Add autopkgtest test case for ICU timezone data
    - Do not rename NEWS into changelog.gz, this fixes a build failure on
      moment-timezone.js
    - Point Vcs-Browser/Git to Launchpad
    - generate_debconf_templates: Work around AttributeError on icu import

tzdata (2023c-4exp1) experimental; urgency=medium

  * Drop /usr/share/zoneinfo/posix (identical to /usr/share/zoneinfo)
    (LP: #2008076)
  * Split right/* timezones into separate tzdata-legacy package (LP: #2008076)
  * Drop providing tzdata-bookworm from tzdata

tzdata (2023c-4) unstable; urgency=medium

  * Sort timezones naturally in debconf
  * Add explanation for plus/minus used by Etc/GMT timezones
    (Closes: #540305, LP: #1325949)
  * Build tzdata with PACKRATLIST=zone.tab. In combination with
    PACKRATDATA=backzone (which is used since 2022g-3), time zones that differ
    pre-1970 and had been resurrected will not incur changes to data from 1970
    on. This also removes Asia/Hanoi again. (LP: #2017999)
  * Update Croatian debconf translation. Thanks to Tomislav Krznar.

tzdata (2023c-3) unstable; urgency=medium

  * test_timezone_conversions: Print all failures before failing
  * Add Romanian debconf translation. Thanks to Remus-Gabriel Chelu
    (Closes: #1034094)
  * Add Language metadata to all debconf translation files
  * Convert Pacific/Ponape to Pacific/Pohnpei on upgrade
  * Convert Asia/Ujung_Pandang to Asia/Makassar on upgrade
  * Convert Pacific/Truk to Pacific/Chuuk on upgrade
  * Fix or drop wrong translations
  * Check debconf translation files for inconsistencies
  * Fix German translation of Christmas and Easter Island

 -- Benjamin Drung <email address hidden> Wed, 10 May 2023 00:26:05 +0200

[Timo Aaltonen (tjaalton)]

Hello Daniel, or anyone else affected,

Accepted python-tz into lunar-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-tz/2022.7.1-3ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-lunar to verification-done-lunar. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-lunar. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Benjamin Drung (bdrung)]

tzdata 2023c-2exp1ubuntu1.1 debdiff for lunar.

[Benjamin Drung (bdrung)]

tzdata 2023c-0ubuntu0.22.10.2 debdiff for kinetic.

[Benjamin Drung (bdrung)]

tzdata 2023c-0ubuntu0.22.04.2 debdiff for jammy.

[Benjamin Drung (bdrung)]

tzdata 2023c-0ubuntu0.20.04.2 debdiff for focal.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted python-tz (2022.7.1-3ubuntu0.1) for lunar have finished running.
The following regressions have been reported in tests triggered by the package:

cinder/2:22.0.0-0ubuntu1.1 (armhf)
ironic/1:21.4.0-0ubuntu1 (armhf)
python-caldav/0.11.0-1 (arm64)
senlin/1:15.0.0-0ubuntu1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/lunar/update_excuses.html#python-tz

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Robie Basak (racb)]

This upload proposes to remove some of the options in debian/tzdata.templates. So what happens if a user has configured deployment automation to use particular debconf options that will now disappear? The changelog says "It removes following time zones from debconf and updates them on upgrades again" but what about the reproducibility of previous behaviour on redeployments?

This would apply to:

America/
  Argentina/ComodRivadavia
  Rosario
Asia/
  Hanoi
Europe/
  Uzhgorod
  Zaporozhye
Pacific/
  Enderbury

[Benjamin Drung (bdrung)]

Thanks for the review. I tested what happens if a debconf answer is provided that will be removed by the update:

```
$ printf "tzdata tzdata/Areas select Europe\ntzdata tzdata/Zones/Europe select Uzhgorod\n" | debconf-set-selections
$ DEBIAN_FRONTEND=noninteractive apt install ./tzdata_2023c-0ubuntu0.20.04.2_all.deb
[...]
Current default time zone: 'Europe/Amsterdam'
```

So it will select the first entry of that area instead. So we need to keep all debconf options. I'll prepare a new set of debdiffs.

[Steve Langasek (vorlon)]

Hello Daniel, or anyone else affected,

Accepted tzdata into lunar-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023c-2exp1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-lunar to verification-done-lunar. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-lunar. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Steve Langasek (vorlon)]

An upload of tzdata to jammy-proposed has been rejected from the upload queue for the following reason: "missing the fix for debconf preseed handling".

[Steve Langasek (vorlon)]

An upload of tzdata to kinetic-proposed has been rejected from the upload queue for the following reason: "missing the fix for debconf preseed handling".

[Steve Langasek (vorlon)]

Hello Daniel, or anyone else affected,

Accepted tzdata into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023c-0ubuntu0.22.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Steve Langasek (vorlon)]

Hello Daniel, or anyone else affected,

Accepted tzdata into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023c-0ubuntu0.22.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Steve Langasek (vorlon)]

Hello Daniel, or anyone else affected,

Accepted tzdata into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023c-0ubuntu0.20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted tzdata (2023c-2exp1ubuntu1.1) for lunar have finished running.
The following regressions have been reported in tests triggered by the package:

chrony/4.3-1ubuntu4 (armhf)
python-tz/2022.7.1-3 (amd64, arm64, armhf, ppc64el, s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/lunar/update_excuses.html#tzdata

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted tzdata (2023c-0ubuntu0.20.04.2) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

postgresql-12/12.14-0ubuntu0.20.04.1 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#tzdata

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Benjamin Drung (bdrung)]

Verified lunar SRU: The autopkgtest runs for 2023c-2exp1ubuntu1.1 succeeded. The manual test were successful as well:

```
$ schroot-wrapper -p tzdata -e -c lunar
(lunar)bdrung@host:~$ TZ=America/Ensenada date -d "2023-04-28 13:49 Z"
Fri Apr 28 06:49:00 PDT 2023
(lunar)bdrung@host:~$ TZ=Atlantic/Jan_Mayen date -d "2023-04-28 13:49 Z"
Fri Apr 28 15:49:00 CEST 2023
(lunar)bdrung@host:~$ TZ=Europe/Tiraspol date -d "2023-04-28 13:49 Z"
Fri Apr 28 16:49:00 EEST 2023
(lunar)bdrung@host:~$ dpkg -s tzdata | grep Version
Version: 2023c-2exp1ubuntu1.1
```

[Benjamin Drung (bdrung)]

Verified kinetic SRU: The autopkgtest runs for 2023c-0ubuntu0.22.10.2 succeeded. The manual test were successful as well:

```
$ schroot-wrapper -p tzdata -e -c kinetic
(kinetic)bdrung@host:~$ dpkg -s tzdata | grep Version
Version: 2023c-0ubuntu0.22.10.2
(kinetic)bdrung@host:~$ TZ=America/Ensenada date -d "2023-04-28 13:49 Z"
Fri Apr 28 06:49:00 PDT 2023
(kinetic)bdrung@host:~$ TZ=Atlantic/Jan_Mayen date -d "2023-04-28 13:49 Z"
Fri Apr 28 15:49:00 CEST 2023
(kinetic)bdrung@host:~$ TZ=Europe/Tiraspol date -d "2023-04-28 13:49 Z"
Fri Apr 28 16:49:00 EEST 2023
```

[Benjamin Drung (bdrung)]

Verified jammy SRU: The autopkgtest runs for 2023c-0ubuntu0.22.04.2 succeeded. The manual test were successful as well:

```
$ schroot-wrapper -p tzdata -e -c jammy
(jammy)bdrung@host:~$ dpkg -s tzdata | grep Version
Version: 2023c-0ubuntu0.22.04.2
(jammy)bdrung@host:~$ TZ=America/Ensenada date -d "2023-04-28 13:49 Z"
Fri Apr 28 06:49:00 PDT 2023
(jammy)bdrung@host:~$ TZ=Atlantic/Jan_Mayen date -d "2023-04-28 13:49 Z"
Fri Apr 28 15:49:00 CEST 2023
(jammy)bdrung@host:~$ TZ=Europe/Tiraspol date -d "2023-04-28 13:49 Z"
Fri Apr 28 16:49:00 EEST 2023
```

[Benjamin Drung (bdrung)]

Verified focal SRU: The autopkgtest runs for 2023c-0ubuntu0.20.04.2 succeeded. The manual test were successful as well:

```
$ schroot-wrapper -p tzdata -e -c focal
(focal)bdrung@host:~$ dpkg -s tzdata | grep Version
Version: 2023c-0ubuntu0.20.04.2
(focal)bdrung@host:~$ TZ=America/Ensenada date -d "2023-04-28 13:49 Z"
Fri Apr 28 06:49:00 PDT 2023
(focal)bdrung@host:~$ TZ=Atlantic/Jan_Mayen date -d "2023-04-28 13:49 Z"
Fri Apr 28 15:49:00 CEST 2023
(focal)bdrung@host:~$ TZ=Europe/Tiraspol date -d "2023-04-28 13:49 Z"
Fri Apr 28 16:49:00 EEST 2023
```

[Benjamin Drung (bdrung)]

Regarding the failing autopkgtest:

* python-tz on lunar:
  - cinder/2:22.0.0-0ubuntu1.1, ironic/1:21.4.0-0ubuntu1, and senlin/1:15.0.0-0ubuntu1 fail on armhf due to an installation issue of mysql (probably bug #1980466)
  - python-caldav/0.11.0-1 on armhf: not investigated yet
* tzdata on focal:
  - postgresql-12/12.14-0ubuntu0.20.04.1 on amd64: not investigated yet
* tzdata on lunar:
  - chrony/4.3-1ubuntu4 on armhf: Flaky test case (see bug #2002910)
  - python-tz/2022.7.1-3: fixed by python-tz/2022.7.1-3ubuntu0.1

[Benjamin Drung (bdrung)]

Looking at the autopkgtest, several of the failing ones got resolved (e.g. all for python-tz on lunar). Remaining failing ones:

* tzdata on lunar:
  - chrony/4.3-1ubuntu4 on armhf: Flaky test case (see bug #2002910)
* tzdata on focal:
  - postgresql-12/12.14-0ubuntu0.20.04.1 on amd64: test 8 of 180_ecpg.t

[Benjamin Drung (bdrung)]

I saw nothing specific to tzdata in 180_ecpg.t. I tried 180_ecpg.t from postgresql-12 locally and it succeeded. Then I retried the autopkgtest and it succeeded as well. So all autopkgtest issues are resolved now.

[Launchpad Janitor (janitor)]

This bug was fixed in the package tzdata - 2023c-2exp1ubuntu1.1

---------------
tzdata (2023c-2exp1ubuntu1.1) lunar; urgency=medium

  * Build tzdata with PACKRATLIST=zone.tab. In combination with
    PACKRATDATA=backzone (which is used since 2022g-3), time zones that differ
    pre-1970 and had been resurrected will not incur changes to data from 1970
    on. (LP: #2017999) This also removes Asia/Hanoi again.
  * Add an autopkgtest test case for post-1970 symlink consistency
  * Update debconf template and translations

 -- Benjamin Drung <email address hidden> Fri, 19 May 2023 12:05:31 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for tzdata has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package tzdata - 2023c-0ubuntu0.22.10.2

---------------
tzdata (2023c-0ubuntu0.22.10.2) kinetic; urgency=medium

  * Build tzdata with PACKRATLIST=zone.tab. In combination with
    PACKRATDATA=backzone (which is used since 2023c-0ubuntu0.22.10.1), time
    zones that differ pre-1970 and had been resurrected will not incur changes
    to data from 1970 on. This also removes Asia/Hanoi again. Upgrade
    Pacific/Enderbury to Pacific/Kanton again. (LP: #2017999)
  * Add an autopkgtest test case for post-1970 symlink consistency
  * Update debconf template and translations

 -- Benjamin Drung <email address hidden> Sat, 20 May 2023 01:17:08 +0200

[Launchpad Janitor (janitor)]

This bug was fixed in the package tzdata - 2023c-0ubuntu0.22.04.2

---------------
tzdata (2023c-0ubuntu0.22.04.2) jammy; urgency=medium

  * Build tzdata with PACKRATLIST=zone.tab. In combination with
    PACKRATDATA=backzone (which is used since 2023c-0ubuntu0.22.04.1), time
    zones that differ pre-1970 and had been resurrected will not incur changes
    to data from 1970 on. This also removes Asia/Hanoi again. Upgrade
    Pacific/Enderbury to Pacific/Kanton again. (LP: #2017999)
  * Add an autopkgtest test case for post-1970 symlink consistency
  * Update debconf template and translations

 -- Benjamin Drung <email address hidden> Sat, 20 May 2023 01:26:56 +0200

[Launchpad Janitor (janitor)]

This bug was fixed in the package tzdata - 2023c-0ubuntu0.20.04.2

---------------
tzdata (2023c-0ubuntu0.20.04.2) focal; urgency=medium

  * Build tzdata with PACKRATLIST=zone.tab. In combination with
    PACKRATDATA=backzone (which is used since 2023c-0ubuntu0.20.04.1), time
    zones that differ pre-1970 and had been resurrected will not incur changes
    to data from 1970 on. This also removes Asia/Hanoi again. (LP: #2017999)
  * Add an autopkgtest test case for post-1970 symlink consistency
  * Update debconf template and translations

 -- Benjamin Drung <email address hidden> Sat, 20 May 2023 01:32:19 +0200

[Brian Murray (brian-murray)]

Given that python-tz is just a test update I think we should leave that in -proposed and tag this bug block-proposed-lunar.