Impossible to mark as needing review strings already translated or with suggestions
Bug #201749 reported by
Milo Casagrande
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Adi Roiban |
Bug Description
While using edge server and reviewing translations, if I mark as "Someone should review this translation" an already approved translation, this one will not be marked as needing review. This happens also with strings with suggestions from non-approved members: i can't mark them as need-review.
Related branches
lp:~adiroiban/launchpad/bug-201749
Merged
into
lp:launchpad
- Henning Eggers (community): Approve (code)
-
Diff: 926 lines (+608/-86)11 files modifiedlib/canonical/launchpad/javascript/translations/pofile.js (+119/-18)
lib/lp/translations/browser/tests/translationmessage-views.txt (+98/-0)
lib/lp/translations/browser/translationmessage.py (+17/-0)
lib/lp/translations/interfaces/potmsgset.py (+12/-0)
lib/lp/translations/model/potmsgset.py (+41/-13)
lib/lp/translations/model/translationmessage.py (+2/-2)
lib/lp/translations/stories/standalone/xx-pofile-translate-needs-review-flags-preserved.txt (+62/-3)
lib/lp/translations/templates/pofile-translate.pt (+1/-27)
lib/lp/translations/templates/translationmessage-translate.pt (+1/-19)
lib/lp/translations/tests/test_potmsgset.py (+83/-0)
lib/lp/translations/windmill/tests/test_pofile_translate.py (+172/-4)
Changed in rosetta: | |
assignee: | nobody → Adi Roiban (adiroiban) |
tags: | added: story-translations-review ui |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in rosetta: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Can you please elaborate. At the moment, we have quite a confusing situation with need-review, new-suggestions and fuzzy terminology. I want to fix that, but I just need to know exactly where do you see it as not being marked as need-review when you mark it as such (so I can tell if this is the same problem, or some new problem).
Thanks