virt-clone does not clone

[Kees Cook]

$ virt-clone -d -o '64bit-Ubuntu-8.04-desktop-SELinux' --connect qemu:///system --file /vmware/64bit-Ubuntu-8.04-desktop/64bit-Ubuntu-8.04-desktop-SELinux.kvm --name '64bit-Ubuntu-8.04-desktop-SELinux'
Wed, 12 Mar 2008 15:01:05 DEBUG start clone with HV qemu:///system
Wed, 12 Mar 2008 15:01:05 DEBUG clone device list: ['/vmware/64bit-Ubuntu-8.04-desktop/64bit-Ubuntu-8.04-desktop-SELinux.kvm']
Wed, 12 Mar 2008 15:01:05 DEBUG clone device size: [0]
Wed, 12 Mar 2008 15:01:05 DEBUG clone device type: [True]
Wed, 12 Mar 2008 15:01:05 DEBUG Disk path not found: Assuming file disk type.
ERROR: Disk size must be an int or a float (is <type 'list'>).
What would you like to use as the disk (path)?
Traceback (most recent call last):
  File "/usr/bin/virt-clone", line 186, in <module>
    main()
  File "/usr/bin/virt-clone", line 165, in main
    get_clone_diskfile(options.new_diskfile, design)
  File "/usr/bin/virt-clone", line 78, in get_clone_diskfile
    design.set_clone_devices(i)
  File "/usr/lib/python2.5/site-packages/virtinst/CloneManager.py", line 116, in set_clone_devices
    devices = self._check_file(self._hyper_conn, devices, cdev_size)
  File "/usr/lib/python2.5/site-packages/virtinst/CloneManager.py", line 341, in _check_file
    disk = cli.prompt_for_input(msg, disk)
  File "/usr/lib/python2.5/site-packages/virtinst/cli.py", line 85, in prompt_for_input
    return sys.stdin.readline().strip()
KeyboardInterrupt

Attached patch seems to fix the behavior.

[Kees Cook (kees)]

Since virt-clone is not usable for multiple people, and this patch solves that, we should get it uploaded for Hardy.

[Launchpad Janitor (janitor)]

This bug was fixed in the package virtinst - 0.300.2-0ubuntu3

---------------
virtinst (0.300.2-0ubuntu3) hardy; urgency=low

  * debian/patches/10_virt-clone-devices.patch: fix logic error in
    virt-clone (LP: #201603).

 -- Kees Cook <email address hidden> Sun, 23 Mar 2008 22:22:23 -0700