motd: can't disable esm-related messages

[Grant Orndorff]

[ Impact ]

If ESM Infra/Apps is available for a system, users will always see messages related to those Ubuntu Pro services in their MOTDs. As stated in the original description, there have been complaints on how hard it is to disable those messages - we have users who don't want Pro and don't want to be reminded of Pro all the time.

The fix here is making it easier for people to disable the ESM related messages in the update-related MOTD, by giving them a way to opt-out. Users will have the option to create the /var/lib/ubuntu-advantage/hide-esm-in-motd marker file, causing the /usr/lib/update-notifier/update-motd-updates-available script to include a --no-esm-messages flag when generating the outputs.

This file is the same file used in the Pro Client to suppress those messages.

[ Test Plan ]

Compare the messages before and after installing the new version of the package, and make sure they are exactly the same in different scenarios:
- ESM status: unavailable, disabled, enabled
- LTS system: yes or no
- updates available: yes or no

Thankfully, the unit test suite in tests/test_motd.py covers all of those scenarios functionality-wise. Manual checks on real systems may endorse the functionality.

New tests were added to the suite making sure the flag hides the ESM related messages when it is present.

On real systems, creating the /var/lib/ubuntu-advantage/hide-esm-in-motd marker file and making sure to update the MOTDs should remove ESM related messages for the same scenarios above.

The execution of the script relies on running one of a couple trigger hooks set in the apt configuration. Running `apt update` will trigger one of them. To make sure messages will be updated, the /var/lib/update-notifier/updates-available stamp file can be removed before the update. (The alternative would be running manually with --force, but that is slightly worse for acceptance testing)

[ Where problems could occur ]

- Other software may be relying on the apt-check script to generate human-readable messages. A mistake here could intefere with the message generated, changing expectation on stable releases, or causing errors. To mitigate that, the standard behavior is exactly the same if the marker file is absent, and all existing functionality is preserved.

- Users may make mistakes when creating the marker file. We will mitigate that by having comprehensible documentation with a clear explanation of what the flag does and where to put it. The worst that can happen is that users create a useless file, and no change happens.

[ Other Info ]

As opposed to what was in the original description, the proposed changeset does not separate esm messages from the regular updates messages - this ensures current users and potential callers get exactly the same result when checking their outputs after the change lands.

As suggested in the original description, we understand that it is not the easiest and straightforward approach create a specific file when compared to running a command or clicking a button. However, the messages are there for a product decision, and it is a product decision not to have a "too easy opt-out". On the other hand, users who want to disable this are capable of creating the file, and it will be way easier for them than making the changes in the python script itself - plus the configuration is kept between upgrades.

As noted in a subsequent comment, the patch fixing this bug introduces a new help message. The translations of update-notifier are shipped together with the package. Consulting with @enr0n, the decision about this new entry is:

- For the Noble version, @enr0n will add this new line to the pot file, so it can be translated for the future releases.
- For the SRUs, we will let it be as is. The main two reasons are:

  1. there is low value in translating this string to the couple languages we know, and new translations would require a new SRU in the future - except in special cases, there are no translations done in SRUs anyway

  2. there is low exposure of the string - it is not in the consumable output of the command, but rather help text for a command that is niched enough - as also noted, we don't expect all users to be applying this.

[ Original Description ]

See https://github.com/canonical/ubuntu-pro-client/issues/2458 for the origin of the conversation.

We don't think it needs to be _easy_, but it should probably be less burdensome to disable ESM update notifications in MOTD without disabling all update notifications in MOTD.

One idea to accomplish this is to separate the /etc/update-motd.d/ files into two. One would print the normal update message, and the other would print the ESM message. Then, if an admin knows what they're doing and is willing to accept the risk, they can remove or edit the ESM update-notifier motd conffile. This is similar to how you can remove the APT ESM messages by removing/editing /etc/apt/apt.conf.d/20apt-esm-hook.conf if you know what you're doing.

This would also require some changes to how the messages are created, since currently it is all in apt_check.py and printed into a single message file. They'll need to be separated somehow.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[martinr (martinr1111)]

Even when ESM is not enabled and there are no ESM updates pending. ESM evangelisation will still be displayed at logon.
Here is a copy of such messages that keep appearing at each logon (as appearing in Ubuntu Server 22.04.2 LTS (GNU/Linux 5.15.0-1026-raspi armv7l)):

    Expanded Security Maintenance for Applications is not enabled.

    Enable ESM Apps to receive additional future security updates.
    See https://ubuntu.com/esm or run: sudo pro status

The messages take up screen real-estate and become more annoying and less informative every time they are repeated. To get to the real MOTD content people need to scroll back at every logon.

The problem is that the messages can't be configured off without also loosing pending updates information.

The messages are not emitted through the normal MOTD processing (update-motd).
They are generated by update-notifier and cached in:
"/var/lib/update-notifier/updates-available"
by Python script:
/usr/lib/update-notifier/apt_check.py

[xenago (xenago)]

I concur with martinr and am experiencing this issue on all 22.04 systems. ESM content appears in the terminal on login with all available esm/advantage-related stuff disabled. I can also confirm that it is possible to bypass them by editing the aforementioned python script, but that is not a proper solution as it is not standardized/durable/maintainable...

This should definitely be split out into a separate .conf to enable proper configuration of esm messages.

[Scott Moore (scottbomb)]

Odd... I deleted /usr/lib/update-notifier/apt_check.py and still get this msg. Of course I've tried everything else I've found on the internet so far.

[Michael (wattersm)]

There needs to be a simpler way to disable these messages. Having to run sed commands on a 435 line python script should not be necessary. This solution is not scalable when it needs to be applied on hundreds of desktops.

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-notifier - 3.192.67

---------------
update-notifier (3.192.67) noble; urgency=medium

  * apt-check: add option to hide ESM messages from the human readable output.
    (LP: #2015420)

 -- Renan Rodrigo Barbosa <email address hidden> Wed, 31 Jan 2024 11:40:02 -0300

[Andreas Hasenack (ahasenack)]

Please clarify the test case regarding what has to be done to get rid of the ESM messages in MOTD. Show the change, where, then the commands, and expected output.

It says:
"""
On real systems, adding --no-esm-messages to the conf script and making sure it updates the MOTDs should remove ESM related messages for the same scenarios above.
"""

Please clarify what conf script, which line, which position, etc. Those files are sensitive to syntax, and a mistake there could break things. I don't even recall us ever handing out instructions like these in the past, where we direct users to edit system configuration files by hand.

There is also:
"""
The flag should be added according to what is described in https://github.com/canonical/ubuntu-pro-client/blob/docs-devel/docs/explanations/motd_messages.md#source-motd-about-available-updates
"""

I rather have it described in the bug, instead of a file in git that might disappear or change in the (near) future. Users interested in this feature will follow the bug link and arrive here, and the test case should be clear enough to show how to make the change, if wanted, safely.

[Andreas Hasenack (ahasenack)]

This is adding a new translatable string, could you please document that in the SRU template, perhaps "other info"?
I don't suppose you will add a translation to this new string? Or update the pot (template) file?

[Renan Rodrigo (renanrodrigo)]

@ahasenack
Thanks for your review and comments.

I have updated the bug description with more detailed information on what to change and where to perform the testing, and also with the decision @enr0n and I took about the translations.

> I don't even recall us ever handing out instructions like these in the past, where we direct users to edit system configuration files by hand.

You are correct - we usually don't do that, but this is a change we only expect people to make if they understand what they are doing, and most of the users won't even bother with it.

[Andreas Hasenack (ahasenack)]

Hello Grant, or anyone else affected,

Accepted update-notifier into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.54.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andreas Hasenack (ahasenack)]

Hello Grant, or anyone else affected,

Accepted update-notifier into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.30.18 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andreas Hasenack (ahasenack)]

Hello Grant, or anyone else affected,

Accepted update-notifier into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.1.20 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andreas Hasenack (ahasenack)]

Hello Grant, or anyone else affected,

Accepted update-notifier into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.168.21 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Renan Rodrigo (renanrodrigo)]

Due to a double brackets expression in the /usr/lib/update-notifier/update-motd-updates-available file in the patch, the script cannot be run by `sh` (which is the interpreter used, as noted in the #! in the start...)

I am marking verification failed for all releases.

I will put up another upload soon, with single brackets instead, so this can be properly tested.

[Renan Rodrigo (renanrodrigo)]

Linked new merge proposals with a different approach to the problem - checking for a marker file instead of passing an option in a conf script - and updated the description to match the new approach.

[Brian Murray (brian-murray)]

Hello Grant, or anyone else affected,

Accepted update-notifier into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.54.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Grant, or anyone else affected,

Accepted update-notifier into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.30.19 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Grant, or anyone else affected,

Accepted update-notifier into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.1.21 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Grant, or anyone else affected,

Accepted update-notifier into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.168.22 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Renan Rodrigo (renanrodrigo)]

To verify there are no regressions in messages, and that the new option in apt-check works as intended, I have executed the unit test suite for all releases, as it covers the message generation for an exhaustive amount of cases.

On Xenial and Bionic I had to add the data/ folder to the pythonpath, so it could import apt_check and run the unit tests.

On those releases, one unit test is failed. But the test also fails for the version without the patch that fixes this bug, so the behavior is kept. This error probably happens because the test misses a mock to is_esm, which is returning True for Xenial and Bionic. This is a bug.
New tests pass for both releases.

On Jammy:
root@jammy-sut:~# python3 update-notifier-3.192.54.6/tests/test_motd.py
.............................
----------------------------------------------------------------------
Ran 29 tests in 0.021s

OK
root@jammy-sut:~# python3 update-notifier-3.192.54.8/tests/test_motd.py
..................................
----------------------------------------------------------------------
Ran 34 tests in 0.023s

OK

On Focal:
root@focal-sut:~# python3 update-notifier-3.192.30.17/tests/test_motd.py
...............................
----------------------------------------------------------------------
Ran 31 tests in 0.051s

OK
root@focal-sut:~# python3 update-notifier-3.192.30.19/tests/test_motd.py
....................................
----------------------------------------------------------------------
Ran 36 tests in 0.029s

OK

On Bionic:
root@bionic-sut:~# python3 update-notifier-3.192.1.19/tests/test_motd.py
....................F..........
======================================================================
FAIL: test_message_for_distro_that_will_not_go_into_esm_mode (__main__.TestMotd)
----------------------------------------------------------------------
(... Traceback details ...)
----------------------------------------------------------------------
Ran 31 tests in 0.020s

FAILED (failures=1)
root@bionic-sut:~# python3 update-notifier-3.192.1.21/tests/test_motd.py
.......................F............
======================================================================
FAIL: test_message_for_distro_that_will_not_go_into_esm_mode (__main__.TestMotd)
----------------------------------------------------------------------
(... Traceback details ...)
----------------------------------------------------------------------
Ran 36 tests in 0.020s

FAILED (failures=1)

on Xenial:
root@xenial-sut:~# python3 update-notifier-3.168.20/tests/test_motd.py
....................F..........
======================================================================
FAIL: test_message_for_distro_that_will_not_go_into_esm_mode (__main__.TestMotd)
----------------------------------------------------------------------
(... Traceback details ...)
----------------------------------------------------------------------
Ran 31 tests in 0.021s

FAILED (failures=1)
root@xenial-sut:~# python3 update-notifier-3.168.22/tests/test_motd.py
.......................F............
======================================================================
FAIL: test_message_for_distro_that_will_not_go_into_esm_mode (__mai...

[Renan Rodrigo (renanrodrigo)]

Now, to the actual functionality test on Xenial:

Xenial is an EOSS release, so messages about esm-infra will be present in MOTD by default.
After creating the marker file and triggering an update of MOTD, those messages disappear, but the updates count remains.

root@xenial-sut:~# apt policy update-notifier-common
update-notifier-common:
  Installed: 3.168.22
  Candidate: 3.168.22
  Version table:
 *** 3.168.22 500
        500 http://archive.ubuntu.com/ubuntu xenial-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     3.168.20 500
        500 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
     3.168.15 500
        500 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
     3.168.7 500
        500 http://security.ubuntu.com/ubuntu xenial-security/main amd64 Packages
     3.168 500
        500 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages
root@xenial-sut:~# run-parts /etc/update-motd.d/
Welcome to Ubuntu 16.04.7 LTS (GNU/Linux 6.5.0-21-generic x86_64)

 * Documentation: https://help.ubuntu.com
 * Management: https://landscape.canonical.com
 * Support: https://ubuntu.com/pro

Expanded Security Maintenance for Infrastructure is not enabled.

9 updates can be applied immediately.
To see these additional updates run: apt list --upgradable

206 additional security updates can be applied with ESM Infra.
Learn more about enabling ESM Infra service for Ubuntu 16.04 at
https://ubuntu.com/16-04

New release '18.04.6 LTS' available.
Run 'do-release-upgrade' to upgrade to it.

root@xenial-sut:~# touch /var/lib/update-notifier/hide-esm-in-motd
root@xenial-sut:~# rm /var/lib/update-notifier/updates-available
root@xenial-sut:~# apt update
Hit:1 http://archive.ubuntu.com/ubuntu xenial InRelease
Hit:2 http://security.ubuntu.com/ubuntu xenial-security InRelease
Hit:3 http://archive.ubuntu.com/ubuntu xenial-updates InRelease
Hit:4 http://archive.ubuntu.com/ubuntu xenial-backports InRelease
Hit:5 http://archive.ubuntu.com/ubuntu xenial-proposed InRelease
Reading package lists... Done
Building dependency tree
Reading state information... Done
6 packages can be upgraded. Run 'apt list --upgradable' to see them.
root@xenial-sut:~# run-parts /etc/update-motd.d/
Welcome to Ubuntu 16.04.7 LTS (GNU/Linux 6.5.0-21-generic x86_64)

 * Documentation: https://help.ubuntu.com
 * Management: https://landscape.canonical.com
 * Support: https://ubuntu.com/pro

9 updates can be applied immediately.
To see these additional updates run: apt list --upgradable

New release '18.04.6 LTS' available.
Run 'do-release-upgrade' to upgrade to it.

I am marking this bug verification-done on Xenial.

[Renan Rodrigo (renanrodrigo)]

Now, to the actual functionality test on Bionic:

Bionic is an EOSS release, so messages about esm-infra will be present in MOTD by default.
After creating the marker file and triggering an update of MOTD, those messages disappear, but the updates count remains.

root@bionic-sut:~# apt policy update-notifier-common
update-notifier-common:
  Installed: 3.192.1.21
  Candidate: 3.192.1.21
  Version table:
 *** 3.192.1.21 500
        500 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     3.192.1.19 500
        500 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
     3.192 500
        500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages
root@bionic-sut:~# run-parts /etc/update-motd.d/
Welcome to Ubuntu 18.04.6 LTS (GNU/Linux 6.5.0-21-generic x86_64)

 * Documentation: https://help.ubuntu.com
 * Management: https://landscape.canonical.com
 * Support: https://ubuntu.com/pro

  System information as of Fri Mar 15 22:51:31 UTC 2024

  System load: 1.72 Processes: 23
  Usage of /home: unknown Users logged in: 0
  Memory usage: 0% IP address for eth0: 10.46.74.128
  Swap usage: 0%

Expanded Security Maintenance for Infrastructure is not enabled.

11 updates can be applied immediately.
To see these additional updates run: apt list --upgradable

94 additional security updates can be applied with ESM Infra.
Learn more about enabling ESM Infra service for Ubuntu 18.04 at
https://ubuntu.com/18-04

New release '20.04.6 LTS' available.
Run 'do-release-upgrade' to upgrade to it.

root@bionic-sut:~# touch /var/lib/update-notifier/hide-esm-in-motd
root@bionic-sut:~# rm /var/lib/update-notifier/updates-available
root@bionic-sut:~# apt update
Hit:1 http://archive.ubuntu.com/ubuntu bionic InRelease
Hit:2 http://security.ubuntu.com/ubuntu bionic-security InRelease
Hit:3 http://archive.ubuntu.com/ubuntu bionic-updates InRelease
Hit:4 http://archive.ubuntu.com/ubuntu bionic-backports InRelease
Hit:5 http://archive.ubuntu.com/ubuntu bionic-proposed InRelease
Reading package lists... Done
Building dependency tree
Reading state information... Done
11 packages can be upgraded. Run 'apt list --upgradable' to see them.
root@bionic-sut:~# run-parts /etc/update-motd.d/
Welcome to Ubuntu 18.04.6 LTS (GNU/Linux 6.5.0-21-generic x86_64)

 * Documentation: https://help.ubuntu.com
 * Management: https://landscape.canonical.com
 * Support: https://ubuntu.com/pro

  System information as of Fri Mar 15 22:52:04 UTC 2024

  System load: 1.58 Processes: 23
  Usage of /home: unknown Users logged in: 0
  Memory usage: 0% IP address for eth0: 10.46.74.128
  Swap usage: 0%

11 updates can be applied immediately.
To see these additional updates run: apt list --upgradable

New release '20.04.6 LTS' available.
Run 'do-release-upgrade' to upgrade to it.

I am marking this bug verification-done on Bionic.

[Renan Rodrigo (renanrodrigo)]

Now, to the actual functionality test on Focal:

Focal is an LTS release still supported, so messages about esm-apps will be present in MOTD by default.
After creating the marker file and triggering an update of MOTD, those messages disappear, but the updates count remains.

root@focal-sut:~# apt policy update-notifier-common
update-notifier-common:
  Installed: 3.192.30.19
  Candidate: 3.192.30.19
  Version table:
 *** 3.192.30.19 500
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     3.192.30.17 500
        500 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
     3.192.30 500
        500 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages
root@focal-sut:~# run-parts /etc/update-motd.d/
Welcome to Ubuntu 20.04.6 LTS (GNU/Linux 6.5.0-21-generic x86_64)

 * Documentation: https://help.ubuntu.com
 * Management: https://landscape.canonical.com
 * Support: https://ubuntu.com/pro

  System information as of Fri Mar 15 22:55:55 UTC 2024

  System load: 1.56
  Usage of /home: unknown
  Memory usage: 0%
  Swap usage: 0%
  Temperature: 86.0 C
  Processes: 30
  Users logged in: 0
  IPv4 address for eth0: 10.46.74.13
  IPv6 address for eth0: fd42:f539:1893:d366:216:3eff:fe2a:1d97

 * Strictly confined Kubernetes makes edge and IoT secure. Learn how MicroK8s
   just raised the bar for easy, resilient and secure K8s cluster deployment.

   https://ubuntu.com/engage/secure-kubernetes-at-the-edge

Expanded Security Maintenance for Applications is not enabled.

17 updates can be applied immediately.
To see these additional updates run: apt list --upgradable

Enable ESM Apps to receive additional future security updates.
See https://ubuntu.com/esm or run: sudo pro status

New release '22.04.3 LTS' available.
Run 'do-release-upgrade' to upgrade to it.

root@focal-sut:~# touch /var/lib/update-notifier/hide-esm-in-motd
root@focal-sut:~# rm /var/lib/update-notifier/updates-available
root@focal-sut:~# apt update
Hit:1 http://archive.ubuntu.com/ubuntu focal InRelease
Hit:2 http://security.ubuntu.com/ubuntu focal-security InRelease
Hit:3 http://archive.ubuntu.com/ubuntu focal-updates InRelease
Hit:4 http://archive.ubuntu.com/ubuntu focal-backports InRelease
Hit:5 http://archive.ubuntu.com/ubuntu focal-proposed InRelease
Reading package lists... Done
Building dependency tree
Reading state information... Done
17 packages can be upgraded. Run 'apt list --upgradable' to see them.
root@focal-sut:~# run-parts /etc/update-motd.d/
Welcome to Ubuntu 20.04.6 LTS (GNU/Linux 6.5.0-21-generic x86_64)

 * Documentation: https://help.ubuntu.com
 * Management: https://landscape.canonical.com
 * Support: https://ubuntu.com/pro

  System information as of Fri Mar 15 22:56:49 UTC 2024

  System load: 1.86
  Usage of /home: unknown
  Memory usage: 0%
  Swap usage: 0%
  Temperature: 76.0 C
  Processes: 30
  Users logged in: 0
  IPv4 address for eth0: 10.46.74.13
  IPv6 address for eth0: fd42:f539:1893:d366:216:3eff:fe2a:1d97

 * Strict...

[Renan Rodrigo (renanrodrigo)]

Now, to the actual functionality test on Jammy:

Jammy is an LTS release still supported, so messages about esm-apps will be present in MOTD by default.
After creating the marker file and triggering an update of MOTD, those messages disappear, but the updates count remains.

root@jammy-sut:~# apt policy update-notifier-common
update-notifier-common:
  Installed: 3.192.54.8
  Candidate: 3.192.54.8
  Version table:
 *** 3.192.54.8 500
        500 http://archive.ubuntu.com/ubuntu jammy-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     3.192.54.6 500
        500 http://archive.ubuntu.com/ubuntu jammy-updates/main amd64 Packages
     3.192.54 500
        500 http://archive.ubuntu.com/ubuntu jammy/main amd64 Packages
root@jammy-sut:~# run-parts /etc/update-motd.d/
Welcome to Ubuntu 22.04.4 LTS (GNU/Linux 6.5.0-21-generic x86_64)

 * Documentation: https://help.ubuntu.com
 * Management: https://landscape.canonical.com
 * Support: https://ubuntu.com/pro

  System information as of Fri Mar 15 23:08:15 UTC 2024

  System load: 1.2568359375
  Usage of /home: unknown
  Memory usage: 0%
  Swap usage: 0%
  Temperature: 86.0 C
  Processes: 24
  Users logged in: 0
  IPv4 address for eth0: 10.46.74.160
  IPv6 address for eth0: fd42:f539:1893:d366:216:3eff:fea1:40fb

Expanded Security Maintenance for Applications is not enabled.

25 updates can be applied immediately.
To see these additional updates run: apt list --upgradable

Enable ESM Apps to receive additional future security updates.
See https://ubuntu.com/esm or run: sudo pro status

root@jammy-sut:~# touch /var/lib/update-notifier/hide-esm-in-motd
root@jammy-sut:~# rm /var/lib/update-notifier/updates-available
root@jammy-sut:~# apt update
Hit:1 http://archive.ubuntu.com/ubuntu jammy InRelease
Hit:2 http://security.ubuntu.com/ubuntu jammy-security InRelease
Hit:3 http://archive.ubuntu.com/ubuntu jammy-updates InRelease
Hit:4 http://archive.ubuntu.com/ubuntu jammy-backports InRelease
Hit:5 http://archive.ubuntu.com/ubuntu jammy-proposed InRelease
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
27 packages can be upgraded. Run 'apt list --upgradable' to see them.
root@jammy-sut:~# run-parts /etc/update-motd.d/
Welcome to Ubuntu 22.04.4 LTS (GNU/Linux 6.5.0-21-generic x86_64)

 * Documentation: https://help.ubuntu.com
 * Management: https://landscape.canonical.com
 * Support: https://ubuntu.com/pro

  System information as of Fri Mar 15 23:08:15 UTC 2024

  System load: 1.2568359375
  Usage of /home: unknown
  Memory usage: 0%
  Swap usage: 0%
  Temperature: 86.0 C
  Processes: 24
  Users logged in: 0
  IPv4 address for eth0: 10.46.74.160
  IPv6 address for eth0: fd42:f539:1893:d366:216:3eff:fea1:40fb

25 updates can be applied immediately.
To see these additional updates run: apt list --upgradable

I am marking this bug verification-done on Jammy, and verification-done overall as this is the last release to test.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted update-notifier (3.168.22) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

update-notifier/blacklisted (arm64, armhf, ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#update-notifier

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Andreas Hasenack (ahasenack)]

I retriggered the xenial autopkgtests which were denylisted for some architectures.

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-notifier - 3.192.54.8

---------------
update-notifier (3.192.54.8) jammy; urgency=medium

  * update-motd: use a marker file to hide ESM messages (LP: #2015420)

 -- Renan Rodrigo Barbosa <email address hidden> Mon, 04 Mar 2024 07:49:00 -0300

[Timo Aaltonen (tjaalton)]

The verification of the Stable Release Update for update-notifier has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-notifier - 3.192.30.19

---------------
update-notifier (3.192.30.19) focal; urgency=medium

  * update-motd: use a marker file to hide ESM messages (LP: #2015420)

 -- Renan Rodrigo Barbosa <email address hidden> Mon, 04 Mar 2024 07:57:08 -0300

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-notifier - 3.192.1.21

---------------
update-notifier (3.192.1.21) bionic; urgency=medium

  * update-motd: use a marker file to hide ESM messages (LP: #2015420)

 -- Renan Rodrigo Barbosa <email address hidden> Mon, 04 Mar 2024 08:04:19 -0300

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-notifier - 3.168.22

---------------
update-notifier (3.168.22) xenial; urgency=medium

  * update-motd: use a marker file to hide ESM messages (LP: #2015420)

 -- Renan Rodrigo Barbosa <email address hidden> Mon, 04 Mar 2024 08:17:07 -0300

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-notifier - 3.192.68build1

---------------
update-notifier (3.192.68build1) noble; urgency=medium

  * No-change rebuild against libglib2.0-0t64

 -- Steve Langasek <email address hidden> Mon, 11 Mar 2024 23:47:11 +0000