/usr/bin/software-properties-gtk:AttributeError:on_pktask_finish:net_status_changed

[errors.ubuntu.com bug bridge]

* Impact

The change from the previous revision to handle connectivity change use an API not available on focal and trigger an exception

* Test case

- detach the system from ubuntu pro if it's attached
- open software-properties
- go the ubuntu pro tab
- click on 'enable ubuntu pro'
- while the dialog is open disconnect and reconnect the network
- change the selection from manual token to PIN

the UI should update and no error should be triggered

Check also that the error reports stop for the new version (url referenced below)

* Regression potential

If the callback were not working as expected the UI could end up not responding to status change or not accepting the PIN or token entered, validate that the different methods still work as expected to register

--------------------------

The Ubuntu Error Tracker has been receiving reports about a problem regarding software-properties. This problem was most recently seen with package version 0.99.9.11, the problem page at https://errors.ubuntu.com/problem/22525c20f3bbf4ac03854d8a844e8d5f746b2959 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

[Sebastien Bacher (seb128)]

The packagekit exception doesn't seem a recent change but the report also include

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/softwareproperties/gtk/DialogUaAttach.py", line 196, in net_status_changed
    self.poll = GLib.Thread.new("poll", self.poll_for_magic_token)
AttributeError: type object 'Thread' has no attribute 'new'

[Robie Basak (racb)]

Could you please confirm that this fix isn't relevant for releases after Focal - ie. that the necessary API exists in Jammy onwards? It may be that you implied this already, but the bug status isn't set separately and I can't find anything that states this unambiguously so I want to make sure it isn't being accidentally missed.

[Robie Basak (racb)]

I've set the bug statuses to Incomplete for the benefit of future SRU reviewers; please reset to their correct statuses once you've answered.

[Nathan Teodosio (nteodosio)]

That fix isn't relevant for releases after Focal; The necessary API exists for Jammy onwards.

[Robie Basak (racb)]

> bug added by the previous revision

Tagging regression-update then, FTR, for future regression risk analysis.

> That fix isn't relevant for releases after Focal; The necessary API exists for Jammy onwards.

OK thanks. Then the correct bug task status for Jammy onwards is Invalid or maybe Fix Released, so I'll change that.

[Robie Basak (racb)]

Hello errors.ubuntu.com, or anyone else affected,

Accepted software-properties into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/software-properties/0.99.9.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted software-properties (0.99.9.12) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

crash/7.2.8-1ubuntu1.20.04.1 (arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#software-properties

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Sebastien Bacher (seb128)]

The autopkgtest issue raised before has been resolved after a retry it seems.

[Andreas Hasenack (ahasenack)]

Nathan, I see you changed the verification flags, but I don't see a test plan execution.

The verification tags should only be flipped after a successful execution of the agreed upon test case from the description of this bug.

[Nathan Teodosio (nteodosio)]

Hi Andreas, sorry that I did not state the test plan I went through.

I made sure the system was detached from Ubuntu Pro, opened software-properties in Ubuntu Pro tab and clicked 'enable Ubuntu Pro'. Selected the radio second button, for manual token input, I disconnected and a few seconds after reconnected the network, and then changed to the first radio button (PIN).

The error "AttributeError: type object 'Thread' has no attribute 'new'" is no longer triggered and the UI functions normally, so the test plan was carried out successfully.

[Launchpad Janitor (janitor)]

This bug was fixed in the package software-properties - 0.99.9.12

---------------
software-properties (0.99.9.12) focal; urgency=medium

  [ Nathan Pratta Teodosio ]
  * Don't use a glib API which isn't available in the focal version,
    bug added by the previous revision (lp: #2011415)

 -- Sebastien Bacher <email address hidden> Tue, 21 Mar 2023 16:23:10 +0100

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for software-properties has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.