(Hardy) please remove Network Manager Editor from Internet and Preferences

[David Prieto]

Binary package hint: network-manager

NM 0.66 includes Network Manager Editor, which seems to list networks you've accessed. It seems to have a launcher both in Programs → Internet, and System → Preferences.

Please remove at least one of these entries (preferably both), it crowds the menus and can be accessed by right-clicking the NM applet anyway.

[Alexander Jones (alex-weej)]

I suggest we remove it from Internet, and leave it in Preferences.

The Desktop Entry name, should, however, be renamed to "Wireless Networks", as per the window title of the actual program and the context menu option "Edit Wireless Networks..." on the panel applet.

[Alexander Jones (alex-weej)]

[Desktop Entry]
Version=1.0
Encoding=UTF-8
Name=Wireless Networks
Comment=Edits the wireless networks used by Network Manager
Icon=nm-device-wireless
Exec=nm-editor
Terminal=false
Type=Application
Categories=Settings;
OnlyShowIn=GNOME;
X-GNOME-Bugzilla-Bugzilla=GNOME
X-GNOME-Bugzilla-Product=NetworkManager
X-GNOME-Bugzilla-Component=general

[Alexander Jones (alex-weej)]

Whoops, I forgot to mention that I took the liberty of changing the string
for "Comment" from "in Network Manager" to "by Network Manager" in the
posted Desktop Entry, as there were no translations anyway.

[Sebastien Bacher (seb128)]

There is already too menu items in preferences, do we really need it there?

[Alexander Jones (alex-weej)]

I'd argue not, it's pretty useless as-is.

[Սահակ (petrosyan)]

"Edits the wireless networks used by Network Manager" does not sound right.

The comment field should be phrased an imperative verb.
http://library.gnome.org/devel/hig-book/stable/desktop-application-menu.html.en#menu-item-tooltips

So I suggest:

Comment=Edit wireless networks used by Network Manager

[Steve Langasek (vorlon)]

Attached is a patch which removes the .desktop file from the package altogether. It seems to be the consensus in this report that it doesn't need to be in either menu given that it's accessible through the applet itself, so I guess this is the correct change?

[Alexander Jones (alex-weej)]

Hi Steve

On Wed, Mar 26, 2008 at 8:44 PM, Steve Langasek <
<email address hidden>> wrote:

> It seems to be the consensus in this report that it doesn't
> need to be in either menu given that it's accessible through the applet
> itself

I'm pretty sure the .desktop file is necessary for things like bug reporting
etc. to work properly. Please leave it in, just hide it in the menus if you
must.

Personally, I still think the name should be changed to Wireless Networks.

[Steve Langasek (vorlon)]

Alexander,

I'm not aware of any reason that the .desktop file would be needed for bug reporting; I don't see anything in the desktop file that's relevant to bug reporting and don't know of any bug reporting tools in Ubuntu that would require such a file.

So after talking with Alexander Sack, I'm going to go ahead with an upload which drops the .desktop file. If you find that this indeed causes problems after the upload, feel free to reopen this bug with more information.

[Launchpad Janitor (janitor)]

This bug was fixed in the package network-manager-applet - 0.6.6-0ubuntu2

---------------
network-manager-applet (0.6.6-0ubuntu2) hardy; urgency=low

  * Drop nm-editor.desktop from the package; this tool is always accessible
    from the applet context menu, so doesn't need to be exposed elsewhere.
    LP: #201127.

 -- Steve Langasek <email address hidden> Wed, 26 Mar 2008 16:49:02 -0700