[SRU] libreoffice 7.4.6 for kinetic

[Rico Tzschichholz]

[Impact]

 * LibreOffice 7.4.6 is in its sixth bugfix release of the 7.4 line:
     https://wiki.documentfoundation.org/ReleasePlan/7.4#7.4.6_release

 * Version 7.4.4 is currently released in kinetic. For a list of fixed bugs compared to 7.4.5 see the list of bugs fixed in the release candidates of 7.4.6 (that's a total of 74 bugs):
     https://wiki.documentfoundation.org/Releases/7.4.6/RC1#List_of_fixed_bugs
     https://wiki.documentfoundation.org/Releases/7.4.6/RC2#List_of_fixed_bugs
 * 7.4.5 was an intermediate hotfix release with one bug fix which got cherry-picked as 1:7.4.4-0ubuntu0.22.10.2

 * Given the nature of the project, the complexity of the codebase and the high level of quality assurance upstream, it is preferable to SRU a minor release rather than cherry-pick selected bug fixes.

[Testing]

 * Upstream testing. Bugs fixed upstream typically include unit/regression tests, and the release itself is extensively exercised (both in an automated manner and manually).

  * A recent set of upstream's automated jenkins testing can be found here:
    https://ci.libreoffice.org/job/gerrit_74/1717/

  * More information about the upstream QA testing can be found here:
    * Automated tests
      https://wiki.documentfoundation.org/QA/Testing/Automated_Tests
    * Automated UI tests
      https://wiki.documentfoundation.org/Development/UITests
    * Regression tests
      https://wiki.documentfoundation.org/QA/Testing/Regression_Tests
    * Feature tests
      https://wiki.documentfoundation.org/QA/Testing/Feature_Tests

 * Launchpad testing. The libreoffice packages include autopkgtests that were run and verified as passing.
    * [amd64] https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-ricotz-ppa/kinetic/amd64/libr/libreoffice/20230308_174140_556be@/log.gz
    * [arm64] https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-ricotz-ppa/kinetic/arm64/libr/libreoffice/20230308_194429_0c8b8@/log.gz
    * [armhf] https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-ricotz-ppa/kinetic/armhf/libr/libreoffice/20230308_202215_690b5@/log.gz
    * [ppc64el] https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-ricotz-ppa/kinetic/ppc64el/libr/libreoffice/20230308_174403_74fe7@/log.gz
    * [s390x] https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-ricotz-ppa/kinetic/s390x/libr/libreoffice/20230308_200234_9c534@/log.gz
 * General smoke testing of all the applications in the office suite were carried out by going through the manual testplan as documented by: https://wiki.ubuntu.com/Process/Merges/TestPlans/libreoffice

[Regression Potential]

 * A minor release with a total of 74 bug fixes always carries the potential for introducing regressions, even though it is a bugfix-only release, meaning that no new features were added, and no existing features were removed.

 * A combination of autopkgtests and careful smoke testing as described above should provide reasonable confidence that no regressions sneaked in.

[Steve Langasek (vorlon)]

- Dropping of debian/patches/tdf153059-after-ChangeHeaderOrFooter-the-c.patch is not documented in the changelog and needs to be. If this is dropped because it's now applied upstream, the changelog should say this.
- The changing of debian/*.symbols in an SRU is weird. I see no reason to have these libraries emit a versioned dependency on libstdc++ themselves, this looks to me like it should have been a change to the lintian overrides only; and I'm not happy to sign off on this in an SRU without further rationale/explanation.
- There is no rationale given for disabling 'make check' on s390x and reducing test coverage in an SRU is almost always a no-go.

[Rico Tzschichholz (ricotz)]

@vorlon Thanks for your review.

tdf153059-after-ChangeHeaderOrFooter-the-c.patch was the only change in the unscheduled 7.4.5 hotfix release, and was cherry picked to avoid a full-source upload. https://wiki.documentfoundation.org/Releases/7.4.5/RC1
https://bugs.launchpad.net/df-libreoffice/+bug/2003735

For the debian/*.symbols, I trust Rene that this is a proper way of dealing with those special library packages.

Dropping "make check for s390x" is rather frustrating while the launchpad s390x builders are silently stopping without providing any log for investigation (Retried multiple times with 7.4.4 to no avail). Having the autopkgtest running afterwards covers the test-suite as well.

https://git.launchpad.net/~libreoffice/ubuntu/+source/libreoffice/log/?h=wip/kinetic-7.4

[Rico Tzschichholz (ricotz)]

@vorlon I have uploaded a repack with an extended changelog.

[Rico Tzschichholz (ricotz)]

@vorlon I have uploaded a repack and dropped the troublesome lintian fixes for symbol files.

https://git.launchpad.net/~libreoffice/ubuntu/+source/libreoffice/log/?h=wip/kinetic-7.4

[Steve Langasek (vorlon)]

Hello Rico, or anyone else affected,

Accepted libreoffice into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libreoffice/1:7.4.6-0ubuntu0.22.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Rico Tzschichholz (ricotz)]

Upgraded libreoffice from 1:7.4.4-0ubuntu0.22.10.2 to 1:7.4.6-0ubuntu0.22.10.1 from kinetic-proposed in a clean and up-to-date kinetic amd64 VM, and successfully ran test plan at https://wiki.ubuntu.com/Process/Merges/TestPlans/libreoffice.

[Launchpad Janitor (janitor)]

This bug was fixed in the package libreoffice - 1:7.4.6-0ubuntu0.22.10.1

---------------
libreoffice (1:7.4.6-0ubuntu0.22.10.1) kinetic; urgency=medium

  * New upstream release (LP: #2009354)

  [ Rico Tzschichholz ]
  * Drop upstreamed patches
    - debian/patches/tdf153059-after-ChangeHeaderOrFooter-the-c.patch
  * debian/rules:
    - Disable make check on s390x (builders failing without a log),
      the autopkgtests are still providing runtime checks
  * debian/control{.in}:
    - Add missing Breaks on -core-nogui in -common
  * tests/patches/s390x-skip-tests.diff:
    - Skip four more failing tests on s390x

  [ Rene Engelhard ]
  * debian/rules: Use system-lockfile; lockfile is actually built during the
    build in non-cross builds
  * debian/rules: also add forgotten DEB_LDFLAGS_MAINT_STRIP for -flto=auto
    and (if using "small symbols" anyway -ffat-lto-objects)
  * debian/rules:
    - set extra builid to BINARY_VERSION instead of DEB_VERSION to reflect
      the actual binary package version of libreoffice-core if they differed
  * debian/rules:
    - Do not add documentation symlinks when not building documentation

 -- Rico Tzschichholz <email address hidden> Wed, 08 Mar 2023 17:34:09 +0100

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for libreoffice has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.