Option to Hide Strict Barcode

[Jennifer Pringle]

Evergreen 3.9.1

Check Out and Check In both have a Strict Barcode checkbox which alerts staff to barcodes with bad check digits.

We have many libraries with current or legacy barcodes that do not use check digits. Most of our libraries never want to use the strict barcode option.

It would be helpful if Strict Barcode could be removed on a per library basis so the option only shows for libraries that actually use the function (which would cuts down on the number of times the box is accidentally checked. Maybe a library setting for it.

[Joan Kranich (jkranich)]

If a setting was added to remove/hide the Strict Barcode checkbox, it should also set the checkbox to unchecked when removing it from the screen for the entire system or for a specific library. I am concerned that if we remove/hide the checkbox, it may already be checked and could not be unchecked if not visible.

C/W MARS should never have the Strict Barcode checked but it does happen.

[Scott Angel (scottangel1)]

Being I moved the checkbox I'll tackle this one too!

[Jennifer Pringle (jpringle-u)]

+1 to Joan's comment, if the checkbox isn't visible the strict checkbox functionality shouldn't apply at all.

[Elizabeth Thomsen (et-8)]

And being the submitter of https://bugs.launchpad.net/evergreen/+bug/1990968 which caused the checkbox to be moved to a more prominent location, I'm glad Jennifer added this one and that Scott is willing to tackle it!

This should be better for everyone -- those who wanted this to be more prominent and those who wanted it to be gone!

[Jennifer Pringle (jpringle-u)]

Turns out this is a duplicate of https://bugs.launchpad.net/evergreen/+bug/1969235, somehow I missed it when searching.

Since Scott is assigned to this bug I'm not going to mark it as a duplicate but one of the bugs should eventually be marked as a duplicate of the other.

[Scott Angel (scottangel1)]

Should the 'Offline Mode' strict barcode checkbox be hidden too if the org setting is enabled? I assume so but figured I would ask.

[Jennifer Pringle (jpringle-u)]

My vote is to hide it in Offline as well.

[Joan Kranich (jkranich)]

I agree to hiding strict barcode in Offline too.

[Scott Angel (scottangel1)]

Vote is 3-0 in favor of hiding strict barcode in Offline mode as well. The people have spoken! The court of Evergreen is now adjourned. lol

[Scott Angel (scottangel1)]

So I've got something worked up for hiding the strict barcode checkbox via org setting. The offline mode will need testing & may need to be changed. The way it currently works (and this may be fine) is the workstation needs to have logged into the staff client & access either the checkin, checkout or renew pages in order to cache the setting required for the offline mode to work correctly.

I wanted to write up some release notes for this. I'm still learning how Evergreen handles everything but I wanted to push my code so it can be tested and we can ascertain if this is correct or if it still needs work. It's mainly the offline mode I'm concerned about. Then I write some docs/release notes.

The org setting is located at
Administration -> Local Administration -> Library Settings Editor -> Hide Strict Barcode checkbox on patron checkout/checkin/renew screens

Here's my branch
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/scottangel/LP2008834-option-to-hide-strict-barcode

[Galen Charlton (gmc)]

Noting that it would be good for the branch to also include the Angular circ interfaces.

[Scott Angel (scottangel1)]

Finally was able to wrap this up. Busy busy! I got the Angular side of this completed.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/scottangel/LP2008834-option-to-hide-strict-barcode

[Tiffany Little (tslittle)]

Got merge conflicts when trying to apply to a server for Bug Squashing Week. Scott, could you rebase? Thanks!

[Scott Angel (scottangel1)]

I got that branch cleaned up. It should be ready for testing now. Looks like some bootstrap stuff got updated since this was originally pushed.

[Scott Angel (scottangel1)]

I've been trying to test this. Works on my machine. Not on a test server. Classic. I'm removing the pullrequest until I get this figured out. Sorry for any confusion.

[Scott Angel (scottangel1)]

Finally fixed. I got busy with other work and hadn't pushed the final rebase. Thanks Hack-a-way!
Here's my branch.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=46b24193d51179e0a23c58988aca2a62a9cf7896

[Jane Sandberg (sandbergja)]

Thanks for this patch, Scott! It's 99% there! There were just 3 things I noticed:

* Your upgrade script adds a setting called "circ.hide_patron_strict_barcode", but the Angular and AngularJS parts consult a setting called "ui.circ.hide_patron_strict_barcode" (with ui at the start). These should match, or else the feature doesn't work.
* The new setting should also be included in the 950.data.seed-values.sql file, so that new installations also get this setting.
* For the angular parts, you will want `this.org.settings('ui.circ.hide_patron_strict_barcode')`, rather than `this.store.getItem` or `this.serverStore.getItem`

[Jane Sandberg (sandbergja)]

Removing the 3.12 target since feature freeze is imminent, but if you're able to repatch this before then, Scott, please feel free to add it back.