Unable to update non-HTTP/HTTPS healthmonitors

[Kellen Renshaw]

[ Impact ]

 * This bug prevents updating checks that are not HTTP or HTTPS. This requires users to delete and recreate checks instead of being able to update them.

[ Test Plan ]

 * Set up and configure Octavia and Octavia Dashboard < v10.
 * Create a PING health check.
 * Attempt to update a parameter of the PING healthcheck.

[ Where problems could occur ]

 * Automation that expects updates to fail for non-HTTP/HTTPS healthmonitors could react poorly to being able to update the healthmonitor.
 * Enabling updates to existing non-HTTP/HTTPS healthmonitors via the Dashboard could expose other bugs in the update handling.

[ Other Info ]

 * Fixed upstream in version 10.0.0
 * https://opendev.org/openstack/octavia-dashboard/commit/a8dc94fdbd4b46b16d77a2cd63931ee4078e48f9#diff-6646a6e936c655a68b2be045a09c656f74e5f1b3
 * Fix was backported to all major version prior but is not released requiring a patch for the related packages.

[Nicolas Bock (nicolasbock)]

This is a debdiff to update the package on Focal to 5.0.2 and apply the missing patches on top of this point release.

[Heitor Alves de Siqueira (halves)]

Marking Bionic as "Invalid", as this release is out of standard support. If this backport has been requested there, please target it against the Ubuntu Pro project or against UCA. Thanks!

[Corey Bryant (corey.bryant)]

@Nicolas, would you be able to update the bug to describe why the other patches are included? We'll also need to patch victoria, wallaby and xena if you're able to provide debdiffs for them. If not I can pick those up.

[Nicolas Bock (nicolasbock)]

Hi Corey,

I recreated the debdiffs on Focal and only added the patch needed to resolve this ticket here. Please let me know if those debdiffs work.

Thanks!

[Corey Bryant (corey.bryant)]

Thanks Nicolas. I've uploaded new packages versions with the patch to jammy and focal unapproved queues as well as the victoria, wallaby, xena staging PPAs (ussuri and yoga staging will get backports from focal and jammy once they are in proposed). Please take a look at one of the uploads as I made some changes to the changelog and patch name.

[Corey Bryant (corey.bryant)]

Hello Kellen, or anyone else affected,

Accepted octavia-dashboard into victoria-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:victoria-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-victoria-needed to verification-victoria-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-victoria-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

Hello Kellen, or anyone else affected,

Accepted octavia-dashboard into wallaby-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:wallaby-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-wallaby-needed to verification-wallaby-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-wallaby-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

Hello Kellen, or anyone else affected,

Accepted octavia-dashboard into xena-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:xena-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-xena-needed to verification-xena-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-xena-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Robie Basak (racb)]

Hello Kellen, or anyone else affected,

Accepted octavia-dashboard into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/octavia-dashboard/9.0.0-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Robie Basak (racb)]

Hello Kellen, or anyone else affected,

Accepted octavia-dashboard into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/octavia-dashboard/5.0.0-0ubuntu0.20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Corey Bryant (corey.bryant)]

Hello Kellen, or anyone else affected,

Accepted octavia-dashboard into ussuri-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:ussuri-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-ussuri-needed to verification-ussuri-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-ussuri-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

Hello Kellen, or anyone else affected,

Accepted octavia-dashboard into yoga-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:yoga-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-yoga-needed to verification-yoga-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-yoga-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Robie Basak (racb)]

SRU release in Ubuntu is blocked on the steps requested in comments 17 and 18 being carried out. Please do not set the tags until they are done.

[Nicolas Bock (nicolasbock)]

Thanks Robie, I will add more details on my testing.

[Nicolas Bock (nicolasbock)]

Focal-Ussuri:

1. Deploy openstack-dashboard with python3-octavia-dashboard 5.0.0-0ubuntu0.20.04.1
2. Create load balancer with PING healthmonitor
3. Confirm that admin state of health monitor cannot be altered via UI ([Wed Aug 16 17:30:50.440462 2023] [wsgi:error] [pid 899:tid 140301958235904] [remote 10.5.0.22:39444] Bad Request: /api/lbaas/healthmonitors/07aa837e-3e03-489f-a794-5ce2a5e6f0df/)
4. Enable proposed pocket and install python3-octavia-dashboard 5.0.0-0ubuntu0.20.04.2
5. Confirm that admin state can be changed via UI

focal-ussuri done

[Nicolas Bock (nicolasbock)]

Jammy-Yoga:

1. Deploy openstack-dashboard with python3-octavia-dashboard 9.0.0-0ubuntu1
2. Create load balancer with PING healthmonitor
3. Confirm that admin state of health monitor cannot be altered via UI
4. Enable proposed pocket and install python3-octavia-dashboard 9.0.0-0ubuntu1.1
5. Confirm that admin state can be changed via UI

jammy-yoga done

[Heather Lemon (hypothetical-lemon)]

### VERIFICATION DONE FOCAL-YOGA ###

1. Deploy openstack dashboard with python3-octavia-dashboard: 9.0.0-0ubuntu1~cloud0
2. Create load balancer with PING health monitor
3. Confirm the admin state cannot be changes via horizon UI
 - under loadbalancer -> Pools -> Health Monitors -> edit Health Monitor button
 - try to change admin state (see photo of error)
4. Enable proposed pocket and install python3-octavia-dashboard: 9.0.0-0ubuntu1.1~cloud0
 - verify python3-octavia-dashboard version: apt-cache policy python3-octavia-dashboard
 - systemctl status restart apache2.service
5. Confirm admin state can be updated in the horizon UI <changed from yes to no and save>

### VERIFICATION DONE FOCAL-YOGA ###

focal-yoga done

[Launchpad Janitor (janitor)]

This bug was fixed in the package octavia-dashboard - 9.0.0-0ubuntu1.1

---------------
octavia-dashboard (9.0.0-0ubuntu1.1) jammy; urgency=medium

  [ Corey Bryant ]
  * d/gbp.conf: Create stable/yoga branch.

  [ Nicolas Bock ]
  * d/p/fix-updating-non-https-health-monitor.patch: Fix updating a non-HTTP(S)
    Health Monitor (LP: #2007720).

 -- Nicolas Bock <email address hidden> Thu, 27 Jul 2023 20:05:56 +0000

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for octavia-dashboard has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package octavia-dashboard - 5.0.0-0ubuntu0.20.04.2

---------------
octavia-dashboard (5.0.0-0ubuntu0.20.04.2) focal; urgency=medium

  [ Chris MacNaughton ]
  * d/control: Update VCS paths for move to lp:~ubuntu-openstack-dev.

  [ Nicolas Bock ]
  * d/p/fix-updating-non-https-health-monitor.patch: Fix updating a non-HTTP(S)
    Health Monitor (LP: #2007720).

 -- Nicolas Bock <email address hidden> Thu, 27 Jul 2023 17:50:29 +0000

[Heather Lemon (hypothetical-lemon)]

photo of error thrown in UI

[Heather Lemon (hypothetical-lemon)]

### VERIFICATION DONE FOCAL-WALLABY ###

1. Deploy openstack dashboard with python3-octavia-dashboard: 7.0.0-0ubuntu1~cloud0
2. Create load balancer with PING health monitor
3. Confirm the admin state cannot be changes via horizon UI
 - under loadbalancer -> Pools -> Health Monitors -> edit Health Monitor button
 - try to change admin state (see photo of error)
4. juju ssh openstack-dashboard/0*
 - Enable proposed pocket and install python3-octavia-dashboard: 9.0.0-0ubuntu1.1~cloud0
 - verify python3-octavia-dashboard version: apt-cache policy python3-octavia-dashboard
 - systemctl status restart apache2.service (confirm not errors in logs)
 - exit
5. Confirm admin state can be updated in the horizon UI <changed from yes to no and save>

### VERIFICATION DONE FOCAL-WALLABY ###

focal-wallaby done

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for octavia-dashboard has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package octavia-dashboard - 9.0.0-0ubuntu1.1~cloud0
---------------

 octavia-dashboard (9.0.0-0ubuntu1.1~cloud0) focal-yoga; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 octavia-dashboard (9.0.0-0ubuntu1.1) jammy; urgency=medium
 .
   [ Corey Bryant ]
   * d/gbp.conf: Create stable/yoga branch.
 .
   [ Nicolas Bock ]
   * d/p/fix-updating-non-https-health-monitor.patch: Fix updating a non-HTTP(S)
     Health Monitor (LP: #2007720).

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for octavia-dashboard has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package octavia-dashboard - 8.0.0-0ubuntu1~cloud1
---------------

 octavia-dashboard (8.0.0-0ubuntu1~cloud1) focal-xena; urgency=medium
 .
   [ Corey Bryant ]
   * d/gbp.conf: Create stable/xena branch.
 .
   [ Nicolas Bock ]
   * d/p/fix-updating-non-https-health-monitor.patch: Fix updating a non-HTTP(S)
     Health Monitor (LP: #2007720).

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for octavia-dashboard has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package octavia-dashboard - 7.0.0-0ubuntu1~cloud1
---------------

 octavia-dashboard (7.0.0-0ubuntu1~cloud1) focal-wallaby; urgency=medium
 .
   [ Corey Bryant ]
   * d/gbp.conf: Create stable/wallaby branch.
 .
   [ Nicolas Bock ]
   * d/p/fix-updating-non-https-health-monitor.patch: Fix updating a non-HTTP(S)
     Health Monitor (LP: #2007720).

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for octavia-dashboard has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package octavia-dashboard - 6.0.0-0ubuntu1~cloud1
---------------

 octavia-dashboard (6.0.0-0ubuntu1~cloud1) focal-victoria; urgency=medium
 .
   [ Corey Bryant ]
   * d/gbp.conf: Create stable/victoria branch.
 .
   [ Nicolas Bock ]
   * d/p/fix-updating-non-https-health-monitor.patch: Fix updating a non-HTTP(S)
     Health Monitor (LP: #2007720).